[GitHub] [hbase] HorizonNet commented on a change in pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

[GitBox]

HorizonNet commented on a change in pull request #2542:
URL: https://github.com/apache/hbase/pull/2542#discussion_r513798278



##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java
##
@@ -35,13 +35,21 @@
   // the specification of server hostname is optional. The hostname should be 
resolvable from
   // both master and region server
   @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
-  public static final String RS_HOSTNAME_KEY = "hbase.regionserver.hostname";
+  public static final String UNSAFE_RS_HOSTNAME_KEY = 
"hbase.unsafe.regionserver.hostname";
   @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
   public static final String MASTER_HOSTNAME_KEY = "hbase.master.hostname";
 
   private static boolean HAS_NEW_DNS_GET_DEFAULT_HOST_API;
   private static Method GET_DEFAULT_HOST_METHOD;
 
+  /**
+   * @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0.

Review comment:
   It's fine to only mention the first release it gets deprecated. It would 
also be great if you could add the link to the deprecating ticket via a `@see` 
annotation (you'll find an example 
[here](https://github.com/ultratendency/hbase/blob/74d37eace9218d626586e8afee751eb52bbe5311/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java#L1363)).

##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -467,13 +467,31 @@
   protected String useThisHostnameInstead;
 
   /**
-   * HBASE-18226: This config and hbase.regionserver.hostname are mutually 
exclusive.
-   * Exception will be thrown if both are used.
+   * @deprecated since 2.4.0 and in 3.0.0, to be removed in 4.0.0.

Review comment:
   Ditto.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] HorizonNet commented on a change in pull request #2542: HBASE-24667 Rename configs that support atypical DNS set ups to put them in hbase.unsafe

[GitBox]

HorizonNet commented on a change in pull request #2542:
URL: https://github.com/apache/hbase/pull/2542#discussion_r504998610



##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -466,13 +466,31 @@
*/
   protected String useThisHostnameInstead;
 
+  /**
+   * @deprecated

Review comment:
   Please also add the version when this one was deprecated and in which 
release it is going to be removed. Check the [HBase 
book](https://hbase.apache.org/book.html#hbase.versioning.post10) for details.

##
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##
@@ -466,13 +466,31 @@
*/
   protected String useThisHostnameInstead;
 
+  /**
+   * @deprecated
+   *  Use {@link 
HRegionServer#UNSAFE_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY} instead.
+   */
+  @Deprecated
+  @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+  final static String DEPRECATED_RS_HOSTNAME_DISABLE_MASTER_REVERSEDNS_KEY =

Review comment:
   Why not stick with the previous constant name?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org