[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137703#comment-16137703
]
Mike Drob edited comment on HBASE-17614 at 8/23/17 1:01 AM:
bq. Mike Drob, you all-clear now? Or should I still tread lightly on branch-2
to avoid smacking you?
Nah, do whatever. Master you'll want parent to be {{hbase-build-configuration}}
and branch-2 you'll want {{hbase}}, but you will need to adjust for version in
the pom.xml anyway, so it's not like you were getting a clean backport. If
error-prone ends up getting backported to branch-2 (I keep waffling back and
forth on this) then I'll deal with the conflicts then, you shouldn't have to
worry about making less work for me at this point.
Edit: Basically, copy the {{}} block out of hbase-server/pom.xml in
both cases, and you'll be good to go.
was (Author: mdrob):
bq. Mike Drob, you all-clear now? Or should I still tread lightly on branch-2
to avoid smacking you?
Nah, do whatever. Master you'll want parent to be {{hbase-build-configuration}}
and branch-2 you'll want {{hbase}}, but you will need to adjust for version in
the pom.xml anyway, so it's not like you were getting a clean backport. If
error-prone ends up getting backported to branch-2 (I keep waffling back and
forth on this) then I'll deal with the conflicts then, you shouldn't have to
worry about making less work for me at this point.
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137651#comment-16137651 ] Vladimir Rodionov edited comment on HBASE-17614 at 8/23/17 12:16 AM: - v5 adds log4j.properties file to backup module resources folder, thanks [~elserj] was (Author: vrodionov): v5 adds log4j.properties file to backup module resources folder > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137579#comment-16137579 ] Vladimir Rodionov edited comment on HBASE-17614 at 8/22/17 11:15 PM: - On my MBP 2014 test takes 105 sec to finish OK, this looks weird. When I tried what [~elserj] runs : *mvn clean package -Dtest=.. * - it failed with the same error. I usually run tests using : *mvn test -Dtest=... * - this runs OK for the test. [~elserj], can you try *mvn test*? Upd: never mind was (Author: vrodionov): On my MBP 2014 test takes 105 sec to finish OK, this looks weird. When I tried what [~elserj] runs : *mvn clean package -Dtest=.. * - it failed with the same error. I usually run tests using : *mvn test -Dtest=... * - this runs OK for the test. [~elserj], can you try *mvn test*? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137441#comment-16137441
]
Josh Elser edited comment on HBASE-17614 at 8/22/17 9:33 PM:
-
{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.919 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
Time elapsed: 54.294 sec <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
at
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:94)
{noformat}
with a change of
{noformat}
diff --git
a/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
b/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
index 5f72f458b9..e888f98f8e 100644
---
a/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
+++
b/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java
@@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.backup.master;
+import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
@@ -90,7 +91,7 @@ public class TestBackupLogCleaner extends TestBackupBase {
deletable = cleaner.getDeletableFiles(walFiles);
// We can delete wal files because they were saved into backup system
table table
size = Iterables.size(deletable);
- assertTrue(size == walFiles.size());
+ assertEquals(size, walFiles.size());
List newWalFiles =
getListOfWALFiles(TEST_UTIL.getConfiguration());
LOG.debug("WAL list after full backup");
{noformat}
was (Author: elserj):
{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.919 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
Time elapsed: 54.294 sec <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
at
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:94)
{noformat}
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137223#comment-16137223
]
Vladimir Rodionov edited comment on HBASE-17614 at 8/22/17 7:15 PM:
{quote}
downloaded the patch and tried running the tests locally
{quote}
Verified locally. All test pass. TestHFileArchiving is not backup test and is
not part of this feature (but it runs OK as well). I accidentally moved it to
backup module. v4 reverts this move.
Backup tests do not touch this property
*hbase.hregion.memstore.flush.size*
[~elserj], the patch is ready and wants to be committed :)
was (Author: vrodionov):
{quote}
downloaded the patch and tried running the tests locally
{quote}
Verified locally. All test pass. TestHFileArchiving is not backup test and is
not part of this feature (but it runs OK as well). I accidentally moved it to
backup module. v4 reverts this move.
[~elserj], the patch is ready and wants to be committed :)
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
