[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853978#comment-13853978
]
Hudson commented on HBASE-10138:
FAILURE: Integrated in HBase-0.98 #26 (See
[https://builds.apache.org/job/HBase-0.98/26/])
HBASE-10138. Incorrect or confusing test value is used in block caches (Sergey
Shelukhin) (apurtell: rev 1552505)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.98.0, 0.99.0
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13854025#comment-13854025
]
Hudson commented on HBASE-10138:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #23 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/23/])
HBASE-10138. Incorrect or confusing test value is used in block caches (Sergey
Shelukhin) (apurtell: rev 1552505)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.98.0, 0.99.0
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853597#comment-13853597
]
Hudson commented on HBASE-10138:
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #13 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/13/])
HBASE-10138 incorrect or confusing test value is used in block caches (sershe:
rev 1552454)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.99.0
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853640#comment-13853640
]
Hudson commented on HBASE-10138:
SUCCESS: Integrated in HBase-TRUNK #4740 (See
[https://builds.apache.org/job/HBase-TRUNK/4740/])
HBASE-10138 incorrect or confusing test value is used in block caches (sershe:
rev 1552454)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.99.0
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850806#comment-13850806
]
Nick Dimiduk commented on HBASE-10138:
--
That patch looks alight. Mind running it through a couple rounds of perf to
look for any surprises? You can try out my fledgling HBASE-9806 if you're so
inclined.
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851002#comment-13851002
]
Sergey Shelukhin commented on HBASE-10138:
--
I ran 5 iterations on my laptop in highly unscientific way...
GaussianRandomReadBenchmark may be slightly slower, and
UniformRandomSmallScanBenchmark may be slightly faster, but it could be noise.
Do you suggest more rigorous testing?
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851268#comment-13851268
]
Nick Dimiduk commented on HBASE-10138:
--
I was not expecting any significant change and you didn't find one, so +1 from
me.
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13851273#comment-13851273
]
Sergey Shelukhin commented on HBASE-10138:
--
Will commit tomorrow if no objections
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849384#comment-13849384
]
Sergey Shelukhin commented on HBASE-10138:
--
[~lhofhansl] [~ndimiduk] there's no clear component owner for this, you guys
want to review?
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848162#comment-13848162
]
Hadoop QA commented on HBASE-10138:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12618735/HBASE-10138.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8168//console
This message is automatically generated.
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-10138.patch
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846599#comment-13846599
]
Nick Dimiduk commented on HBASE-10138:
--
Looks like this value is used to calculate the initial size for LruCache's
underlying BlockQueues. Unless the number of non-DataBlocks in the cache is
significant, it should be okay to change this to the Configuration object's
block size. Tests pass?
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10138) incorrect or confusing test value is used in block caches
[
https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846035#comment-13846035
]
Sergey Shelukhin commented on HBASE-10138:
--
I will pick it up tomorrow if there are no comments
incorrect or confusing test value is used in block caches
-
Key: HBASE-10138
URL: https://issues.apache.org/jira/browse/HBASE-10138
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
DEFAULT_BLOCKSIZE_SMALL is described as:
{code}
// Make default block size for StoreFiles 8k while testing. TODO: FIX!
// Need to make it 8k for testing.
public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
{code}
This value is used on production path in CacheConfig thru HStore/HRegion, and
passed to various cache object.
We should change it to actual block size, or if it is somehow by design at
least we should clarify it and remove the comment.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
