[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162267#comment-16162267 ] Hudson commented on HBASE-10240: FAILURE: Integrated in Jenkins build HBase-2.0 #498 (See [https://builds.apache.org/job/HBase-2.0/498/]) HBASE-10240 Remove 0.94->0.96 migration code (stack: rev 8172251a9d9c134c7cf2644c10eeb8b40078eb9d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestReference.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162187#comment-16162187 ] Hudson commented on HBASE-10240: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3699 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3699/]) HBASE-10240 Remove 0.94->0.96 migration code (stack: rev cdc84fe8187e65bddf8d12a5a068e9032ad5a4d4) * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestReference.java > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162093#comment-16162093 ] stack commented on HBASE-10240: --- [~psomogyi] I don't think HBASE-18790 critical for hbase2. Its dirty having Writables left around the place but cleanup would take a bit of wrangling... and in the end it is not that important I'd say. There are more important issues that need fixing for hbase2. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162017#comment-16162017 ] Peter Somogyi commented on HBASE-10240: --- Thanks [~stack] for committing this! If you want I can work on HBASE-18790 based on our previous discussion. Is that issue is needed for beta-1 release? > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[
https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161775#comment-16161775
]
Hadoop QA commented on HBASE-10240:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-10240 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-10240 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875961/HBASE-10240.master.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8570/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove 0.94->0.96 migration code
>
>
> Key: HBASE-10240
> URL: https://issues.apache.org/jira/browse/HBASE-10240
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-10240.master.001.patch,
> HBASE-10240.master.001.patch
>
>
> Remove the objects and code only needed for supporting migration to 0.96 from
> 0.94.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161765#comment-16161765 ] stack commented on HBASE-10240: --- Did a review on Writables in hbase. This issue was originally about purge of migration code. Then (I) warped it to be about purge of Writables. Writeables should be banished from codebase but it is a big job still going by examination. So, filed a separate issue to do that -- HBASE-18790-- and lets return this issue to its original intent, purge of migration code. HBASE-18754 is about getting rid of Writable from TimeRangeTracker. I don't see any usage of 0.94-0.96 migration code in TRT. So, not a concern for this JIRA. For TablePermission/Permission/UserPermission, we read permissions from acl table on initialization of accesscontroller in the loadAll method. We scan the acl and load up a Map of perms. We don't use the TablePermission Writable deserializing here; we just serialize the tablename raw bytes as part of row key. It is hard to follow what is going on -- comments don't agree w/ code -- and it needs some cleanup but safe to say no HbaseObjectWritableFor96Migration involved. HbaseObjectWritableFor96Migration is used in one place only, serializing/deserializing TablePermission in test; actual TablePermission serialization into acl table goes another route and does not use HbaseObjectWritableFor96Migration so safe to purge. MetaWriter doesn't use HbaseObjectWritableFor96Migration. It should be purged but can do in another issue. So I'm +1 on the attached patch. Let me apply. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152909#comment-16152909 ] Peter Somogyi commented on HBASE-10240: --- Thanks [~chia7712] and [~stack] for the guidance! I will take a look how to get rid of the Writables. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151709#comment-16151709 ] Chia-Ping Tsai commented on HBASE-10240: bq. Do you mean writing out with the PB MAGIC four bytes and if not there, then we read it as old fashion Writable? Yep. bq. The MetaWriter is used in one place only, doing CompoundBloomFilterWriter. Could do same trick? If we want to encode it as PB format, we need the same trick. Or we can just replace Writable interface by another for remove all references to Writable. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151652#comment-16151652 ] stack commented on HBASE-10240: --- Above sounds good. What is the wire-compatible function for reading? We seem to be just reading the TableName bytes array, etc., in Permission/TablePermission. Do you mean writing out with the PB MAGIC four bytes and if not there, then we read it as old fashion Writable? The MetaWriter is used in one place only, doing CompoundBloomFilterWriter. Could do same trick? > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151551#comment-16151551 ] Chia-Ping Tsai commented on HBASE-10240: bq. Can we purge any of the remaining Writables? There are only three remaining Writables - TablePermission, TimeRangeTracker, and MetaWriter. For TablePermission andTimeRangeTracker, we can do something like this: # add the wire-compatible function for reading (we had already done this for TablePermission. ditto for TimeRangeTracker.) # rewrite the writable data as PB encoded when reading # replace the Writable with inner delegation. Or make the write/readFields static. (purge public Writable inheritance) For MetaWriter, we just introduce another interface to replace Writable. The readFields is useless. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092912#comment-16092912 ] stack commented on HBASE-10240: --- Can we purge any of the remaining Writables? We were supposed to Writables-free long time ago by 0.96 or 0.98 at the latest. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092907#comment-16092907 ] stack commented on HBASE-10240: --- I'd suggest then that the way forward is to look for classes that implement Writables. We'd write instances of each Writables-implementing class, then apply this patch. Can we still read from the Writables after this patch has gone in? > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077797#comment-16077797 ] Peter Somogyi commented on HBASE-10240: --- Thanks [~enis] and [~stack] for the info! I understand that this is a critical area for upgrade. Let me know if we can go forward with this or some change is needed to the patch. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077280#comment-16077280 ] stack commented on HBASE-10240: --- Thanks [~enis] Would be cool to purge this stuff if we can. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[
https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077244#comment-16077244
]
Enis Soztutar commented on HBASE-10240:
---
I was doing some digging. Findings so far:
9e249881ef6a49879511be24e11d717738085dd5 (HBASE-7224) added this to the javadoc
for HbaseObjectWritableFor96Migration
{code}
* @deprecated This class is needed migrating TablePermissions written with
* Writables. It is needed to read old permissions written pre-0.96. This
* class is to be removed after HBase 0.96 ships since then all permissions
* will have been migrated and written with protobufs.
{code}
However, when reading the code {{TablePermissions}}, which extends
{{Permission}} which is still {{Writable}} and never made PB I guess. There is
also a couple of other Writables like AuthenticationKey.
It seems (from my reading of the code) that we are using PB's in the RPC, but
we are reading and writing these objects from the ACL table or ZK using
Writables. However, I think neither of these depends on
HbaseObjectWritableFor96Migration per se, so the patch maybe good as it is.
> Remove 0.94->0.96 migration code
>
>
> Key: HBASE-10240
> URL: https://issues.apache.org/jira/browse/HBASE-10240
> Project: HBase
> Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-10240.master.001.patch,
> HBASE-10240.master.001.patch
>
>
> Remove the objects and code only needed for supporting migration to 0.96 from
> 0.94.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077175#comment-16077175 ] stack commented on HBASE-10240: --- Ok [~enis] Then I suppose migration tool will need at least an instance of HbaseObjectWritableFor96Migration. You know if this discussed elsewhere [~enis] ? (I can look myself.. but in case you remember...) Ok [~psomogyi]. We can't go further here till we figure out the auto-migration of ACL in branch-1. Thanks for the patch to get us this far. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[
https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077173#comment-16077173
]
Hadoop QA commented on HBASE-10240:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:green} 1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green} 1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green} 1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green} 1{color} | {color:green} mvninstall {color} | {color:green} 3m
20s{color} | {color:green} master passed {color} |
| {color:green} 1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green} 1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:green} 1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} hbase-common in master has 2 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
36s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green} 1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green} 1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} javac {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green} 1{color} | {color:green} hadoopcheck {color} | {color:green}
29m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green} 1{color} | {color:green} findbugs {color} | {color:green} 3m
45s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} unit {color} | {color:green} 2m
11s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green} 1{color} | {color:green} unit {color} | {color:green}113m
15s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green} 1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-10240 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875961/HBASE-10240.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 64886360651a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 75d2eca |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7546/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html
|
| findbugs |
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077165#comment-16077165 ] Enis Soztutar commented on HBASE-10240: --- Thanks Stack. I think the problem is that even if you have a 1.3 cluster, if you have upgraded from 0.94 before, you are left with Writable data since we do not auto-migrate. And there is no migration code to re-write the ACL table as of now. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077136#comment-16077136 ] stack commented on HBASE-10240: --- I added note over on HBASE-13631 in meantime. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077130#comment-16077130 ] stack commented on HBASE-10240: --- Or, thinking on it [~enis], we should just not support going from 0.94 to 2.0. I think this purge is legit in 2.0. Let us know if you think different. For the ACL issue, can I add to our migration guide how to address old serializations (do you know)? I'll add note in meantime > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077106#comment-16077106 ] stack commented on HBASE-10240: --- Thanks [~enis] for the helpful input. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077093#comment-16077093 ] Enis Soztutar commented on HBASE-10240: --- I remember that the ACLs in the ACL table are not auto-migrated to the PB format (last time I checked was long time ago though). If that is the case, if any cluster has those left in the ACL table because the cluster is going through 0.94 -> 0.98 -> 1.x -> 2.0 code bases, than the ACLs will fail. Can we please check that. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[
https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076971#comment-16076971
]
Hadoop QA commented on HBASE-10240:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green} 1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green} 1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green} 1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green} 1{color} | {color:green} mvninstall {color} | {color:green} 3m
28s{color} | {color:green} master passed {color} |
| {color:green} 1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green} 1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green} 1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
34s{color} | {color:red} hbase-common in master has 2 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
54s{color} | {color:red} hbase-server in master has 10 extant Findbugs
warnings. {color} |
| {color:green} 1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green} 1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green} 1{color} | {color:green} hadoopcheck {color} | {color:green}
36m 40s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green} 1{color} | {color:green} findbugs {color} | {color:green} 3m
39s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green} 1{color} | {color:green} unit {color} | {color:green} 2m
13s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}120m 56s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green} 1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}178m 57s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-10240 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875939/HBASE-10240.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 300a76c835db 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 75d2eca |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| findbugs |
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076654#comment-16076654 ] stack commented on HBASE-10240: --- +1 Lets see what hadoopqa says. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076626#comment-16076626 ] Peter Somogyi commented on HBASE-10240: --- Review board: https://reviews.apache.org/r/60685/ > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076613#comment-16076613 ] Peter Somogyi commented on HBASE-10240: --- I think these can be removed: hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestReference.java from hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java the testMigration method from hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java META_TABLE_NAME constant > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075403#comment-16075403 ] stack commented on HBASE-10240: --- Things to remove: ./hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java ... what else? > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Priority: Critical > Fix For: 2.0.0 > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126567#comment-14126567 ] Enis Soztutar commented on HBASE-10240: --- See HBASE-11915. Scheduling this for 2.0. Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Reporter: Andrew Purtell Fix For: 2.0.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857027#comment-13857027 ] Lars Hofhansl commented on HBASE-10240: --- Are we saying one can only upgrade from 0.94 to 0.96 (but not to 0.98+)? Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857069#comment-13857069 ] Andrew Purtell commented on HBASE-10240: Previously we have upgraded users through each major release, but yeah with 0.98 coming quickly after 0.96 I can see a direct migration from 0.94 to 0.98 being convenient. I have no strong opinion either way. How long do we keep migration support for 0.94? Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857076#comment-13857076 ] Lars Hofhansl commented on HBASE-10240: --- With the Apache hat on, I think we want to foster upgrading to new version. With the Salesforce hat on, we plan to upgrade from 0.94 to a 1.x version in 2014. If the upgrade code is (1) not getting in the way or (2) hard to maintain, I'd vote to keep it in at least until one of these becomes true. Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857112#comment-13857112 ] Enis Soztutar commented on HBASE-10240: --- I would prefer to keep the option of 0.94 - 0.98 available, which would ease out the user's burden. 0.96 and 0.98 code bases are not that different, so keeping that in makes managing the patches easier as well I think. Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857123#comment-13857123 ] Himanshu Vashishtha commented on HBASE-10240: - Yeah, I agree with keeping this code in 0.98 as it is getting released so soon after 0.96.0. Otherwise, it will add one extra step for users who wish to upgrade from 0.94 to 0.98. Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Affects Versions: 0.98.0, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.98.0, 0.99.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10240) Remove 0.94-0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857261#comment-13857261 ] Jean-Marc Spaggiari commented on HBASE-10240: - Late, but I agree with others. Always easier to keep the upgrade options to late comer. I agree that since the releases are close to each others, some might want to skip some of them... Remove 0.94-0.96 migration code Key: HBASE-10240 URL: https://issues.apache.org/jira/browse/HBASE-10240 Project: HBase Issue Type: Improvement Reporter: Andrew Purtell Fix For: 0.99.0 Remove the objects and code only needed for supporting migration to 0.96 from 0.94. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
