[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228234#comment-14228234
 ] 

Hadoop QA commented on HBASE-10536:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12684162/HBASE-10536-v3.patch
  against master branch at commit 0f8894cd6435ed6962ec3d7c81be4cb0d4f7657e.
  ATTACHMENT ID: 12684162

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3787 checkstyle errors (more than the master's current 3784 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+  +  does not match with any of the table  + 
tableName +  column families 
+  + To disable column family check, use -D + 
NO_STRICT_COL_FAMILY + =true.\n ;
+-D + NO_STRICT_COL_FAMILY + =true - ignore column family check in 
hbase table. Default is false\n +

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStoppedServerIsNotAlive(TestHttpServerLifecycle.java:93)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11858//console

This message is automatically generated.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Attachments: 10536v2.txt, HBASE-10536-v3.patch, HBASE-10536.patch, 
 HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family 

[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228534#comment-14228534
 ] 

Hadoop QA commented on HBASE-10536:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12684212/HBASE-10536-v4.patch
  against master branch at commit 0f8894cd6435ed6962ec3d7c81be4cb0d4f7657e.
  ATTACHMENT ID: 12684212

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11861//console

This message is automatically generated.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Attachments: 10536v2.txt, HBASE-10536-v3.patch, HBASE-10536-v4.patch, 
 HBASE-10536.patch, HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 

[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228644#comment-14228644
 ] 

Hudson commented on HBASE-10536:


FAILURE: Integrated in HBase-TRUNK #5845 (See 
[https://builds.apache.org/job/HBase-TRUNK/5845/])
HBASE-10536 ImportTsv should fail fast if any of the column family passed to 
the job is not present in the table (denny joesph) (stack: rev 
eb4c194a87fbd1fb89a0fcc277f1e0a807b3596a)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java


 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
 Fix For: 2.0.0, 0.99.2

 Attachments: 10536v2.txt, HBASE-10536-v3.patch, HBASE-10536-v4.patch, 
 HBASE-10536.patch, HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228653#comment-14228653
 ] 

Hudson commented on HBASE-10536:


SUCCESS: Integrated in HBase-1.0 #520 (See 
[https://builds.apache.org/job/HBase-1.0/520/])
HBASE-10536 ImportTsv should fail fast if any of the column family passed to 
the job is not present in the table (denny joesph) (stack: rev 
7eefa36ac26d383de0400321bdb4d39ac5aa5bfd)
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java


 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
 Fix For: 2.0.0, 0.99.2

 Attachments: 10536v2.txt, HBASE-10536-v3.patch, HBASE-10536-v4.patch, 
 HBASE-10536.patch, HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224315#comment-14224315
 ] 

Hadoop QA commented on HBASE-10536:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12683502/10536v2.txt
  against master branch at commit f2be914f73d39d288d40147ff1e582ad5a7989f2.
  ATTACHMENT ID: 12683502

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:red}-1 checkstyle{color}.  The applied patch generated 
3806 checkstyle errors (more than the master's current 3805 errors).

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//artifact/patchprocess/checkstyle-aggregate.html

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11826//console

This message is automatically generated.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Attachments: 10536v2.txt, HBASE-10536.patch, HBASE-10536.patch, 
 HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 

[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-25 Thread Ashish Singhi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224421#comment-14224421
 ] 

Ashish Singhi commented on HBASE-10536:
---

minor nits
{code}
+for (String cf : cfSet) {
+  if(table.getTableDescriptor().getFamily(Bytes.toBytes(cf)) == null) {
{code}
Can we extract table.getTableDescriptor() this to a variable and use it instead 
of calling this method inside the loop ?

{code}
+  boolean noStrict = Boolean.valueOf(conf.get(NO_STRICT_COL_FAMILY));
{code}
Can we use conf.getBoolean(NO_STRICT_COL_FAMILY, false) ?

{code}
+  for (HColumnDescriptor family : 
table.getTableDescriptor().getFamilies())
+familyNames.add(family.getNameAsString());
{code}
Can we enclose the for statement within parenthesis ?

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Attachments: 10536v2.txt, HBASE-10536.patch, HBASE-10536.patch, 
 HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-25 Thread Ashish Singhi (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224440#comment-14224440
 ] 

Ashish Singhi commented on HBASE-10536:
---

Also
{code}
+  String msg =
+  Unmatched family names found: unmatched family names in HFiles 
to be bulkloaded: 
+  + unmatchedFamilies + ; valid family names of table 
+  + Bytes.toString(table.getTableName()) +  are: 
+  + familyNames + .\n
+  + To disable column family check, use -D + 
NO_STRICT_COL_FAMILY + =true.\n ;
{code}
Can we change the error message to something like below or more better ? 
Because still the HFiles are not created here.
{code}
+  String msg =
+  Column Families  + unmatchedFamilies +  specified in  + 
COLUMNS_CONF_KEY
+  +  does not match with any of the table  + tableName +  
column families 
+  + familyNames;
{code}

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Attachments: 10536v2.txt, HBASE-10536.patch, HBASE-10536.patch, 
 HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-11-22 Thread denny joseph (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222335#comment-14222335
 ] 

denny joseph commented on HBASE-10536:
--

I'm always getting this error: The patch does not appear to apply with p0 to p2
when i create the patch and test it locally: dev-support/test-patch.sh 
HBASE-10536.patch 

I got the latest code from master branch and made the changes to code and i 
still get the same error. What am i missing? Please let me know.

Thanks


 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Attachments: HBASE-10536.patch, HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-10-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170430#comment-14170430
 ] 

Hadoop QA commented on HBASE-10536:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12674672/HBASE-10536.patch
  against trunk revision .
  ATTACHMENT ID: 12674672

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11335//console

This message is automatically generated.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-10-07 Thread denny joseph (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162946#comment-14162946
 ] 

denny joseph commented on HBASE-10536:
--

can i mark this as resolved?

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-10-07 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162963#comment-14162963
 ] 

Anoop Sam John commented on HBASE-10536:


No this is not yet committed right? Let me go through the patch and put my vote 
too.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-10-07 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163015#comment-14163015
 ] 

Anoop Sam John commented on HBASE-10536:


bq.a --no-strict flag instead

Can the -D option also named this way? Now it is strict. Go with --no-strict 
and if passed as true avoid the early out. This will default to false.

if(strict == null || !strict.equals(false)) {
Can make use of Boolean.valueOf? 

{code}
+for (HColumnDescriptor family : families) {
+  familyNames.add(family.getNameAsString());
+}
+ArrayListString unmatchedFamilies = new ArrayListString();
+SetString cfSet = getColumnFamilies(columns);
+for (String cf : cfSet) {
+  if (!familyNames.contains(cf)) {
{code}
Just use HTD#getFamily(final byte [] column) to check whether the family name 
is available?  Code will look simpler.

Pls avoid white spaces from patch.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-09-25 Thread denny joseph (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148597#comment-14148597
 ] 

denny joseph commented on HBASE-10536:
--

Thanks Anoop. I assume no more patches need to fix the javadoc warnings.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-09-24 Thread Anoop Sam John (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145990#comment-14145990
 ] 

Anoop Sam John commented on HBASE-10536:


bq.-1 javadoc. The javadoc tool appears to have generated 8 warning messages.
Should not be an issue with your patch IMO.  I have fixed these 8 warns 
yesterday.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: denny joseph
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-09-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144427#comment-14144427
 ] 

Hadoop QA commented on HBASE-10536:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12670607/HBASE-10536.patch
  against trunk revision .
  ATTACHMENT ID: 12670607

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 8 
warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11026//console

This message is automatically generated.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-09-23 Thread denny joseph (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145876#comment-14145876
 ] 

denny joseph commented on HBASE-10536:
--

how can i know the javadoc warnings i'm getting for the patch? Also can someone 
assign me this jura ?

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-09-23 Thread rajeshbabu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145946#comment-14145946
 ] 

rajeshbabu commented on HBASE-10536:


[~dennyjoseph]
Thanks for the patch. Overall patch lgtm.

To find the new javadoc warnings just run following command.
{code}
mvn javadoc:javadoc
{code}

Once this patch is committed you will be added as contributor and assign it to 
you.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch, HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-09-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140041#comment-14140041
 ] 

Hadoop QA commented on HBASE-10536:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12669908/HBASE-10536.patch
  against trunk revision .
  ATTACHMENT ID: 12669908

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 
warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10986//console

This message is automatically generated.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
 Fix For: 2.0.0

 Attachments: HBASE-10536.patch


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-02-14 Thread Jean-Marc Spaggiari (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901384#comment-13901384
 ] 

Jean-Marc Spaggiari commented on HBASE-10536:
-

I think we should offer the 2 options. Maybe someone will want to load all what 
can be loaded, and deal with the errors afterward. 

So maybe we can add a --strict option to fail if column doesn't exist or the 
opposite?

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: rajeshbabu
 Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-02-14 Thread rajeshbabu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901539#comment-13901539
 ] 

rajeshbabu commented on HBASE-10536:


bq. Maybe someone will want to load all what can be loaded, and deal with the 
errors afterward.
Yes, there may chance like if column not found, they can add column later.
bq. So maybe we can add a --strict option to fail if column doesn't exist or 
the opposite?
Its better to add --strict. I will make patch accordingly.

Thanks JM.



 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: rajeshbabu
 Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-02-14 Thread Nick Dimiduk (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901709#comment-13901709
 ] 

Nick Dimiduk commented on HBASE-10536:
--

bq. Maybe someone will want to load all what can be loaded, and deal with the 
errors afterward.

Isn't bulkloading generally considered an atomic operation? I think allowing 
a partial load is not ideal default behavior. If you want to allow partial 
load, I'd prefer a --no-strict flag instead.

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: rajeshbabu
 Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HBASE-10536) ImportTsv should fail fast if any of the column family passed to the job is not present in the table

2014-02-14 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901766#comment-13901766
 ] 

Ted Yu commented on HBASE-10536:


bq. a --no-strict flag instead

+1

 ImportTsv should fail fast if any of the column family passed to the job is 
 not present in the table
 

 Key: HBASE-10536
 URL: https://issues.apache.org/jira/browse/HBASE-10536
 Project: HBase
  Issue Type: Bug
  Components: mapreduce
Affects Versions: 0.98.0
Reporter: rajeshbabu
Assignee: rajeshbabu
 Fix For: 0.96.2, 0.98.1, 0.99.0, 0.94.17


 While checking 0.98 rc, running bulkload tools. By mistake passed wrong 
 column family to importtsv. LoadIncrementalHfiles failed with following 
 exception
 {code}
 Exception in thread main java.io.IOException: Unmatched family names found: 
 unmatched family names in HFiles to be bulkloaded: [f1]; valid family names 
 of table test are: [f]
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:241)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:823)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
 at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
 at 
 org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.main(LoadIncrementalHFiles.java:828)
 {code}
  
 Its better to fail fast if any of the passed column family is not present in 
 table.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)