[jira] [Commented] (HBASE-10578) For the same row key, the KV in the newest StoreFile should be returned
[ https://issues.apache.org/jira/browse/HBASE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907555#comment-13907555 ] Liyin Tang commented on HBASE-10578: Nice finding ! For the same row key, the KV in the newest StoreFile should be returned --- Key: HBASE-10578 URL: https://issues.apache.org/jira/browse/HBASE-10578 Project: HBase Issue Type: Bug Components: Scanners Affects Versions: 0.89-fb, 0.98.1 Reporter: Amitanand Aiyer Assignee: Amitanand Aiyer Priority: Minor Fix For: 0.89-fb Attachments: HBASE-10578.patch When multiple scanners have the same KV, HBase should pick the newest one. i.e. pick the KV from the store file with the largest seq id. In the KeyValueHeap generalizedSeek implementation, we seem to prefer the current scanner over the scanners in the heap -- THIS IS WRONG. The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10578) For the same row key, the KV in the newest StoreFile should be returned
[ https://issues.apache.org/jira/browse/HBASE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907567#comment-13907567 ] Hadoop QA commented on HBASE-10578: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630159/HBASE-10578.patch against trunk revision . ATTACHMENT ID: 12630159 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8759//console This message is automatically generated. For the same row key, the KV in the newest StoreFile should be returned --- Key: HBASE-10578 URL: https://issues.apache.org/jira/browse/HBASE-10578 Project: HBase Issue Type: Bug Components: Scanners Affects Versions: 0.89-fb, 0.98.1 Reporter: Amitanand Aiyer Assignee: Amitanand Aiyer Priority: Minor Fix For: 0.89-fb Attachments: HBASE-10578.patch When multiple scanners have the same KV, HBase should pick the newest one. i.e. pick the KV from the store file with the largest seq id. In the KeyValueHeap generalizedSeek implementation, we seem to prefer the current scanner over the scanners in the heap -- THIS IS WRONG. The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10578) For the same row key, the KV in the newest StoreFile should be returned
[ https://issues.apache.org/jira/browse/HBASE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907725#comment-13907725 ] stack commented on HBASE-10578: --- [~amitanand] Yeah, our little hadoopqa bot just runs whatever is posted against trunk... just ignore. For the same row key, the KV in the newest StoreFile should be returned --- Key: HBASE-10578 URL: https://issues.apache.org/jira/browse/HBASE-10578 Project: HBase Issue Type: Bug Components: Scanners Affects Versions: 0.89-fb, 0.98.1 Reporter: Amitanand Aiyer Assignee: Amitanand Aiyer Priority: Minor Fix For: 0.89-fb Attachments: HBASE-10578-v2.patch, HBASE-10578.patch When multiple scanners have the same KV, HBase should pick the newest one. i.e. pick the KV from the store file with the largest seq id. In the KeyValueHeap generalizedSeek implementation, we seem to prefer the current scanner over the scanners in the heap -- THIS IS WRONG. The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10578) For the same row key, the KV in the newest StoreFile should be returned
[ https://issues.apache.org/jira/browse/HBASE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907732#comment-13907732 ] stack commented on HBASE-10578: --- We have this issue in trunk too. The patch looks like it'll apply too... For the same row key, the KV in the newest StoreFile should be returned --- Key: HBASE-10578 URL: https://issues.apache.org/jira/browse/HBASE-10578 Project: HBase Issue Type: Bug Components: Scanners Affects Versions: 0.89-fb, 0.98.1 Reporter: Amitanand Aiyer Assignee: Amitanand Aiyer Priority: Minor Fix For: 0.89-fb Attachments: HBASE-10578-v2.patch, HBASE-10578.patch When multiple scanners have the same KV, HBase should pick the newest one. i.e. pick the KV from the store file with the largest seq id. In the KeyValueHeap generalizedSeek implementation, we seem to prefer the current scanner over the scanners in the heap -- THIS IS WRONG. The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10578) For the same row key, the KV in the newest StoreFile should be returned
[ https://issues.apache.org/jira/browse/HBASE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907743#comment-13907743 ] Hadoop QA commented on HBASE-10578: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630192/HBASE-10578-v2.patch against trunk revision . ATTACHMENT ID: 12630192 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8761//console This message is automatically generated. For the same row key, the KV in the newest StoreFile should be returned --- Key: HBASE-10578 URL: https://issues.apache.org/jira/browse/HBASE-10578 Project: HBase Issue Type: Bug Components: Scanners Affects Versions: 0.89-fb, 0.98.1 Reporter: Amitanand Aiyer Assignee: Amitanand Aiyer Priority: Minor Fix For: 0.89-fb Attachments: HBASE-10578-v2.patch, HBASE-10578.patch When multiple scanners have the same KV, HBase should pick the newest one. i.e. pick the KV from the store file with the largest seq id. In the KeyValueHeap generalizedSeek implementation, we seem to prefer the current scanner over the scanners in the heap -- THIS IS WRONG. The diff adds a unit test to make sure that bulk loads correctly. And fixes the issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)