[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13992483#comment-13992483 ] Weichen Ye commented on HBASE-10884: I meet the same problem... [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978089#comment-13978089 ] Hudson commented on HBASE-10884: SUCCESS: Integrated in HBase-0.98 #289 (See [https://builds.apache.org/job/HBase-0.98/289/]) HBASE-10884 [REST] Do not disable block caching when scanning (apurtell: rev 1589309) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978214#comment-13978214 ] Hudson commented on HBASE-10884: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #274 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/274/]) HBASE-10884 [REST] Do not disable block caching when scanning (apurtell: rev 1589309) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977868#comment-13977868 ] Hudson commented on HBASE-10884: ABORTED: Integrated in HBase-TRUNK #5108 (See [https://builds.apache.org/job/HBase-TRUNK/5108/]) HBASE-10884 [REST] Do not disable block caching when scanning (apurtell: rev 1589308) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966698#comment-13966698 ] Andrew Purtell commented on HBASE-10884: Curious if I should skip 0.96 for the same rationale. [~stack] [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0, 0.96.1.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966956#comment-13966956 ] stack commented on HBASE-10884: --- [~andrew.purt...@gmail.com] Would like to minimize 0.96 changes to critical fixes so folks are more inclined to go to 0.98. [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0, 0.96.1.1 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966960#comment-13966960 ] Andrew Purtell commented on HBASE-10884: Ack, so 0.98 and trunk only, thanks Stack. [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.99.0 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965513#comment-13965513 ] Andrew Purtell commented on HBASE-10884: Test failure is not related, will commit soon. Ping [~stack] and [~lhofhansl], I'm going to assume no objection to trivial patch and perf improvement, but limited to REST use cases. [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.96.1.1, 0.94.18 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965674#comment-13965674 ] Lars Hofhansl commented on HBASE-10884: --- Maybe in 0.94 we should invert the default (leave it at false and allow enabling this)...? I'm fine either way. In 0.94 we should limit the element of the surprise. But which of the following two is more suprising? # scanning via REST and the Java API use different defaults # in 0.94.18 scanning via REST did not cache, but in 0.94.19 it does by default. I guess I'm fine either way. Any opinions? [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.96.1.1, 0.94.18 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966090#comment-13966090 ] Andrew Purtell commented on HBASE-10884: bq. Maybe in 0.94 we should invert the default (leave it at false and allow enabling this)... Sure [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.96.1.1, 0.94.18 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964865#comment-13964865 ] Nick Dimiduk commented on HBASE-10884: -- +1 Any plan to expose this scanner setting to the user via API? [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.96.1.1, 0.94.18 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[ https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964868#comment-13964868 ] Andrew Purtell commented on HBASE-10884: bq. Any plan to expose this scanner setting to the user via API? Sure, HBASE-10952 [REST] Do not disable block caching when scanning - Key: HBASE-10884 URL: https://issues.apache.org/jira/browse/HBASE-10884 Project: HBase Issue Type: Improvement Affects Versions: 0.98.1, 0.96.1.1, 0.94.18 Reporter: Andrew Purtell Assignee: Andrew Purtell Attachments: HBASE-10884.patch The REST gateway pessimistically disables block caching when issuing Scans to the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It does not do this when issuing Gets on behalf of HTTP clients in RowResultGenerator. This is an old idea now, the reasons for doing so lost sometime back in the era when HBase walked the earth with dinosaurs ( 0.20). We probably should not be penalizing REST scans in this way. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10884) [REST] Do not disable block caching when scanning
[
https://issues.apache.org/jira/browse/HBASE-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964955#comment-13964955
]
Hadoop QA commented on HBASE-10884:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639497/HBASE-10884.patch
against trunk revision .
ATTACHMENT ID: 12639497
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9238//console
This message is automatically generated.
[REST] Do not disable block caching when scanning
-
Key: HBASE-10884
URL: https://issues.apache.org/jira/browse/HBASE-10884
Project: HBase
Issue Type: Improvement
Affects Versions: 0.98.1, 0.96.1.1, 0.94.18
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Attachments: HBASE-10884.patch
The REST gateway pessimistically disables block caching when issuing Scans to
the cluster, using Scan#setCacheBlocks(false) in ScannerResultGenerator. It
does not do this when issuing Gets on behalf of HTTP clients in
RowResultGenerator. This is an old idea now, the reasons for doing so lost
sometime back in the era when HBase walked the earth with dinosaurs ( 0.20).
We probably should not be penalizing REST scans in this way.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
