[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983725#comment-13983725
]
Hudson commented on HBASE-10948:
SUCCESS: Integrated in HBase-0.98 #299 (See
[https://builds.apache.org/job/HBase-0.98/299/])
HBASE-11061 Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
(stack: rev 1590771)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983807#comment-13983807
]
Hudson commented on HBASE-10948:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #284 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/284/])
HBASE-11061 Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
(stack: rev 1590771)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983900#comment-13983900
]
Hudson commented on HBASE-10948:
FAILURE: Integrated in hbase-0.96 #396 (See
[https://builds.apache.org/job/hbase-0.96/396/])
HBASE-11061 Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
(stack: rev 1590770)
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983913#comment-13983913
]
Hudson commented on HBASE-10948:
FAILURE: Integrated in hbase-0.96-hadoop2 #275 (See
[https://builds.apache.org/job/hbase-0.96-hadoop2/275/])
HBASE-11061 Port HBASE-10948 Fix hbase table file 'x' mode to 0.96 / 0.98
(stack: rev 1590770)
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978944#comment-13978944
]
Ted Yu commented on HBASE-10948:
Jerry:
This issue was resolved.
Can you attach your patches to HBASE-11061 ?
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978945#comment-13978945
]
Jerry He commented on HBASE-10948:
--
Hi, [~apurtell]
Attached HBASE-10948-0.98.patch and HBASE-10948-0.96.patch.
Create getFileDefault() in FSUtils, which is the same as
FsPermission.getFileDefault() in Hadoop 2
See if they look good to you.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979018#comment-13979018
]
Jerry He commented on HBASE-10948:
--
ok Ted. Thanks!
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-0.96.patch, HBASE-10948-0.98.patch,
HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975791#comment-13975791
]
Andrew Purtell commented on HBASE-10948:
[~jerryhe] Provide a patch that compiles with Hadoop 1 if you want it in 0.98
or earlier.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975890#comment-13975890
]
Jerry He commented on HBASE-10948:
--
Hi, Andrew
Thanks for the info and reminder.
The method FsPermission.getFileDefault() was introduced to Hadoop 2.0 with
HADOOP-9155. Therefore it won't work on hadoop1.
Sorry for the confusion again.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976239#comment-13976239
]
Andrew Purtell commented on HBASE-10948:
No confusion. Fix it a different way for versions 0.98 and less if you think
its important. A shame this is only going into trunk because it uses a Hadoop 2
specific API.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976269#comment-13976269
]
Jerry He commented on HBASE-10948:
--
Good point.
Should be an easy fix for 0.98 or less without using the Hadoop 2 API.
Will provide a patch.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975097#comment-13975097
]
Hudson commented on HBASE-10948:
FAILURE: Integrated in HBase-TRUNK #5102 (See
[https://builds.apache.org/job/HBase-TRUNK/5102/])
HBASE-10948 Fix hbase table file 'x' mode (Jerry He) (tedyu: rev 1588718)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975158#comment-13975158
]
Hudson commented on HBASE-10948:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #269 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/269/])
HBASE-10948 Fix hbase table file 'x' mode (Jerry He) (tedyu: rev 1588770)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0, 0.98.2
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975210#comment-13975210
]
Hudson commented on HBASE-10948:
SUCCESS: Integrated in HBase-0.98 #285 (See
[https://builds.apache.org/job/HBase-0.98/285/])
HBASE-10948 Fix hbase table file 'x' mode (Jerry He) (tedyu: rev 1588770)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975255#comment-13975255
]
Hudson commented on HBASE-10948:
SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #270 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/270/])
HBASE-10948 Revert due to incompatibility with hadoop-1 (tedyu: rev 1588786)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975297#comment-13975297
]
Hudson commented on HBASE-10948:
SUCCESS: Integrated in HBase-0.98 #286 (See
[https://builds.apache.org/job/HBase-0.98/286/])
HBASE-10948 Revert due to incompatibility with hadoop-1 (tedyu: rev 1588786)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975323#comment-13975323
]
Jerry He commented on HBASE-10948:
--
Hi, Ted
Thanks for taking care of the commit and the issue on 0.98 with hadoop-1.
Sorry about the confusion.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974966#comment-13974966
]
Andrew Purtell commented on HBASE-10948:
Patch lgtm
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975063#comment-13975063
]
Ted Yu commented on HBASE-10948:
Integrated to trunk.
Thanks for the review, Andrew.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970500#comment-13970500
]
Jerry He commented on HBASE-10948:
--
Hi, [~xieliang007]
You are right. In a secure HBase instance, we should have more restrictive
file permission for HBase files.
Currently 'hbase.data.umask.enable' and 'hbase.data.umask' are used on the
HBase side to control the file permissions. If they are not enabled, we will
fall to filesystem level, where 'fs.permissions.umask-mode' will kick in.
I also agree we have two options as you mentioned:
1. Change for a more restrictive default permissions when security is enabled.
Currently if the user does not do explicitly use 'hbase.data.umask' or
'fs.permissions.umask-mode', we will have everyone '+r' on everything.
2. Document more clearly on file permission setting recommendations. On this
page. https://hbase.apache.org/book/security.html
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970504#comment-13970504
]
Jerry He commented on HBASE-10948:
--
This JIRA does not fix the security issue mentioned above on file permissions.
It just fixes a usage bug to get filesystem permission.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969863#comment-13969863
]
Jerry He commented on HBASE-10948:
--
Anyone has time to look at this JIRA?
The code change is small. The impact looks big. But it is contained.
Here are all the calls to FSUtils.getFilePermissions() after a search:
{code}
getFilePermissions(FileSystem, Configuration, String) : FsPermission -
org.apache.hadoop.hbase.util.FSUtils
createOutputStream(Configuration, FileSystem, Path, InetSocketAddress[]) :
FSDataOutputStream -
org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter
testDeleteAndExists() :
void - org.apache.hadoop.hbase.util.TestFSUtils
testPermMask() :
void - org.apache.hadoop.hbase.util.TestFSUtils (3 matches)
writeRegionInfoFileContent(Configuration, FileSystem, Path, byte[]) :
void - org.apache.hadoop.hbase.regionserver.HRegionFileSystem
writeSnapshotInfo(SnapshotDescription, Path, FileSystem) :
void - org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils
{code}
This change does not affect the WALs files because it does not have this
problem.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970025#comment-13970025
]
Ted Yu commented on HBASE-10948:
I ran TestFSUtils and TestCloseRegionHandler with patch - they passed.
lgtm
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970413#comment-13970413
]
Liang Xie commented on HBASE-10948:
---
Totally agreed with that there is a security issue here. IIRC, in our internal
clusters, [~liushaohui] set fs.permissions.umask-mode explicItly to avoid
this flaw long long ago:)
That's means, seems we have two options at least: 1) code fix, like Jerry's
2)w/o code modification, just adding more safer perm setting in the default
config file. thought?
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964479#comment-13964479
]
Jerry He commented on HBASE-10948:
--
Here is the java doc comment
{code}
/**
* Get the default permission for directory and symlink.
* In previous versions, this default permission was also used to
* create files, so files created end up with ugo+x permission.
* See HADOOP-9155 for detail.
* Two new methods are added to solve this, please use
* {@link FsPermission#getDirDefault()} for directory, and use
* {@link FsPermission#getFileDefault()} for file.
* This method is kept for compatibility.
*/
public static FsPermission getDefault() {
return new FsPermission((short)00777);
}
{code}
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964494#comment-13964494
]
Jerry He commented on HBASE-10948:
--
After the fix, the files do not have the 'x' mode anymore.
{code}
$ hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:09
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-09 11:09
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:09
/hbase/data/default/TestTable/12ac06eb34b088b3cd1c762500f677a9
-rw-r--r-- 1 hbase biadmin 68 2014-04-09 11:09
/hbase/data/default/TestTable/12ac06eb34b088b3cd1c762500f677a9/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:09
/hbase/data/default/TestTable/12ac06eb34b088b3cd1c762500f677a9/info
-rw-r--r-- 1 hbase biadmin 108595586 2014-04-09 11:09
/hbase/data/default/TestTable/12ac06eb34b088b3cd1c762500f677a9/info/3615d7160dba465a9dae4e025c6a2593
-rw-r--r-- 1 hbase biadmin 273040200 2014-04-09 11:09
/hbase/data/default/TestTable/12ac06eb34b088b3cd1c762500f677a9/info/dd6b13b32ec040b0b985e7548a07357c
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:09
/hbase/data/default/TestTable/7eda557191bc665632010f44d09f75d4
-rw-r--r-- 1 hbase biadmin 42 2014-04-09 11:09
/hbase/data/default/TestTable/7eda557191bc665632010f44d09f75d4/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:09
/hbase/data/default/TestTable/7eda557191bc665632010f44d09f75d4/info
-rw-r--r-- 1 hbase biadmin4933423 2014-04-09 11:09
/hbase/data/default/TestTable/7eda557191bc665632010f44d09f75d4/info/09df97c3e75e4761973d101fb0703713
-rw-r--r-- 1 hbase biadmin 114778788 2014-04-09 11:09
/hbase/data/default/TestTable/7eda557191bc665632010f44d09f75d4/info/d72db0aedaa5452bb4d2f1491450d7f2
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:09
/hbase/data/default/TestTable/c5b62f236d45605e82ce05f2421c2924
-rw-r--r-- 1 hbase biadmin 68 2014-04-09 11:09
/hbase/data/default/TestTable/c5b62f236d45605e82ce05f2421c2924/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-09 11:10
/hbase/data/default/TestTable/c5b62f236d45605e82ce05f2421c2924/info
-rw-r--r-- 1 hbase biadmin 109747278 2014-04-09 11:10
/hbase/data/default/TestTable/c5b62f236d45605e82ce05f2421c2924/info/4eb9550a148e4b2a859de2f3486216d0
-rw-r--r-- 1 hbase biadmin 279823957 2014-04-09 11:09
/hbase/data/default/TestTable/c5b62f236d45605e82ce05f2421c2924/info/d7838b7ddd7c4061ae5680295dfc2d96
{code}
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964601#comment-13964601
]
Hadoop QA commented on HBASE-10948:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639440/HBASE-10948-trunk.patch
against trunk revision .
ATTACHMENT ID: 12639440
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestFSUtils
org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9232//console
This message is automatically generated.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964736#comment-13964736
]
Jerry He commented on HBASE-10948:
--
Attached v2.
Fixed the test case org.apache.hadoop.hbase.util.TestFSUtils.testPermMask(),
and added a test case in there.
The failure in
org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler does not
seem to be related.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964859#comment-13964859
]
Hadoop QA commented on HBASE-10948:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12639473/HBASE-10948-trunk-v2.patch
against trunk revision .
ATTACHMENT ID: 12639473
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9235//console
This message is automatically generated.
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
[jira] [Commented] (HBASE-10948) Fix hbase table file 'x' mode
[
https://issues.apache.org/jira/browse/HBASE-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964913#comment-13964913
]
Jerry He commented on HBASE-10948:
--
Again the TestCloseRegionHandler is not related to this fix
The test passed in my local env:.
Running org.apache.hadoop.hbase.regionserver.handler.TestCloseRegionHandler
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.494 sec
Fix hbase table file 'x' mode
-
Key: HBASE-10948
URL: https://issues.apache.org/jira/browse/HBASE-10948
Project: HBase
Issue Type: Bug
Components: Filesystem Integration
Affects Versions: 0.96.2, 0.98.1
Reporter: Jerry He
Assignee: Jerry He
Fix For: 0.99.0
Attachments: HBASE-10948-trunk-v2.patch, HBASE-10948-trunk.patch
The hbase table files currently all have 'x' mode in there:
{code}
$hadoop fs -ls -R /hbase/data/default/TestTable/
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc
-rw-r--r-- 1 hbase biadmin313 2014-04-08 20:53
/hbase/data/default/TestTable/.tabledesc/.tableinfo.01
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info
-rwxr-xr-x 1 hbase biadmin 272958577 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/7138e61cbcd24538b64726db13dab48e
-rwxr-xr-x 1 hbase biadmin 108603714 2014-04-08 20:53
/hbase/data/default/TestTable/724c8c3075da516b450ce4826327ce64/info/9ce233fcdfde49679797d13f28e26129
drwxr-xr-x - hbase biadmin 0 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564
-rwxr-xr-x 1 hbase biadmin 68 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/.regioninfo
drwxr-xr-x - hbase biadmin 0 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info
-rwxr-xr-x 1 hbase biadmin 33800049 2014-04-08 21:54
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/576190de431341b9a02280654e3deb58
-rwxr-xr-x 1 hbase biadmin 108650474 2014-04-08 20:53
/hbase/data/default/TestTable/b5350c581363f786e49ff6f32e71f564/info/7c54098fb62a4ef29aab0f5658b25260
{code}
If the user does not specify 'hbase.data.umask', we use the fs default:
FsPermission.getDefault()
Instead we should use FsPermission.getFileDefault().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
