[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498353#comment-14498353 ] Jerry He commented on HBASE-11542: -- This has been fixed by [~apurtell] in HBASE-12006. I did a quick 'mvn test' on master branch with IBM JDK 7. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.99.0 Environment: IBM JDK 6, IBM JDK 7 Reporter: LinseyPang Priority: Critical Fix For: 2.0.0, 1.1.0, 1.0.2 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE-11542-6.patch, HBASE-11542-7.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1, client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390060#comment-14390060 ] Enis Soztutar commented on HBASE-11542: --- This seems useful. [~apurtell] mind reviewing the latest version? Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.99.0 Environment: IBM JDK 6, IBM JDK 7 Reporter: LinseyPang Priority: Critical Fix For: 2.0.0, 1.0.1, 1.1.0 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE-11542-6.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1, client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390244#comment-14390244 ] pascal oliva commented on HBASE-11542: -- test SUCCESS with the both JVM OpenJDK anf IBM JAVA Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.99.0 Environment: IBM JDK 6, IBM JDK 7 Reporter: LinseyPang Priority: Critical Fix For: 2.0.0, 1.1.0, 1.0.2 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE-11542-6.patch, HBASE-11542-7.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1, client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390365#comment-14390365
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708640/HBASE-11542-7.patch
against master branch at commit 6415742c3757ca72080ca63372d1a0f82ac7607e.
ATTACHMENT ID: 12708640
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver.testCoprocessorHooksInRegionsMerge(TestRegionServerObserver.java:100)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13517//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13517//artifact/patchprocess/patchReleaseAuditWarnings.txt
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13517//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13517//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13517//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13517//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Bug
Components: build, test
Affects Versions: 0.99.0
Environment: IBM JDK 6, IBM JDK 7
Reporter: LinseyPang
Priority: Critical
Fix For: 2.0.0, 1.1.0, 1.0.2
Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch,
HBASE-11542-6.patch, HBASE-11542-7.patch, HBASE_11542-1.patch,
KeyStoreTestUtil.java.new1, client_crt, client_pkcs8,
hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch,
hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14301331#comment-14301331 ] pascal oliva commented on HBASE-11542: -- As the fix by using bouncycastle library as been approved into HADOOP-10847 i suggest to use the same fix. (already proposed here with HBASE-11542-4.patch) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Bug Components: build, test Affects Versions: 0.99.0 Environment: IBM JDK 6, IBM JDK 7 Reporter: LinseyPang Priority: Critical Fix For: 2.0.0, 1.0.1, 1.1.0 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE-11542-6.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1, client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172412#comment-14172412
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675006/HBASE-11542-6.patch
against trunk revision .
ATTACHMENT ID: 12675006
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 13 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11354//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch,
HBASE-11542-6.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1,
client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch,
hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8,
sslkeystore.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172468#comment-14172468 ] pascal oliva commented on HBASE-11542: -- I tested again in my side successfully the patch : HBASE-11542-6.patch from jira:hbase site. with : git apply --binary -p0 ../HBASE-11542-6.patch == No error , no warning mvn clean ; mvn compile mvn test -Dtest=org.apache.hadoop.hbase.http.TestSSLHttpServer -X | tee res.hbase.SSLHttp.log [INFO] HBase . SUCCESS [ 1.830 s] [INFO] HBase - Annotations ... SUCCESS [ 0.906 s] [INFO] HBase - Common SUCCESS [ 5.822 s] [INFO] HBase - Protocol .. SUCCESS [ 0.095 s] [INFO] HBase - Client SUCCESS [ 2.205 s] [INFO] HBase - Hadoop Compatibility .. SUCCESS [ 0.216 s] [INFO] HBase - Hadoop Two Compatibility .. SUCCESS [ 1.040 s] [INFO] HBase - Prefix Tree ... SUCCESS [ 0.876 s] [INFO] HBase - Server SUCCESS [ 14.280 s] [INFO] HBase - Testing Util .. SUCCESS [ 1.181 s] [INFO] HBase - Thrift SUCCESS [ 1.132 s] [INFO] HBase - Shell . SUCCESS [ 0.702 s] [INFO] HBase - Integration Tests . SUCCESS [ 1.137 s] [INFO] HBase - Examples .. SUCCESS [ 0.733 s] [INFO] HBase - Rest .. SUCCESS [ 1.237 s] [INFO] HBase - Assembly .. SUCCESS [ 1.057 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 35.248 s [INFO] Finished at: 2014-10-15T17:14:04+01:00 [INFO] Final Memory: 91M/300M [INFO] Running org.apache.hadoop.hbase.http.TestSSLHttpServer Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.14 sec - in org.apache.hadoop.hbase.http.TestSSLHttpServer What do you suggest to push the patch ? A pull request ? Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE-11542-6.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1, client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169134#comment-14169134
]
pascal oliva commented on HBASE-11542:
--
I found a way to use external files to run the test (files created manually by
using :
openssl genrsa ; and openssl pkcs8) :
I have 4 key files to put into a test directory.
see tag == below
KeyStoreTestUtil.java
public static void setupSSLConfig(
...
X509Certificate cCert =
KeyStoreTestUtil.generateCertificate(/tmp/client_crt); ==
/tmp/client_crt temp location for first draft
KeyStoreTestUtil.createKeyStore(clientKS, clientPassword, client,
KeyStoreTestUtil.getPrivateFromFile(/tmp/client_pkcs8), cCert);
== /tmp/client_pkcs8 temp location for first draft
certs.put(client, cCert);
}
X509Certificate sCert =
KeyStoreTestUtil.generateCertificate(/tmp/server_crt); == temp
location for first draft
KeyStoreTestUtil.createKeyStore(serverKS, serverPassword, server,
KeyStoreTestUtil.getPrivateFromFile(/tmp/server_pkcs8) ,
sCert); == temp location for first draft
certs.put(server, sCert);
...
i updated the function : generateCertificate to generate a 509 certificate
with a test file
public static X509Certificate generateCertificate(String pathCrtFile)
throws IOException, GeneralSecurityException, FileNotFoundException
{
File certFile = new File(pathCrtFile);
FileInputStream input=null;
try {
input=new FileInputStream(certFile);
CertificateFactory cf=CertificateFactory.getInstance(X.509);
return (X509Certificate)cf.generateCertificate(input); }
finally {
input.close(); }
}
And added a new function
private static Key getPrivateFromFile(String filename)
throws NoSuchAlgorithmException, IOException,
InvalidKeySpecException, FileNotFoundException {
File privKeyFile = new File(filename);
RSAPrivateKey privKey = null;
BufferedInputStream bis = null;
try {
bis = new BufferedInputStream(new FileInputStream(privKeyFile));
byte[] privKeyBytes = new byte[(int)privKeyFile.length()];
bis.read(privKeyBytes);
KeyFactory keyFactory = KeyFactory.getInstance(RSA);
KeySpec ks = new PKCS8EncodedKeySpec(privKeyBytes);
privKey = (RSAPrivateKey) keyFactory.generatePrivate(ks);
return (Key)privKey;
}
finally {
bis.close(); }
(i) What do you suggest for the location of these files (client_crt,
client_pkcs8, server_crt, server_pkcs8) ?
Or
(ii) Do you prefer to add a script to generate these files in a specific
directory (this suppose
that openssl is available in the system) ?
Here in attachment : client_crt, client_pkcs8, server_crt, server_pkcs8 : the
key files used for the test.
and KeyStore TestUtil.java.new1 with the changes about the use of external key
files.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch,
HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch,
hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169374#comment-14169374 ] stack commented on HBASE-11542: --- For location, if you want the files on CLASSPATH, put them in hbase-*/src/test/resources. If you just want to reference them, we have src/test/data. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE_11542-1.patch, KeyStoreTestUtil.java.new1, client_crt, client_pkcs8, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, server_crt, server_pkcs8, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164935#comment-14164935 ] pascal oliva commented on HBASE-11542: -- Yes! you're right, We can also work on this way by using just a 'test key file to run the test. Thanks for your comments. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162199#comment-14162199 ] Andrew Purtell commented on HBASE-11542: Instead of using internal security APIs which are 1) nonstandard and 2) at least in the case of Oracle Java going to disappear, can we instead use keytool once to generate a test file, stringify it, and use this in the test ? Thanks Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162269#comment-14162269
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673345/HBASE-11542-5.patch
against trunk revision .
ATTACHMENT ID: 12673345
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Constructor? certValidityConstr =
certValidityClass.getConstructor(new Class[] {Date.class, Date.class});
+ Class? certificateSerialNumberClass =
Class.forName(getCertificateSerialNumberModuleName());
+ Constructor? certificateSerialNumberConstr =
certificateSerialNumberClass.getConstructor(new Class[] {BigInteger.class});
+ methodSET.invoke(certInfoObject,
getSetField(certInfoObject,SERIAL_NUMBER), certificateSerialNumberObject);
+ Constructor? certificateSubjectNameConstr =
certificateSubjectNameClass.getConstructor(new Class[] {x500NameClass});
+ Object certificateSubjectNameObject =
certificateSubjectNameConstr.newInstance(x500NameObject);
+ methodSET.invoke(certInfoObject, getSetField(certInfoObject,SUBJECT),
certificateSubjectNameObject);
+ Constructor? certificateIssuerNameConstr =
certificateIssuerNameClass.getConstructor(new Class[] {x500NameClass});
+ methodSET.invoke(certInfoObject, getSetField(certInfoObject,ISSUER),
certificateIssuerNameObject);
+ //info.set(X509CertInfo.KEY, new CertificateX509Key(pair.getPublic()));
getCertificateX509KeyModuleName
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11240//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-11542-4.patch, HBASE-11542-5.patch,
HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch,
hbase11542-0.99-v3.patch, hbase_11542-v2.patch,
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082536#comment-14082536 ] stack commented on HBASE-11542: --- Patch lgtm. [~andrew.purt...@gmail.com] You ok w/ the bouncycastle dependency coming in? Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082568#comment-14082568 ] Andrew Purtell commented on HBASE-11542: bq. You ok w/ the bouncycastle dependency coming in No. Where else do we use this besides for a minor test? Why can't we stringify a cert and use it in the test? Or nuke the test. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080589#comment-14080589 ] pascal oliva commented on HBASE-11542: -- sslkeystore.patch is related to ibm soe/hadoop-core repository. It can not be apply directly into hbase repository. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080701#comment-14080701 ] pascal oliva commented on HBASE-11542: -- Tested successfully with OpenJDK and IBM JAVA Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080717#comment-14080717 ] LinseyPang commented on HBASE-11542: pascal, you are saying your new patch is tested successfully, am I correct ? thanks Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080763#comment-14080763 ] pascal oliva commented on HBASE-11542: -- Yes with mvn -fn -Dtest=org.apache.hadoop.hbase.http.TestSSLHttpServer test the tested that patch with ubuntu-OpenJDK and RHEL-IBM J9 VM (build 2.7, JRE 1.7.0 the command patch : git diff --no-prefix master ../hbase-patches/HBASE-11542-4.patch from : git clone g...@github.com:apache/hbase.git build command : mvn compile = SUCCESS test command : mvn -fn -Dtest=org.apache.hadoop.hbase.http.TestSSLHttpServer test = SUCCESS Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080765#comment-14080765 ] pascal oliva commented on HBASE-11542: -- The patch tested successfully : HBASE-11542-4.patch here in attachments. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch, sslkeystore.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080776#comment-14080776
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658890/HBASE-11542-4.patch
against trunk revision .
ATTACHMENT ID: 12658890
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.TestIOFencing
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10242//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE-11542-4.patch, HBASE_11542-1.patch,
hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch,
hbase_11542-v2.patch, sslkeystore.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078963#comment-14078963
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658588/hbase11542-0.99-v3.patch
against trunk revision .
ATTACHMENT ID: 12658588
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 21 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.migration.TestNamespaceUpgrade
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10223//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch,
hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079166#comment-14079166 ] LinseyPang commented on HBASE-11542: Hi,stack, Thanks a lot. 1. I will find a time to work on Linux environment. 2. for failed tests of TestRegionReplicas,TestRestartCluster,etc.. , currently I don't think the failure is caused by my new added classes. I will re-test it .3. For Instead of programmatically creating a keystore containing a self-signed certificate and keypair, perhaps we can generate one once by hand, stringify it, and just use that, will think about it. thanks. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079276#comment-14079276 ] pascal oliva commented on HBASE-11542: -- I am working on KeyStoreTestUtil.java file from hadoop-common compoment about the break with IBM JAVA I changed the generateCertification function into KeyStoreTestUtil by using bouncycastle library dependency groupIdorg.bouncycastle/groupId artifactIdbcprov-jdk16/artifactId version1.46/version /dependency Here in attachment the patch that i used into hadoop-common : sslkeystore.patch I tested successfully that patch with OpenJDJ 1.7 and IBM JAVA J9 VM (build 2.7, JRE 1.7.0 with hadoop environment. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079342#comment-14079342
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658645/sslkeystore.patch
against trunk revision .
ATTACHMENT ID: 12658645
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10225//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch,
hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch,
sslkeystore.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077577#comment-14077577 ] LinseyPang commented on HBASE-11542: Andrew, thanks . Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077610#comment-14077610
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658389/hbase11542-0.99-v3.patch
against trunk revision .
ATTACHMENT ID: 12658389
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 21 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStoppedServerIsNotAlive(TestHttpServerLifecycle.java:115)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10214//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch,
hbase_11542-v2.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077619#comment-14077619 ] LinseyPang commented on HBASE-11542: Can give some advices for this time's failure ? thanks a lot. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077957#comment-14077957 ] Ted Yu commented on HBASE-11542: I searched in console log of the QA run for TestHttpServerLifecycle - this test did seem to hang. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078762#comment-14078762 ] LinseyPang commented on HBASE-11542: Hi,Ted, 1. I created a local branch from origin/master and loaded into eclipse. On this local branch, I added several classes under package oforg.apache.hadoop.hbase.http.ssl for solving jdk incompatible issue and one test class named as TestX509Factory.java under package org.apache.hadoop.hbase.http. The unit test TestX509Factory.java succeeded on my local machine. 2. To test whether the failure is because of the new classed I created, I created a new local branch from origin/master without adding any new code. The org.apache.hadoop.hbase.http.TestHttpServerLifecycle is also failed. Error is : java.io.IOException: Could not locate executable null\bin\winutils.exe in the Hadoop binaries. It seems the failure is because I am using windows os, need to re-compile hadoop binary. 3. So I don't think the failure is from the new added classes from my side. Am I correct ? Please give advice. Thanks a lot. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078768#comment-14078768 ] Ted Yu commented on HBASE-11542: bq. the failure is because I am using windows os Hadoop QA only tests on Linux - for hbase that is, I don't know about other projects. Please find proper environment and do the above verification. Thanks Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078800#comment-14078800 ] stack commented on HBASE-11542: --- [~Linsey] I see that test failing elsewhere so likely not related to your patch. It passes for me locally. Let me reupload it and see what happens the second time HadoopQA runs it. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078802#comment-14078802 ] stack commented on HBASE-11542: --- [~Linsey] Factory seems fine. You looked at the JVM class and it too hard to coral JVM vendor stuff inside there? What did you think of the [~andrew.purt...@gmail.com] notion above of Instead of programmatically creating a keystore containing a self-signed certificate and keypair, perhaps we can generate one once by hand, stringify it, and just use that? Thanks. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch, hbase11542-0.99-v3.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078863#comment-14078863
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12658573/hbase11542-0.99-v3.patch
against trunk revision .
ATTACHMENT ID: 12658573
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 21 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.migration.TestNamespaceUpgrade
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10219//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch, hbase11542-0.99-v3.patch,
hbase11542-0.99-v3.patch, hbase_11542-v2.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068620#comment-14068620 ] Andrew Purtell commented on HBASE-11542: bq. add author tags for new classes Apache policy disallows author tags. You'll need to remove these before we can commit anything. As Ted says, please provide a patch for the 'master' branch. bq. In my eclipse project, POM gives exception in the part below:Plugin execution not covered by lifecycle configuration I use Eclipse and do not have this problem. At any rate, please avoid unrelated changes. Any POM issue you might have is not related to JRE security API use. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067909#comment-14067909
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656790/HBASE_11542-1.patch
against trunk revision .
ATTACHMENT ID: 12656790
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 21 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10127//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068096#comment-14068096
]
Hadoop QA commented on HBASE-11542:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656805/hbase_11542-v2.patch
against trunk revision .
ATTACHMENT ID: 12656805
{color:red}-1 @author{color}. The patch appears to contain 9 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:green}+1 tests included{color}. The patch appears to include 41 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10129//console
This message is automatically generated.
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068098#comment-14068098 ] Ted Yu commented on HBASE-11542: What changes were made to hbase-server/pom.xml ? The whole file seems to be changed. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[
https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068101#comment-14068101
]
LinseyPang commented on HBASE-11542:
Hi, Ted, sorry. In my eclipse project, POM gives exception in the part
below:Plugin execution not covered by lifecycle configuration:
org.apache.maven.plugins:maven-dependency-plugin:2.1:build-classpath
(execution: create-mrapp-generated-classpath, phase: generate-test-resources)
Then I added pluginManagement /pluginManagement in this part.
build
pluginManagement
plugins
plugin
artifactIdmaven-dependency-plugin/artifactId
executions
execution
idcreate-mrapp-generated-classpath/id
phasegenerate-test-resources/phase
goals
goalbuild-classpath/goal
/goals
configuration
!-- needed to run the unit test for DS to generate
the required classpath that is required in the env
of the launch container in the mini mr/yarn cluster
--
outputFile${project.build.directory}/test-classes/mrapp-generated-classpath/outputFile
/configuration
/execution
/executions
/plugin
/plugins
/pluginManagement
/build
Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
Key: HBASE-11542
URL: https://issues.apache.org/jira/browse/HBASE-11542
Project: HBase
Issue Type: Improvement
Components: build, test
Affects Versions: 0.99.0
Environment: RHEL 6.3 ,IBM JDK 6
Reporter: LinseyPang
Priority: Minor
Fix For: 2.0.0
Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch
In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which
leverages the following sun classes:
import sun.security.x509.AlgorithmId;
import sun.security.x509.CertificateAlgorithmId;
this cause hbase compiler failure if using IBM JDK,
There are similar classes like below in IBM jdk:
import com.ibm.security.x509.AlgorithmId;
import com.ibm.security.x509.CertificateAlgorithmId;
This jira is to add handling of the x509 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068108#comment-14068108 ] Ted Yu commented on HBASE-11542: See HBASE-11087 for discussion w.r.t. adding pluginManagement. It would be cleaner if you separate this change from patch for this issue. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068121#comment-14068121 ] LinseyPang commented on HBASE-11542: Hi, Ted, Thanks. I see. May I know what caused this error: -1 patch. The patch command could not apply the patch. I created branch under origin/branch-1, is this correct? Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068150#comment-14068150 ] Ted Yu commented on HBASE-11542: QA bot only applies patch on trunk. Please regenerate your patch based on trunk. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 Attachments: HBASE_11542-1.patch, hbase_11542-v2.patch In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066514#comment-14066514 ] stack commented on HBASE-11542: --- [~LinseyPang] Sorry about that Linsey. Any chance of a patch? We have a class http://hbase.apache.org/xref/org/apache/hadoop/hbase/util/JVM.html where we do differences between SUN and IBM, etc., JVMs. Any chance of a patch reconcilling these different security imports? Thanks. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066527#comment-14066527 ] Demai Ni commented on HBASE-11542: -- [~stack], thanks for following this issue. Linsey and I worked within the same group, and just began to get into the hbase community. She is looking into jvm.java as a reference, and already have a fix in our local repo, and will provide a patch a bit later Demai Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11542) Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK
[ https://issues.apache.org/jira/browse/HBASE-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067067#comment-14067067 ] Andrew Purtell commented on HBASE-11542: Instead of programmatically creating a keystore containing a self-signed certificate and keypair, perhaps we can generate one once by hand, stringify it, and just use that. That should eliminate the use of anything in the sun.security.x509 package. Unit Test KeyStoreTestUtil.java compilation failure in IBM JDK Key: HBASE-11542 URL: https://issues.apache.org/jira/browse/HBASE-11542 Project: HBase Issue Type: Improvement Components: build, test Affects Versions: 0.99.0 Environment: RHEL 6.3 ,IBM JDK 6 Reporter: LinseyPang Priority: Minor Fix For: 2.0.0 In trunk, jira HBase-10336 added a utility test KeyStoreTestUtil.java, which leverages the following sun classes: import sun.security.x509.AlgorithmId; import sun.security.x509.CertificateAlgorithmId; this cause hbase compiler failure if using IBM JDK, There are similar classes like below in IBM jdk: import com.ibm.security.x509.AlgorithmId; import com.ibm.security.x509.CertificateAlgorithmId; This jira is to add handling of the x509 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
