[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084481#comment-14084481 ] Nicolas Liochon commented on HBASE-11585: - Committed to master. Can't be applied cleanly to branch-1, and iirc Enis is not there, so I skip this branch for now. PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084590#comment-14084590 ] Hudson commented on HBASE-11585: FAILURE: Integrated in HBase-TRUNK #5365 (See [https://builds.apache.org/job/HBase-TRUNK/5365/]) HBASE-11585 PE: Allows warm-up (nkeywal: rev 4d005b70a0fda4be5a8ead84ff5f54fceb3c637a) * hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076734#comment-14076734 ] stack commented on HBASE-11585: --- +1 PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 0.99.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074310#comment-14074310 ] Nicolas Liochon commented on HBASE-11585: - bq. shoudn't we update the start time or at least have another start time based on when the warmup has completed? In my tests, it was not an issue because not warming up impacts a lot the 99+ latency percentiles, but the mean time (and as such the global time) it not really impacted. PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074810#comment-14074810 ] Jonathan Hsieh commented on HBASE-11585: got it. +1 PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[
https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073469#comment-14073469
]
Hadoop QA commented on HBASE-11585:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12657636/11585.v1.patch
against trunk revision .
ATTACHMENT ID: 12657636
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10178//console
This message is automatically generated.
PE: Allows warm-up
--
Key: HBASE-11585
URL: https://issues.apache.org/jira/browse/HBASE-11585
Project: HBase
Issue Type: Improvement
Components: test
Affects Versions: 1.0.0, 2.0.0
Reporter: Nicolas Liochon
Assignee: Nicolas Liochon
Priority: Trivial
Fix For: 1.0.0, 2.0.0
Attachments: 11585.v1.patch
When we measure the latency, warm-up helps to get repeatable and useful
measures.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073524#comment-14073524 ] Devaraj Das commented on HBASE-11585: - +1 PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073525#comment-14073525 ] Nick Dimiduk commented on HBASE-11585: -- How much warmup do you find helps? 1k? 100k? Is this warming up the client or the region servers (or can you tell?) PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073526#comment-14073526 ] Nick Dimiduk commented on HBASE-11585: -- +1 PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073565#comment-14073565 ] Nicolas Liochon commented on HBASE-11585: - bq. How much warmup do you find helps? 1k? 100k? Is this warming up the client or the region servers (or can you tell?) for a 1m rows run, I exclude the first 200K. But you can do differently :-) It's more interesting for the client, as you can warmup the server by running the client multiple times PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11585) PE: Allows warm-up
[ https://issues.apache.org/jira/browse/HBASE-11585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073691#comment-14073691 ] Jonathan Hsieh commented on HBASE-11585: shoudn't we update the start time or at least have another start time based on when the warmup has completed? PE: Allows warm-up -- Key: HBASE-11585 URL: https://issues.apache.org/jira/browse/HBASE-11585 Project: HBase Issue Type: Improvement Components: test Affects Versions: 1.0.0, 2.0.0 Reporter: Nicolas Liochon Assignee: Nicolas Liochon Priority: Trivial Fix For: 1.0.0, 2.0.0 Attachments: 11585.v1.patch When we measure the latency, warm-up helps to get repeatable and useful measures. -- This message was sent by Atlassian JIRA (v6.2#6252)
