[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119444#comment-14119444 ] Hudson commented on HBASE-11863: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #465 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/465/]) HBASE-11863 WAL files are not archived and stays in the WAL directory after splitting (enis: rev 7f28fcf429242c549219502bfb7da0ad28753f4c) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch, hbase-11863_v3-0.98.patch, hbase-11863_v3-0.99.patch, hbase-11863_v3.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119135#comment-14119135 ] Andrew Purtell commented on HBASE-11863: Thanks! WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch, hbase-11863_v3-0.98.patch, hbase-11863_v3-0.99.patch, hbase-11863_v3.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119136#comment-14119136 ] Hudson commented on HBASE-11863: FAILURE: Integrated in HBase-0.98 #490 (See [https://builds.apache.org/job/HBase-0.98/490/]) HBASE-11863 WAL files are not archived and stays in the WAL directory after splitting (enis: rev 7f28fcf429242c549219502bfb7da0ad28753f4c) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch, hbase-11863_v3-0.98.patch, hbase-11863_v3-0.99.patch, hbase-11863_v3.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119199#comment-14119199 ] Hudson commented on HBASE-11863: FAILURE: Integrated in HBase-TRUNK #5461 (See [https://builds.apache.org/job/HBase-TRUNK/5461/]) HBASE-11863 WAL files are not archived and stays in the WAL directory after splitting (enis: rev bb1d95385ab6176493d4a3a4555e2b24933c4e3d) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch, hbase-11863_v3-0.98.patch, hbase-11863_v3-0.99.patch, hbase-11863_v3.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119289#comment-14119289 ] Hudson commented on HBASE-11863: SUCCESS: Integrated in HBase-1.0 #148 (See [https://builds.apache.org/job/HBase-1.0/148/]) HBASE-11863 WAL files are not archived and stays in the WAL directory after splitting (enis: rev 4b2f43fafb3528b05b92651435457cebde4c684d) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch, hbase-11863_v3-0.98.patch, hbase-11863_v3-0.99.patch, hbase-11863_v3.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115973#comment-14115973 ] Enis Soztutar commented on HBASE-11863: --- It seems that this has already been fixed by HBASE-11654 for 0.98. I am now checking to see whether master and branch-1 has this issue. In any case, I have 2 more unit tests that we can commit as a part of this issue. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 0.99.0, 2.0.0, 0.98.6 In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116043#comment-14116043 ] Andrew Purtell commented on HBASE-11863: Thanks Enis WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116046#comment-14116046 ] Jeffrey Zhong commented on HBASE-11863: --- Both patches look good to me!(+1). Thanks. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116052#comment-14116052 ] Andrew Purtell commented on HBASE-11863: +1 here too. Applied the 0.98 patch and the modified tests passed. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116080#comment-14116080 ] Andrew Purtell commented on HBASE-11863: The master patch here is stale after HBASE-11072 WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116081#comment-14116081 ] Lars Hofhansl commented on HBASE-11863: --- You mean 0.98.4 in description, right? (not 0.94.4) WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116156#comment-14116156 ] Enis Soztutar commented on HBASE-11863: --- yes, it should be 0.98.4. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116173#comment-14116173 ] Andrew Purtell commented on HBASE-11863: I'd like to roll 0.98.6 RC1 on Monday. I'll push the 0.98 patch to that branch then if this issue isn't otherwise resolved, unless objection. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116179#comment-14116179 ] Andrew Purtell commented on HBASE-11863: Are we good with the 0.98 patch though Enis? Applies cleanly and passes, I'd say yes. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116194#comment-14116194 ] Hadoop QA commented on HBASE-11863: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665481/hbase-11863_v1.patch against trunk revision . ATTACHMENT ID: 12665481 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor org.apache.hadoop.hbase.client.TestReplicaWithCluster org.apache.hadoop.hbase.replication.TestPerTableCFReplication {color:red}-1 core zombie tests{color}. There are 7 zombie test(s): at org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testCloneAndRestoreSnapshot(TestRestoreSnapshotFromClient.java:258) at org.apache.hadoop.hbase.mapreduce.TestRowCounter.testRowCounterHiddenColumn(TestRowCounter.java:137) at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels.testMROnTable(TestImportTSVWithVisibilityLabels.java:162) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10654//console This message is automatically generated. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was
[jira] [Commented] (HBASE-11863) WAL files are not archived and stays in the WAL directory after splitting
[ https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116219#comment-14116219 ] Enis Soztutar commented on HBASE-11863: --- bq. Are we good with the 0.98 patch though Enis? Applies cleanly and passes, I'd say yes. Yep. Feel free to commit the 0.98 patch for the RC. WAL files are not archived and stays in the WAL directory after splitting -- Key: HBASE-11863 URL: https://issues.apache.org/jira/browse/HBASE-11863 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Priority: Blocker Fix For: 0.99.0, 2.0.0, 0.98.6 Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, hbase-11863_v2.patch In patch HBASE-11094, it seems that we changed the constructor we are using for SplitLogManager, which does not archive the log files after splitting is done to the archive folder. The log files stays in the splitting directory forever and re-split every time the master restarts. It is surprising that our unit tests are passing (since 0.94.4) without any issues. Part of the reason is that the split is actually carried, but the WAL is not moved and thus the -splitting directory never gets deleted. It seems critical to fix in 0.98.6, [~andrew.purt...@gmail.com] FYI. -- This message was sent by Atlassian JIRA (v6.2#6252)