[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167151#comment-14167151 ] Andrew Purtell commented on HBASE-12126: Will commit shortly unless objection. Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.8, 0.99.1 Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch, HBASE-12126-0.98_2.patch, HBASE-12126-branch-1.patch, HBASE-12126.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167273#comment-14167273 ] Gary Helmling commented on HBASE-12126: --- +1 Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.8, 0.99.1 Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch, HBASE-12126-0.98_2.patch, HBASE-12126-branch-1.patch, HBASE-12126.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167673#comment-14167673 ] Hudson commented on HBASE-12126: SUCCESS: Integrated in HBase-TRUNK #5649 (See [https://builds.apache.org/job/HBase-TRUNK/5649/]) HBASE-12126 Region server coprocessor endpoint (Virag Kothari) (apurtell: rev 8ee55fb339264549a6359471c40a6198aa2266da) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/SingletonCoprocessorService.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * hbase-server/src/test/protobuf/DummyRegionServerEndpoint.proto * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.8, 0.99.1 Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch, HBASE-12126-0.98_2.patch, HBASE-12126-branch-1.patch, HBASE-12126.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167754#comment-14167754 ] Hudson commented on HBASE-12126: SUCCESS: Integrated in HBase-0.98 #592 (See [https://builds.apache.org/job/HBase-0.98/592/]) HBASE-12126 Region server coprocessor endpoint (Virag Kothari) (apurtell: rev 884b049ce127122a2d64de3f82340aa05f9c7158) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/SingletonCoprocessorService.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * hbase-server/src/test/protobuf/DummyRegionServerEndpoint.proto * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.8, 0.99.1 Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch, HBASE-12126-0.98_2.patch, HBASE-12126-branch-1.patch, HBASE-12126.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167784#comment-14167784 ] Hudson commented on HBASE-12126: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #563 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/563/]) HBASE-12126 Region server coprocessor endpoint (Virag Kothari) (apurtell: rev 884b049ce127122a2d64de3f82340aa05f9c7158) * hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/SingletonCoprocessorService.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * hbase-server/src/test/protobuf/DummyRegionServerEndpoint.proto * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.8, 0.99.1 Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch, HBASE-12126-0.98_2.patch, HBASE-12126-branch-1.patch, HBASE-12126.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167798#comment-14167798 ] Hudson commented on HBASE-12126: SUCCESS: Integrated in HBase-1.0 #298 (See [https://builds.apache.org/job/HBase-1.0/298/]) HBASE-12126 Region server coprocessor endpoint (Virag Kothari) (apurtell: rev 6a37c169fc08f4cbfaedf87de38d96444d56f49e) * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/MockRegionServerServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/SingletonCoprocessorService.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/DummyRegionServerEndpointProtos.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerCoprocessorRpcChannel.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java * hbase-server/src/test/protobuf/DummyRegionServerEndpoint.proto * hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Fix For: 2.0.0, 0.98.8, 0.99.1 Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch, HBASE-12126-0.98_2.patch, HBASE-12126-branch-1.patch, HBASE-12126.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160915#comment-14160915 ] Virag Kothari commented on HBASE-12126: --- Thanks [~ghelmling] for the review. Created HBASE-12182 to bring master endpoints into consistency Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[
https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161143#comment-14161143
]
Hadoop QA commented on HBASE-12126:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673193/HBASE-12126.patch
against trunk revision .
ATTACHMENT ID: 12673193
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * be obtained by calling {@link
org.apache.hadoop.hbase.client.HBaseAdmin#coprocessorService(ServerName)},
+ * coderpc ExecRegionServerService(.CoprocessorServiceRequest) returns
(.CoprocessorServiceResponse);/code
+ * coderpc ExecRegionServerService(.CoprocessorServiceRequest) returns
(.CoprocessorServiceResponse);/code
+ LOG.debug(Registered regionserver coprocessor service: service= +
serviceDesc.getFullName());
+
this.regionServerServices.registerService(((SingletonCoprocessorService)
impl).getService());
+ static class DummyRegionServerEndpoint extends DummyService implements
Coprocessor, SingletonCoprocessorService {
+ return
org.apache.hadoop.hbase.coprocessor.protobuf.generated.DummyRegionServerEndpointProtos.internal_static_DummyRequest_descriptor;
+ return
org.apache.hadoop.hbase.coprocessor.protobuf.generated.DummyRegionServerEndpointProtos.internal_static_DummyRequest_fieldAccessorTable
+
org.apache.hadoop.hbase.coprocessor.protobuf.generated.DummyRegionServerEndpointProtos.DummyRequest.class,
org.apache.hadoop.hbase.coprocessor.protobuf.generated.DummyRegionServerEndpointProtos.DummyRequest.Builder.class);
+ if (!(obj instanceof
org.apache.hadoop.hbase.coprocessor.protobuf.generated.DummyRegionServerEndpointProtos.DummyRequest))
{
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//artifact/trunk/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11227//console
This message is automatically generated.
Region server coprocessor endpoint
--
Key: HBASE-12126
URL: https://issues.apache.org/jira/browse/HBASE-12126
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 0.98.6
Reporter: Virag Kothari
Assignee: Virag Kothari
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[
https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158825#comment-14158825
]
Gary Helmling commented on HBASE-12126:
---
This looks great, Virag.
I agree that adding {{SingletonCoprocessorService}} makes sense. My only
concern is that it leaves services intended to run on master
(CoprocessorService) inconsistent with similar services on regionservers
(SingletonCoprocessorService).
Can you open a new JIRA to bring master endpoints into consistency?
Unfortunately, this would be a compatibility breaking change for master
endpoints, so we'll need to work out the deprecation strategy. All of that can
be handled in the new JIRA.
+1 on the _1.patch.
Region server coprocessor endpoint
--
Key: HBASE-12126
URL: https://issues.apache.org/jira/browse/HBASE-12126
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 0.98.6
Reporter: Virag Kothari
Assignee: Virag Kothari
Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch
Utility to make endpoint calls against region server
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158843#comment-14158843 ] Andrew Purtell commented on HBASE-12126: We can commit once there's a trunk patch Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Attachments: HBASE-12126-0.98.patch, HBASE-12126-0.98_1.patch Utility to make endpoint calls against region server -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154429#comment-14154429 ] Virag Kothari commented on HBASE-12126: --- bq. Maybe there's a better name but it's not totally off because there will only be one service instance of this type per regionserver. Makes sense to me. Will add SingletonCoprocessorService. bq. Specifically for HBASE-12125... Do you need this, though? I'd be OK if you added a new RPC to region server, since this is internal functionality anyway. Initially we thought of building a replication wal checker tool (Hbase-12125) separate from hbck. So we thought of having a coprocessor. But now we added that as an option to hbck as its easier to run in our internal setups. So even though not necessary, I think we can still go ahead with the pluggable coprocessor based solution for HBASE-12125 as it will be easier to separate out from hbck if needed. I will remove the jira dependency and update the description as its confusing. Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Attachments: HBASE-12126-0.98.patch Primary use case in HBASE-12125 but being able to make endpoint calls against region server can be useful in general. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153898#comment-14153898 ] Virag Kothari commented on HBASE-12126: --- Also, I think we need separate endpoint observers for calls on region server Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Attachments: HBASE-12126-0.98.patch Primary use case in HBASE-12125 but being able to make endpoint calls against region server can be useful in general. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153925#comment-14153925 ] Lars Hofhansl commented on HBASE-12126: --- So you are inventing a new concept here. A coprocessor for a specific region server rather than a specific region. Cool. I think it merrits a new coprocessor interface. Specifically for HBASE-12125... Do you need this, though? I'd be OK if you added a new RPC to region server, since this is internal functionality anyway. [~apurtell], FYI. Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Attachments: HBASE-12126-0.98.patch Primary use case in HBASE-12125 but being able to make endpoint calls against region server can be useful in general. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[
https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153923#comment-14153923
]
Andrew Purtell commented on HBASE-12126:
bq. With the above code in patch, coprocessors like AccessController serving as
region endpoint and as an observer for Regionserver will now also be registered
as endpoint for region server
I think we need a new interface to avoid that. Region endpoints aren't going to
function correctly if invoked from a different context.
How about:
{code}
if (SingletonCoprocessorService.class.isAssignableFrom(c)) {
this.regionServerServices.registerService(((CoprocessorService)
impl).getService());
break;
}
{code}
?
Maybe there's a better name but it's not totally off because there will only be
one service instance of this type per regionserver.
Region server coprocessor endpoint
--
Key: HBASE-12126
URL: https://issues.apache.org/jira/browse/HBASE-12126
Project: HBase
Issue Type: Bug
Components: Coprocessors
Affects Versions: 0.98.6
Reporter: Virag Kothari
Attachments: HBASE-12126-0.98.patch
Primary use case in HBASE-12125 but being able to make endpoint calls against
region server can be useful in general.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12126) Region server coprocessor endpoint
[ https://issues.apache.org/jira/browse/HBASE-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153940#comment-14153940 ] Andrew Purtell commented on HBASE-12126: I agree, for HBASE-12125 HBCK is core functionality, we shouldn't need a coprocessor to support it. But the change proposed on this issue would also be a very-nice-to-have. Region server coprocessor endpoint -- Key: HBASE-12126 URL: https://issues.apache.org/jira/browse/HBASE-12126 Project: HBase Issue Type: Bug Components: Coprocessors Affects Versions: 0.98.6 Reporter: Virag Kothari Assignee: Virag Kothari Attachments: HBASE-12126-0.98.patch Primary use case in HBASE-12125 but being able to make endpoint calls against region server can be useful in general. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
