[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[ https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171388#comment-14171388 ] stack commented on HBASE-12247: --- This one is a bit odd: * @returns A reference to this instance. If I read it right, this method is a void retrun so this javadoc is not right Otherwise patch is good. Waiting on hadoopqa. If you agree on above, I can fix on commit. Replace setHTable() with initializeTable() in TableInputFormat. --- Key: HBASE-12247 URL: https://issues.apache.org/jira/browse/HBASE-12247 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12247.patch TableInputFormat uses a new HTable(). Switch that use to a manually created ConnectionFactory.createConnection() and call initializeTable(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[
https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171515#comment-14171515
]
Hadoop QA commented on HBASE-12247:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674823/HBASE-12247.patch
against trunk revision .
ATTACHMENT ID: 12674823
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11341//console
This message is automatically generated.
Replace setHTable() with initializeTable() in TableInputFormat.
---
Key: HBASE-12247
URL: https://issues.apache.org/jira/browse/HBASE-12247
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12247.patch, HBASE-12247_v2.patch
TableInputFormat uses a new HTable(). Switch that use to a manually created
ConnectionFactory.createConnection() and call initializeTable().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[
https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171550#comment-14171550
]
Hadoop QA commented on HBASE-12247:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12674824/HBASE-12247_v2.patch
against trunk revision .
ATTACHMENT ID: 12674824
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11342//console
This message is automatically generated.
Replace setHTable() with initializeTable() in TableInputFormat.
---
Key: HBASE-12247
URL: https://issues.apache.org/jira/browse/HBASE-12247
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0, 0.99.2
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Fix For: 2.0.0, 0.99.2
Attachments: HBASE-12247.patch, HBASE-12247_v2.patch
TableInputFormat uses a new HTable(). Switch that use to a manually created
ConnectionFactory.createConnection() and call initializeTable().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[ https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171554#comment-14171554 ] Enis Soztutar commented on HBASE-12247: --- IF has an interesting lifecycle in hadoop MR. The IF is configured statically, and the configuration is saved in the configuration object. Then MR initializes the class once, and passes the conf back in through setConf(). This instance is used for calling getSplits(). After that, there is no close method or anything that is called. Then for each map task, the IF is initialized again and passed the job configuration. Then createRecordReader() is called with one of the InputSplits that is passed. The returned record reader is closed properly. I think we can do this: IF.setConf() will create a Connection. IF.getSplits() will close that connection at the end in a finally close. Also the RecordReder.close() will close the connection in RR.close() method. It is similar to how DBInputFormat works as well https://github.com/apache/hadoop-common/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/db/DBInputFormat.java Replace setHTable() with initializeTable() in TableInputFormat. --- Key: HBASE-12247 URL: https://issues.apache.org/jira/browse/HBASE-12247 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12247.patch, HBASE-12247_v2.patch TableInputFormat uses a new HTable(). Switch that use to a manually created ConnectionFactory.createConnection() and call initializeTable(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[ https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171623#comment-14171623 ] stack commented on HBASE-12247: --- Thanks [~enis] IF should just manage connections itself -- in splits and in RR? Just take a tablename rather than a settable? Replace setHTable() with initializeTable() in TableInputFormat. --- Key: HBASE-12247 URL: https://issues.apache.org/jira/browse/HBASE-12247 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12247.patch, HBASE-12247_v2.patch TableInputFormat uses a new HTable(). Switch that use to a manually created ConnectionFactory.createConnection() and call initializeTable(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[ https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171707#comment-14171707 ] Hudson commented on HBASE-12247: FAILURE: Integrated in HBase-TRUNK #5664 (See [https://builds.apache.org/job/HBase-TRUNK/5664/]) HBASE-12247 Replace setHTable() with initializeTable() in TableInputFormat. (Solomon Duskis) (stack: rev 3544f4e98b4aa6e0082c67883a37aa6bffc02003) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java Replace setHTable() with initializeTable() in TableInputFormat. --- Key: HBASE-12247 URL: https://issues.apache.org/jira/browse/HBASE-12247 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12247.patch, HBASE-12247_v2.patch TableInputFormat uses a new HTable(). Switch that use to a manually created ConnectionFactory.createConnection() and call initializeTable(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12247) Replace setHTable() with initializeTable() in TableInputFormat.
[ https://issues.apache.org/jira/browse/HBASE-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171865#comment-14171865 ] Hudson commented on HBASE-12247: FAILURE: Integrated in HBase-1.0 #317 (See [https://builds.apache.org/job/HBase-1.0/317/]) HBASE-12247 Replace setHTable() with initializeTable() in TableInputFormat. (Solomon Duskis) (stack: rev dc998bf787d434b08e8e6cba6385603d2c427285) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java Replace setHTable() with initializeTable() in TableInputFormat. --- Key: HBASE-12247 URL: https://issues.apache.org/jira/browse/HBASE-12247 Project: HBase Issue Type: Bug Affects Versions: 2.0.0, 0.99.2 Reporter: Solomon Duskis Assignee: Solomon Duskis Fix For: 2.0.0, 0.99.2 Attachments: HBASE-12247.patch, HBASE-12247_v2.patch TableInputFormat uses a new HTable(). Switch that use to a manually created ConnectionFactory.createConnection() and call initializeTable(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
