[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177494#comment-14177494
]
Lars Hofhansl commented on HBASE-12261:
---
Looks this broke assembly:single and install
{{mvn -DskipTests install assembly:single}} is what I used to use to build a
tarball, now it fails with this:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:2.2-beta-5:single (default-cli)
on project hbase-checkstyle: Error reading assemblies: No assembly descriptors
found. - [Help 1]
{code}
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds. That would free
committers up from checking patches for stylistic issues and leave them free
to check the real meat of the patches.
Additionally we should have the check for empty try catch blocks running so
that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177497#comment-14177497 ] Lars Hofhansl commented on HBASE-12261: --- [~eclark], FYI. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177701#comment-14177701 ] Elliott Clark commented on HBASE-12261: --- HBASE-12294 Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177705#comment-14177705 ] Lars Hofhansl commented on HBASE-12261: --- Awesome! Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177719#comment-14177719 ] Lars Hofhansl commented on HBASE-12261: --- Although it seems many jars are missing from the generated tarball... Not sure it's related, though. [~apurtell], FYI. I'll have a look too. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177730#comment-14177730 ] Lars Hofhansl commented on HBASE-12261: --- Going back to edit 776a0b09a2bde71210033a77ff56af5d73534f7e (right before this) all is good. If the way we are supposed to build a tarball has changed we should list that in the release notes. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177749#comment-14177749 ] Elliott Clark commented on HBASE-12261: --- Blah, I freaking hate maven. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177867#comment-14177867 ] Lars Hofhansl commented on HBASE-12261: --- I'm with you man :) Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177891#comment-14177891
]
Lars Hofhansl commented on HBASE-12261:
---
{{mvn test -Dtest=test}} is also broken (even after HBASE-12294):
{code}
HBase - Checkstyle FAILURE [0.477s]
...
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on
project hbase-checkstyle: No tests were executed! (Set -DfailIfNoTests=false
to ignore this error.) - [Help 1]
{code}
Meh... Maven is so obtuse.
Maybe it's best to roll this back for now?
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds. That would free
committers up from checking patches for stylistic issues and leave them free
to check the real meat of the patches.
Additionally we should have the check for empty try catch blocks running so
that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177894#comment-14177894
]
Lars Hofhansl commented on HBASE-12261:
---
need to add
{code}
configuration
failIfNoTestsfalse/failIfNoTests
...
{code}
I suppose.
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds. That would free
committers up from checking patches for stylistic issues and leave them free
to check the real meat of the patches.
Additionally we should have the check for empty try catch blocks running so
that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177917#comment-14177917
]
Andrew Purtell commented on HBASE-12261:
If I rm -rf ~/.m2/repository/org/apache/ and then do {{mvn -DskipTests clean
install mvn -DskipTests site package assembly:single}} on 0.98 branch with
the latest 0.98 patch on HBASE-12299 applied, everything builds successfully
and the assembly target produces a tarball that will boot in-tree. What's left
to do?
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds. That would free
committers up from checking patches for stylistic issues and leave them free
to check the real meat of the patches.
Additionally we should have the check for empty try catch blocks running so
that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177951#comment-14177951
]
Lars Hofhansl commented on HBASE-12261:
---
Before 776a0b09a2bde71210033a77ff56af5d73534f7e I could do {{mvn -DskipTest
clean install assembly:single}}. Maybe I'm not supposed to build it that way?
Definitely need to set failIfNoTests to false in the new module or
{{-Dtest=test}} is broken.
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds. That would free
committers up from checking patches for stylistic issues and leave them free
to check the real meat of the patches.
Additionally we should have the check for empty try catch blocks running so
that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177952#comment-14177952
]
Lars Hofhansl commented on HBASE-12261:
---
{{mvn -DskipTests install package assembly:single}} indeed does the right thing.
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds. That would free
committers up from checking patches for stylistic issues and leave them free
to check the real meat of the patches.
Additionally we should have the check for empty try catch blocks running so
that we can't regress on catching exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175452#comment-14175452 ] Hudson commented on HBASE-12261: FAILURE: Integrated in HBase-1.0 #325 (See [https://builds.apache.org/job/HBase-1.0/325/]) HBASE-12261 Add checkstyle to HBase build process (eclark: rev 990fb0b9d60abcddf4089bce7638806670803f95) * pom.xml * hbase-checkstyle/pom.xml * hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * dev-support/test-patch.sh * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175476#comment-14175476 ] Hudson commented on HBASE-12261: FAILURE: Integrated in HBase-0.98 #608 (See [https://builds.apache.org/job/HBase-0.98/608/]) HBASE-12261 Add checkstyle to HBase build process (eclark: rev efa813ed2f8b394b483abbe4d1d4b32c2b1b1d02) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml * hbase-checkstyle/pom.xml * dev-support/test-patch.sh * hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * pom.xml Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175495#comment-14175495 ] Hudson commented on HBASE-12261: SUCCESS: Integrated in HBase-TRUNK #5670 (See [https://builds.apache.org/job/HBase-TRUNK/5670/]) HBASE-12261 Add checkstyle to HBase build process (eclark: rev 487b58313c116b3c65d51bda6e9512aa85042671) * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml * hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * dev-support/test-patch.sh * pom.xml * hbase-checkstyle/pom.xml Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14175518#comment-14175518 ] Hudson commented on HBASE-12261: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #578 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/578/]) HBASE-12261 Add checkstyle to HBase build process (eclark: rev efa813ed2f8b394b483abbe4d1d4b32c2b1b1d02) * pom.xml * hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml * hbase-checkstyle/pom.xml * dev-support/test-patch.sh * hbase-checkstyle/src/main/resources/hbase/checkstyle.xml Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172532#comment-14172532 ] Andrew Purtell commented on HBASE-12261: +1 I like that we can toggle on or off individual checks in the checkstyle.xml control file Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-Add-checkstyle.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172555#comment-14172555 ] Elliott Clark commented on HBASE-12261: --- No that seems fine. Let me break the patch into two parts, the adding checkstyle and the fixes that way this is more easily back portable. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172699#comment-14172699
]
Hadoop QA commented on HBASE-12261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675057/0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
against trunk revision .
ATTACHMENT ID: 12675057
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 55 javac compiler
warnings (more than the trunk's current 53 warnings).
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ echo $MVN clean package checkstyle:checkstyle-aggregate -DskipTests
-D${PROJECT_NAME}PatchProcess $PATCH_DIR/trunkJavacWarnings.txt 21
+ $MVN clean package checkstyle:checkstyle-aggregate -DskipTests
-D${PROJECT_NAME}PatchProcess $PATCH_DIR/trunkJavacWarnings.txt 21
+trunkCheckstyleErrors=`$GREP 'error' $PATCH_DIR/trunkCheckstyle.xml |
$AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
+patchCheckstyleErrors=`$GREP 'error' $PATCH_DIR/patchCheckstyle.xml |
$AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
+{color:red}-1 javac{color}. The applied patch generated
$patchCheckstyleErrors checkstyle errors (more than the trunk's current
$trunkCheckstyleErrors errors).
+echo There were $patchCheckstyleErrors checkstyle errors in this patch
compared to $trunkCheckstyleErrors on master.
+{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11359//console
This message is automatically generated.
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 0.98.8, 0.99.2
Attachments: 0001-Add-checkstyle.patch,
0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
We should add checkstyle to hadoop qa for our builds.
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172748#comment-14172748 ] Elliott Clark commented on HBASE-12261: --- Hmmm let me look at why the site goal failed. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[
https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173077#comment-14173077
]
Hadoop QA commented on HBASE-12261:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675103/0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch
against trunk revision .
ATTACHMENT ID: 12675103
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 javac{color}. The applied patch generated 55 javac compiler
warnings (more than the trunk's current 53 warnings).
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ echo $MVN clean package checkstyle:checkstyle-aggregate -DskipTests
-D${PROJECT_NAME}PatchProcess $PATCH_DIR/trunkJavacWarnings.txt 21
+ $MVN clean package checkstyle:checkstyle-aggregate -DskipTests
-D${PROJECT_NAME}PatchProcess $PATCH_DIR/trunkJavacWarnings.txt 21
+trunkCheckstyleErrors=`$GREP 'error' $PATCH_DIR/trunkCheckstyle.xml |
$AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
+patchCheckstyleErrors=`$GREP 'error' $PATCH_DIR/patchCheckstyle.xml |
$AWK 'BEGIN {total = 0} {total += 1} END {print total}'`
+JIRA_COMMENT_FOOTER=Checkstyle Errors:
$BUILD_URL/artifact/patchprocess/checkstyle-aggregate.html
+{color:red}-1 javac{color}. The applied patch generated
$patchCheckstyleErrors checkstyle errors (more than the trunk's current
$trunkCheckstyleErrors errors).
+echo There were $patchCheckstyleErrors checkstyle errors in this patch
compared to $trunkCheckstyleErrors on master.
+{color:green}+1 javac{color}. The applied patch does not increase the
total number of checkstyle errors
+ echo $MVN package site -DskipTests -D${PROJECT_NAME}PatchProcess
$PATCH_DIR/patchSiteOutput.txt 21
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11364//console
This message is automatically generated.
Add checkstyle to HBase build process
-
Key: HBASE-12261
URL: https://issues.apache.org/jira/browse/HBASE-12261
Project: HBase
Issue Type: Bug
Components: build, site
Affects Versions: 2.0.0
Reporter: Elliott Clark
Assignee: Elliott
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173224#comment-14173224 ] Enis Soztutar commented on HBASE-12261: --- I like it. I hope that we can get the style warnings manageable. We can undo the line length check in test-patch.sh as well. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173244#comment-14173244 ] Elliott Clark commented on HBASE-12261: --- I was going to leave it for a while. Right now that error message is better and more useful since we have 50k checkstyle errors. It would make hunting down long lines harder. I'll have a follow on jira to get us down to a better number and then we can see if it's time remove that check. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173275#comment-14173275 ] Enis Soztutar commented on HBASE-12261: --- sounds good. 50K, wow! Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173280#comment-14173280 ] Elliott Clark commented on HBASE-12261: --- LoL yeah. It was 500K before I removed some checks and excluded generated code, so better than nothing. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 0.98.8, 0.99.2 Attachments: 0001-Add-checkstyle.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch, 0001-HBASE-12261-Add-checkstyle-to-HBase-build-process.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12261) Add checkstyle to HBase build process
[ https://issues.apache.org/jira/browse/HBASE-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171854#comment-14171854 ] stack commented on HBASE-12261: --- Excellent. Add checkstyle to HBase build process - Key: HBASE-12261 URL: https://issues.apache.org/jira/browse/HBASE-12261 Project: HBase Issue Type: Bug Components: build, site Affects Versions: 2.0.0 Reporter: Elliott Clark Assignee: Elliott Clark Attachments: 0001-Add-checkstyle.patch We should add checkstyle to hadoop qa for our builds. That would free committers up from checking patches for stylistic issues and leave them free to check the real meat of the patches. Additionally we should have the check for empty try catch blocks running so that we can't regress on catching exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
