[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357860#comment-14357860
]
Hudson commented on HBASE-13063:
SUCCESS: Integrated in HBase-TRUNK #6244 (See
[https://builds.apache.org/job/HBase-TRUNK/6244/])
HBASE-13063 Allow to turn off memstore replication for region replicas -
ADDENDUM for turning of primary flush tigger when this is enabled (enis: rev
c938267db3bfe95908f97397f64ffc50933e4343)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionReplicaUtil.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch, hbase-13063-addendum.patch, hbase-13063-addendum.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357869#comment-14357869
]
Hudson commented on HBASE-13063:
SUCCESS: Integrated in HBase-1.1 #281 (See
[https://builds.apache.org/job/HBase-1.1/281/])
HBASE-13063 Allow to turn off memstore replication for region replicas -
ADDENDUM for turning of primary flush tigger when this is enabled (enis: rev
0f892c23ecb7520d218fdddaa49ff69e6eb09152)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionReplicaUtil.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch, hbase-13063-addendum.patch, hbase-13063-addendum.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356524#comment-14356524
]
Matteo Bertozzi commented on HBASE-13063:
-
[~enis] +1 addendum looks good to me
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch, hbase-13063-addendum.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354796#comment-14354796
]
Hudson commented on HBASE-13063:
FAILURE: Integrated in HBase-1.1 #270 (See
[https://builds.apache.org/job/HBase-1.1/270/])
HBASE-13063 Allow to turn off memstore replication for region replicas
(matteo.bertozzi: rev eb2193afa0d266063b705d8743a940a06a5c2e9f)
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354856#comment-14354856
]
Hudson commented on HBASE-13063:
SUCCESS: Integrated in HBase-TRUNK #6234 (See
[https://builds.apache.org/job/HBase-TRUNK/6234/])
HBASE-13063 Allow to turn off memstore replication for region replicas
(matteo.bertozzi: rev cbf03787ea04da8d1c2ceef8fbb4ccbabb7d67ed)
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEdit.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356188#comment-14356188
]
Enis Soztutar commented on HBASE-13063:
---
The test succeeds run 20 times.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch, hbase-13063-addendum.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355545#comment-14355545
]
stack commented on HBASE-13063:
---
Failing on trunk [~mbertozzi]?
https://builds.apache.org/job/HBase-TRUNK/6236/testReport/
https://builds.apache.org/job/HBase-TRUNK/6235/
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355929#comment-14355929
]
Matteo Bertozzi commented on HBASE-13063:
-
[~stack] first run and pre-commit hook didn't fail
https://builds.apache.org/job/HBase-TRUNK/6234/ - locally it seems to work, let
me see if I'm missing something.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351226#comment-14351226
]
Enis Soztutar commented on HBASE-13063:
---
We can also document this in the book. There is a section for region replicas
already with all config options.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350925#comment-14350925
]
Hadoop QA commented on HBASE-13063:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12703106/HBASE-13063-v2.patch
against master branch at commit 6d4a4a48fe90b889c39e3ed42448fc7597a46973.
ATTACHMENT ID: 12703106
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13122//console
This message is automatically generated.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch, HBASE-13063-v2.patch,
HBASE-13063-v2.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343952#comment-14343952
]
Enis Soztutar commented on HBASE-13063:
---
+1 with two nits.
1. You can increment the skipped edits counter for all edits that are skipped.
We do this in many places and helps with debugging, etc.
2. The ordering between checking the memstore replication state and isMetaEdit
can be reversed. I think it boils down to whether we expect most of the tables
will have it disabled or enabled.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343033#comment-14343033
]
Hadoop QA commented on HBASE-13063:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12701832/HBASE-13063-v1.patch
against master branch at commit 4fb6f91cbad7d9b3c18f897ee3a4f70dc7c21595.
ATTACHMENT ID: 12701832
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod.testNoEdits(TestLogRollPeriod.java:78)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13033//console
This message is automatically generated.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch,
HBASE-13063-v1.patch, HBASE-13063-v1.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335066#comment-14335066
]
Hadoop QA commented on HBASE-13063:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12700503/HBASE-13063-v1.patch
against master branch at commit 977d65a81cc86d3d970878f74e11a7e1869de7f3.
ATTACHMENT ID: 12700503
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1937 checkstyle errors (more than the master's current 1936 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestShell
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12950//console
This message is automatically generated.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v1.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333256#comment-14333256
]
Hadoop QA commented on HBASE-13063:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12700160/HBASE-13063-v0.patch
against master branch at commit 6a4bca86e2b4dba2140f9886a6d4e9b59916a5a7.
ATTACHMENT ID: 12700160
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1937 checkstyle errors (more than the master's current 1936 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch(TestMasterRestartAfterDisablingTable.java:70)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12939//console
This message is automatically generated.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v0.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334125#comment-14334125
]
Enis Soztutar commented on HBASE-13063:
---
I like this. We can in turn get rid of the store file refresher chore and just
rely on this for read-only tables, etc.
Shall we pass FSTableDescriptors directly instead of server, then passing the
server than casting to HRS? Related, will lookup of a table's attribute too
costly for every edit? For table enabled / disable information we use guave
cache for caching up the lookup up to 5 seconds.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch, HBASE-13063-v0.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326502#comment-14326502
]
Srikanth Srungarapu commented on HBASE-13063:
-
Don't you think we should be setting the default flag to false?
{code} public static final boolean DEFAULT_REGION_MEMSTORE_REPLICATION = true;
{code}
May be a good idea to initialize with null as you are checking for null in
requiresReplication?
{code} private HRegionServer rsServerHost {code}
Also, it would be a good idea to ad LOG statement saying whether memstore
replication is enabled/disabled.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13063) Allow to turn off memstore replication for region replicas
[
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326573#comment-14326573
]
Matteo Bertozzi commented on HBASE-13063:
-
{quote}Don't you think we should be setting the default flag to false?{quote}
nah, in theory you expect the replica to be quite up to date.
this flag is just if your client can stay behind a lot and it is aware of
that.
{quote} May be a good idea to initialize with null as you are checking for null
in requiresReplication?{quote}
sure.. I'll add that. but null is the default value
http://docs.oracle.com/javase/specs/jls/se7/html/jls-4.html#jls-4.12.5
{quote}Also, it would be a good idea to ad LOG statement saying whether
memstore replication is enabled/disabled.{quote}
since we don't have a sink object for each table, it will require adding a set
or something to print the log only once. not sure if it is worth.
Allow to turn off memstore replication for region replicas
--
Key: HBASE-13063
URL: https://issues.apache.org/jira/browse/HBASE-13063
Project: HBase
Issue Type: New Feature
Components: regionserver, Replication
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Priority: Minor
Fix For: 2.0.0, 1.1.0
Attachments: HBASE-13063-v0.patch
HBASE-11568 allows to use replication to send wal edits from the primary to
the replicas.
sometimes the memstore replication is not required, so it will be nice have a
flag to disable it.
the result will be more or less the same to what we have in phase-1, but with
the row-level consistency provided by the flush edit transfered via
replication to refresh the hfiles.
create 't1', 'f', {REGION_REPLICATION = 2, REGION_MEMSTORE_REPLICATION =
false}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
