[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209614#comment-16209614 ] Josh Elser commented on HBASE-14077: I've convinced myself enough that this is the problem: opened up HBASE-19040 to fix it. > Add package to hbase-protocol protobuf files. > - > > Key: HBASE-14077 > URL: https://issues.apache.org/jira/browse/HBASE-14077 > Project: HBase > Issue Type: Bug > Components: Protobufs >Affects Versions: 2.0.0, 1.2.0, 1.3.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14077.patch > > > c++ generated code is currently in the default namespace. That's bad > practice; so lets fix it -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[
https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209555#comment-16209555
]
Josh Elser commented on HBASE-14077:
[~eclark], I'm worried that this is breaking compatibility with older 1.x
clients.
After including this change in a local build, I'm seeing some failures around a
client executing a CoprocessorService (specifically the AccessControlService)
The client submits a CP service name of {{AccessControlService}} but the
RegionServer has registered {{hbase.pb.AccessControlService}} instead. While
there is no outward change in the Java-generated code from the namespace
change, there is an implicit one, specifically around
{{ServiceDescriptor.getFullName()}}.
FYI [~enis]
> Add package to hbase-protocol protobuf files.
> -
>
> Key: HBASE-14077
> URL: https://issues.apache.org/jira/browse/HBASE-14077
> Project: HBase
> Issue Type: Bug
> Components: Protobufs
>Affects Versions: 2.0.0, 1.2.0, 1.3.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14077.patch
>
>
> c++ generated code is currently in the default namespace. That's bad
> practice; so lets fix it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628486#comment-14628486 ] Elliott Clark commented on HBASE-14077: --- K, pushing to branch-1 and master. Add package to hbase-protocol protobuf files. - Key: HBASE-14077 URL: https://issues.apache.org/jira/browse/HBASE-14077 Project: HBase Issue Type: Bug Components: Protobufs Affects Versions: 2.0.0, 1.2.0, 1.3.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 1.3.0 Attachments: HBASE-14077.patch c++ generated code is currently in the default namespace. That's bad practice; so lets fix it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628460#comment-14628460 ] Andrew Purtell commented on HBASE-14077: +1 Add package to hbase-protocol protobuf files. - Key: HBASE-14077 URL: https://issues.apache.org/jira/browse/HBASE-14077 Project: HBase Issue Type: Bug Components: Protobufs Affects Versions: 2.0.0, 1.2.0, 1.3.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 1.3.0 Attachments: HBASE-14077.patch c++ generated code is currently in the default namespace. That's bad practice; so lets fix it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628577#comment-14628577 ] Hudson commented on HBASE-14077: FAILURE: Integrated in HBase-TRUNK #6650 (See [https://builds.apache.org/job/HBase-TRUNK/6650/]) HBASE-14077 Add package to hbase-protocol protobuf files. (eclark: rev 62bce5f903b5744af4130a7915d98ce90a880efb) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MapReduceProtos.java * hbase-protocol/src/main/protobuf/Comparator.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java * hbase-protocol/src/main/protobuf/ErrorHandling.proto * hbase-protocol/src/main/protobuf/WAL.proto * hbase-protocol/src/main/protobuf/Cell.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java * hbase-protocol/src/main/protobuf/Procedure.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java * hbase-protocol/src/main/protobuf/FS.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-protocol/src/main/protobuf/Filter.proto * hbase-protocol/src/main/protobuf/Master.proto * hbase-protocol/src/main/protobuf/RPC.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutationProtos.java * hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/BulkDeleteProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/TracingProtos.java * hbase-protocol/src/main/protobuf/Aggregate.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FSProtos.java * hbase-protocol/src/main/protobuf/RowProcessor.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/LoadBalancerProtos.java * hbase-protocol/src/main/protobuf/ClusterId.proto * hbase-protocol/src/main/protobuf/SecureBulkLoad.proto * hbase-protocol/src/main/protobuf/MultiRowMutation.proto * hbase-protocol/src/main/protobuf/ZooKeeper.proto * hbase-protocol/src/main/protobuf/Authentication.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java * hbase-protocol/src/main/protobuf/ClusterStatus.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java * hbase-protocol/src/main/protobuf/AccessControl.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/EncryptionProtos.java * hbase-protocol/src/main/protobuf/Encryption.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java * hbase-protocol/src/main/protobuf/Admin.proto * hbase-examples/src/main/protobuf/Examples.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/CellProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ComparatorProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ErrorHandlingProtos.java * hbase-protocol/src/main/protobuf/MasterProcedure.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ProcedureProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RowProcessorProtos.java * hbase-protocol/src/main/protobuf/MapReduce.proto * hbase-protocol/src/main/protobuf/RegionServerStatus.proto * hbase-protocol/src/main/protobuf/Tracing.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterIdProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java * hbase-protocol/src/main/protobuf/HFile.proto * hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/ExampleProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HFileProtos.java * hbase-protocol/src/main/protobuf/HBase.proto * hbase-protocol/src/main/protobuf/Snapshot.proto * hbase-protocol/src/main/protobuf/Quota.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java * hbase-examples/src/main/protobuf/BulkDelete.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java * hbase-protocol/src/main/protobuf/VisibilityLabels.proto * hbase-protocol/src/main/protobuf/LoadBalancer.proto *
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628740#comment-14628740 ] Hudson commented on HBASE-14077: FAILURE: Integrated in HBase-1.3-IT #41 (See [https://builds.apache.org/job/HBase-1.3-IT/41/]) HBASE-14077 Add package to hbase-protocol protobuf files. (eclark: rev 9d06fc9f6bb908e9c5c8d22cb60c61ae4c71e0b2) * hbase-protocol/src/main/protobuf/RPC.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProcedureProtos.java * hbase-protocol/src/main/protobuf/RegionServerStatus.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java * hbase-protocol/src/main/protobuf/Quota.proto * hbase-protocol/src/main/protobuf/Cell.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java * hbase-protocol/src/main/protobuf/MultiRowMutation.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * hbase-protocol/src/main/protobuf/WAL.proto * hbase-protocol/src/main/protobuf/HFile.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java * hbase-protocol/src/main/protobuf/Aggregate.proto * hbase-protocol/src/main/protobuf/Admin.proto * hbase-protocol/src/main/protobuf/ZooKeeper.proto * hbase-protocol/src/main/protobuf/Master.proto * hbase-protocol/src/main/protobuf/Filter.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java * hbase-protocol/src/main/protobuf/ClusterStatus.proto * hbase-examples/src/main/protobuf/BulkDelete.proto * hbase-protocol/src/main/protobuf/Comparator.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutationProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java * hbase-protocol/src/main/protobuf/MapReduce.proto * hbase-protocol/src/main/protobuf/VisibilityLabels.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-protocol/src/main/protobuf/RowProcessor.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FSProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java * hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/BulkDeleteProtos.java * hbase-protocol/src/main/protobuf/Tracing.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ErrorHandlingProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MapReduceProtos.java * hbase-protocol/src/main/protobuf/AccessControl.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterIdProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java * hbase-protocol/src/main/protobuf/ClusterId.proto * hbase-protocol/src/main/protobuf/HBase.proto * hbase-protocol/src/main/protobuf/MasterProcedure.proto * hbase-examples/src/main/protobuf/Examples.proto * hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/ExampleProtos.java * hbase-protocol/src/main/protobuf/FS.proto * hbase-protocol/src/main/protobuf/Procedure.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/CellProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ComparatorProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java * hbase-protocol/src/main/protobuf/LoadBalancer.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HFileProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java * hbase-protocol/src/main/protobuf/Encryption.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java * hbase-protocol/src/main/protobuf/Snapshot.proto * hbase-protocol/src/main/protobuf/Client.proto * hbase-protocol/src/main/protobuf/SecureBulkLoad.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RowProcessorProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/TracingProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/EncryptionProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/LoadBalancerProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java *
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628771#comment-14628771 ] Hudson commented on HBASE-14077: SUCCESS: Integrated in HBase-1.3 #56 (See [https://builds.apache.org/job/HBase-1.3/56/]) HBASE-14077 Add package to hbase-protocol protobuf files. (eclark: rev 9d06fc9f6bb908e9c5c8d22cb60c61ae4c71e0b2) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java * hbase-protocol/src/main/protobuf/MultiRowMutation.proto * hbase-protocol/src/main/protobuf/Master.proto * hbase-protocol/src/main/protobuf/MapReduce.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/TracingProtos.java * hbase-protocol/src/main/protobuf/Cell.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RowProcessorProtos.java * hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/ExampleProtos.java * hbase-protocol/src/main/protobuf/LoadBalancer.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/QuotaProtos.java * hbase-protocol/src/main/protobuf/ClusterId.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ComparatorProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterIdProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java * hbase-protocol/src/main/protobuf/Client.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java * hbase-protocol/src/main/protobuf/Snapshot.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProcedureProtos.java * hbase-protocol/src/main/protobuf/Quota.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java * hbase-protocol/src/main/protobuf/Comparator.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ErrorHandlingProtos.java * hbase-protocol/src/main/protobuf/Admin.proto * hbase-protocol/src/main/protobuf/RowProcessor.proto * hbase-protocol/src/main/protobuf/Encryption.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutationProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java * hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/generated/BulkDeleteProtos.java * hbase-protocol/src/main/protobuf/MasterProcedure.proto * hbase-protocol/src/main/protobuf/RegionServerStatus.proto * hbase-protocol/src/main/protobuf/Authentication.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java * hbase-protocol/src/main/protobuf/SecureBulkLoad.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/EncryptionProtos.java * hbase-protocol/src/main/protobuf/FS.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/CellProtos.java * hbase-protocol/src/main/protobuf/HFile.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ProcedureProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/VisibilityLabelsProtos.java * hbase-protocol/src/main/protobuf/RPC.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/LoadBalancerProtos.java * hbase-examples/src/main/protobuf/Examples.proto * hbase-protocol/src/main/protobuf/Aggregate.proto * hbase-protocol/src/main/protobuf/ClusterStatus.proto * hbase-protocol/src/main/protobuf/Filter.proto * hbase-protocol/src/main/protobuf/ZooKeeper.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java * hbase-examples/src/main/protobuf/BulkDelete.proto * hbase-protocol/src/main/protobuf/Procedure.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HFileProtos.java * hbase-protocol/src/main/protobuf/Tracing.proto * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MapReduceProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-protocol/src/main/protobuf/ErrorHandling.proto * hbase-protocol/src/main/protobuf/WAL.proto *
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627147#comment-14627147 ] stack commented on HBASE-14077: --- LGTM. You don't want to put it in org.hbase package or org.apache.hbase package? Add package to hbase-protocol protobuf files. - Key: HBASE-14077 URL: https://issues.apache.org/jira/browse/HBASE-14077 Project: HBase Issue Type: Bug Components: Protobufs Affects Versions: 2.0.0, 1.2.0, 1.3.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 1.3.0 Attachments: HBASE-14077.patch c++ generated code is currently in the default namespace. That's bad practice; so lets fix it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[ https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627258#comment-14627258 ] Elliott Clark commented on HBASE-14077: --- Cpp projects are usually pretty flat, so I would prefer something with a little less typing. Add package to hbase-protocol protobuf files. - Key: HBASE-14077 URL: https://issues.apache.org/jira/browse/HBASE-14077 Project: HBase Issue Type: Bug Components: Protobufs Affects Versions: 2.0.0, 1.2.0, 1.3.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 2.0.0, 1.3.0 Attachments: HBASE-14077.patch c++ generated code is currently in the default namespace. That's bad practice; so lets fix it -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14077) Add package to hbase-protocol protobuf files.
[
https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627354#comment-14627354
]
Hadoop QA commented on HBASE-14077:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12745337/HBASE-14077.patch
against master branch at commit 2f327c911056d02813f642503db9a4383e8b4a2f.
ATTACHMENT ID: 12745337
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteRequest_descriptor;
+ return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteRequest_fieldAccessorTable
+return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteRequest_descriptor;
+return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteRequest_fieldAccessorTable
+return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteRequest_descriptor;
+ return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteResponse_descriptor;
+ return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteResponse_fieldAccessorTable
+return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteResponse_descriptor;
+return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteResponse_fieldAccessorTable
+return
org.apache.hadoop.hbase.coprocessor.example.generated.BulkDeleteProtos.internal_static_hbase_pb_BulkDeleteResponse_descriptor;
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.phoenix.end2end.index.GlobalIndexOptimizationIT.testGlobalIndexOptimizationOnSharedIndex(GlobalIndexOptimizationIT.java:299)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14773//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14773//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14773//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14773//console
This message is automatically generated.
Add package to hbase-protocol protobuf files.
-
Key: HBASE-14077
URL: https://issues.apache.org/jira/browse/HBASE-14077
Project: HBase
Issue Type: Bug
Components: Protobufs
Affects Versions: 2.0.0, 1.2.0, 1.3.0
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14077.patch
c++ generated code is currently in the default namespace. That's bad
practice; so lets fix it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
