[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218785#comment-16218785 ] Tamas Penzes commented on HBASE-14093: -- not really, we use maven-dependency-plugin 3.0.1 in branch-2 as well, should work > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > HBASE-14093.master.004.patch, direct_extract.log, indirect_extract.log, > patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216192#comment-16216192 ] Mike Drob commented on HBASE-14093: --- Patch applies well and runs well on master, but when I cherry-pick to branch-2, I get the following error: {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.0.1:unpack (unpack-bootstrap) on project hbase-static-web-resources: Unable to find artifact version of org.webjars:bootstrap in either dependency list or in project's dependency management. -> [Help 1] {noformat} Any ideas where this comes from? > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > HBASE-14093.master.004.patch, direct_extract.log, indirect_extract.log, > patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209573#comment-16209573 ] Tamas Penzes commented on HBASE-14093: -- Hi [~mdrob], Looks like I have misunderstand you. I've thought you want to move the download to hbase-assembly, which I would not do, but you only want to spare the move task from the download/extract/move. I'll do a fix soon. Regards, Tamaas > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > HBASE-14093.master.004.patch, patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209468#comment-16209468 ] Mike Drob commented on HBASE-14093: --- bq. I haven't moved the logic of downloading and extracting bootstrap and jquery to hbase-assembly, because this way we have a simple, easy to test web module, which doesn't depend on anything. The files fit into this project, and hbase-assembly can stay consistent. Ok, taking a second look, I realized this isn't what I was asking about. In hbase-static-web-resources/pom.xml we have {noformat} + +unpack-bootstrap + + ${project.build.directory}/generated-resources + + ... + +copy-bootstrap-resources +process-resources + + copy-resources + + + ${project.build.outputDirectory}/hbase-webapps/static + + + + ${project.build.directory}/generated-resources/META-INF/resources/webjars/bootstrap/${bootstrap.version} + + + + + {noformat} Do we do this because we don't actually want everything from the bootstrap download included? Or maybe it looks like the directory structure is too deep initially? Why can't we unpack directly to {{hbase-webapps/static}}, is what I'm trying to get at... > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > HBASE-14093.master.004.patch, patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208459#comment-16208459 ] Mike Drob commented on HBASE-14093: --- +1 patch looks good to me from visual inspection, i will try apply and test it when i get a chance. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > HBASE-14093.master.004.patch, patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204463#comment-16204463 ] Hadoop QA commented on HBASE-14093: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 17m 26s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 5s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 4s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 29s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 13s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 15s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 35m 5s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}174m 17s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 28s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}270m 45s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 | | JIRA Issue | HBASE-14093 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12892173/HBASE-14093.master.004.patch | | Optional Tests | asflicense shadedjars shellcheck shelldocs javac javadoc unit xml compile | | uname | Linux a6a4634584ba 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / a6c9d37 | | Default Java | 1.8.0_144 | | shellcheck | v0.4.6 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/9114/testReport/ | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/9114/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204326#comment-16204326 ] Tamas Penzes commented on HBASE-14093: -- [~mdrob] tab.js fixed maven hack removed (I've checked it, it's not needed any more) bootstrap updated to latest I haven't moved the logic of downloading and extracting bootstrap and jquery to hbase-assembly, because this way we have a simple, easy to test web module, which doesn't depend on anything. The files fit into this project, and hbase-assembly can stay consistent. Opinion? > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > HBASE-14093.master.004.patch, patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198741#comment-16198741 ] Mike Drob commented on HBASE-14093: --- tab.js is not third-party code, we should go ahead and fix the whitespace there. Why are we unpacking the webjar and then moving it to a different directory in two steps? Why not unpack it into the correct directory to begin with? Probably could add a comment to the build to explain this, there's already enough maven magic in the build that I don't think we need any more. Do we still need the maven 2.2 workaround in the jar plugin? Our minimum is Maven 3.0.3 for a long time now. Can we upgrade from Bootstrap 3.0.0 to something newer? The latest is 3.3.7 and probably has a lot of fixes and improvements. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190231#comment-16190231 ] Tamas Penzes commented on HBASE-14093: -- Whitespace issue only effects tab.js, which was already part of HBase, just moved to a different directory. I don't think we should change a third party file like that. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190174#comment-16190174 ] stack commented on HBASE-14093: --- Pushed to branch-2 and master. Let me see how it does in builds before closing. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, > patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189269#comment-16189269 ] Hadoop QA commented on HBASE-14093: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 6s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 19s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 13s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 32s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 43m 10s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-static-web-resources in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}100m 51s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 53s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 7s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 26s{color} | {color:green} hbase-assembly in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 25s{color} | {color:green} hbase-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}155m 59s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 20s{color} | {color:green} The patch does not generate ASF License
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186897#comment-16186897 ] Hadoop QA commented on HBASE-14093: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 35s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 10s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 19s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 13s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 31s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 45m 3s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 11s{color} | {color:green} hbase-static-web-resources in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}124m 19s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 11s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 5s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 26s{color} | {color:green} hbase-assembly in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s{color} | {color:green} hbase-shaded in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}117m 33s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 41s{color} | {color:green} The patch does not generate ASF License
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186655#comment-16186655 ] Tamas Penzes commented on HBASE-14093: -- [~busbey], I've fixed the issue. it works for me now in developer mode and in single instance mode as well > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, > HBASE-14093.master.003.patch, patch-shadedjars.txt > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162564#comment-16162564 ] Hadoop QA commented on HBASE-14093: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 6s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 33s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 9s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 48s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 11s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m 10s{color} | {color:red} patch has 12 errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 37m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s{color} | {color:green} hbase-static-web-resources in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}112m 7s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}178m 54s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 28s{color} | {color:green} hbase-assembly in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 21s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 8s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 1s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}376m 45s{color} | {color:black} {color} | \\ \\ || Subsystem ||
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161954#comment-16161954 ] Hadoop QA commented on HBASE-14093: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | | {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 6s{color} | {color:blue} Shelldocs was not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 2s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 47s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 4s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 11s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m 11s{color} | {color:red} patch has 12 errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 40m 30s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-static-web-resources in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 55m 17s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}159m 44s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 30s{color} | {color:green} hbase-assembly in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 20s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 57s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 58s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}303m 8s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161448#comment-16161448 ] Tamas Penzes commented on HBASE-14093: -- I had some misunderstanding of the project setup, since in production or standalone more we do use webapp files from ${HBASE_HOME}/hbase-webapps which means we only have the static files once. Because of this it did worth to remove the static files from hbase-server and hbase-thrift and put them to a new component. In the same time I use bootstrap and jquery from webjars, so their source is not stored in the repository but downloaded during the build. (easy version update) The delivered tar.gz file is slightly changed, it only contains one more jar (hbase-static-web-resources-${version}.jar) and of course some scripts are adopted to the changes (mostly effects developer setup, not production). > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch, > HBASE-14093.master.002.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155325#comment-16155325 ] Sean Busbey commented on HBASE-14093: - {quote} it is possible, I try to implement it. With any JEE container or standalone Jetty it would be simple, with embedded Jetty it's a bit more challenging, but I'll find a way. {quote} Let's save this as a follow on improvement. I don't want to hold up this good incremental gain. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152956#comment-16152956 ] Tamas Penzes commented on HBASE-14093: -- [~busbey], it is possible, I try to implement it. With any JEE container or standalone Jetty it would be simple, with embedded Jetty it's a bit more challenging, but I'll find a way. :-) > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145350#comment-16145350 ] Sean Busbey commented on HBASE-14093: - is it possible to put the needed CSS, JS, and font files into a single jar and then reuse that same jar with all the server roles that need to serve up a copy of those files for their web UIs? > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133020#comment-16133020 ] Tamas Penzes commented on HBASE-14093: -- something is not perfect, I'll fix it > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130845#comment-16130845 ] stack commented on HBASE-14093: --- My bad [~tamaas] I did not realize the patch recent. I read the issue and presumed the patch came in w/ original filing. Looking at patch, how does it deduplicate bootstrap instances? I see remove from thrift. Does it pickup the additions in hbase-webapps under hbase-server? Does it work? Did you try it out? Thanks. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130752#comment-16130752 ] Tamas Penzes commented on HBASE-14093: -- Hi [~stack], Could you please give me some pointers why did you change the state of this issue back to "In progress"? I can only create a new patch if I know what is the problem with the current one. Thanks, Tamaas > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118405#comment-16118405 ] Hadoop QA commented on HBASE-14093: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 32s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 4s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 32m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}126m 24s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 57s{color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}154m 35s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 51s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}346m 48s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 | | JIRA Issue | HBASE-14093 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12880800/HBASE-14093.master.001.patch | | Optional Tests | asflicense javac javadoc unit xml compile | | uname | Linux 7e1218c79168 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 0339068 | | Default Java | 1.8.0_131 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7976/testReport/ | | modules | C: hbase-server hbase-thrift . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7976/console | | Powered by | Apache Yetus 0.4.0 http://yetus.apache.org | This message was automatically generated. > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels:
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721269#comment-14721269 ] Gabor Liptak commented on HBASE-14093: -- [~busbey] Do you see the bootstrap files placed into hbase-resource-bundle project? deduplicate copies of bootstrap files - Key: HBASE-14093 URL: https://issues.apache.org/jira/browse/HBASE-14093 Project: HBase Issue Type: Improvement Components: build Reporter: Sean Busbey Labels: beginner Fix For: 2.0.0 right now we have a couple of different copies of the bootstrap js and css files. It'll be easier to maintain them later if we can centralize. Move them to a common location and use maven to populate them as needed in various component build directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650135#comment-14650135 ] Sean Busbey commented on HBASE-14093: - Hiya [~gliptak]. I'm trying to think of a straight forward way to do this by relying on a resource bundle from the maven remote resource plugin. Presuming I can get it working for the licensing stuff in HBASE-14085, that should provide a good example. deduplicate copies of bootstrap files - Key: HBASE-14093 URL: https://issues.apache.org/jira/browse/HBASE-14093 Project: HBase Issue Type: Improvement Components: build Reporter: Sean Busbey Labels: beginner Fix For: 2.0.0 right now we have a couple of different copies of the bootstrap js and css files. It'll be easier to maintain them later if we can centralize. Move them to a common location and use maven to populate them as needed in various component build directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648592#comment-14648592 ] Gabor Liptak commented on HBASE-14093: -- [~busbey] Could you offer pointers? Thanks deduplicate copies of bootstrap files - Key: HBASE-14093 URL: https://issues.apache.org/jira/browse/HBASE-14093 Project: HBase Issue Type: Improvement Components: build Reporter: Sean Busbey Labels: beginner Fix For: 2.0.0 right now we have a couple of different copies of the bootstrap js and css files. It'll be easier to maintain them later if we can centralize. Move them to a common location and use maven to populate them as needed in various component build directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635865#comment-14635865 ] Gabor Liptak commented on HBASE-14093: -- [~busbey] Which (parent) project do you see them being included? {code} ./hbase-server/src/main/resources/hbase-webapps/static/css/bootstrap.css ./hbase-server/src/main/resources/hbase-webapps/static/css/bootstrap.min.css ./hbase-server/src/main/resources/hbase-webapps/static/js/bootstrap.js ./hbase-server/src/main/resources/hbase-webapps/static/js/bootstrap.min.js ./hbase-thrift/src/main/resources/hbase-webapps/static/css/bootstrap.css ./hbase-thrift/src/main/resources/hbase-webapps/static/css/bootstrap.min.css ./hbase-thrift/src/main/resources/hbase-webapps/static/js/bootstrap.js ./hbase-thrift/src/main/resources/hbase-webapps/static/js/bootstrap.min.js {code} These projects have webapps folders currently: {code} ./hbase-rest/src/main/resources/hbase-webapps ./hbase-server/src/main/resources/hbase-webapps ./hbase-thrift/src/main/resources/hbase-webapps {code} deduplicate copies of bootstrap files - Key: HBASE-14093 URL: https://issues.apache.org/jira/browse/HBASE-14093 Project: HBase Issue Type: Improvement Components: build Reporter: Sean Busbey Labels: beginner Fix For: 2.0.0 right now we have a couple of different copies of the bootstrap js and css files. It'll be easier to maintain them later if we can centralize. Move them to a common location and use maven to populate them as needed in various component build directories. -- This message was sent by Atlassian JIRA (v6.3.4#6332)