[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727609#comment-14727609 ] Hudson commented on HBASE-14229: SUCCESS: Integrated in HBase-1.2-IT #124 (See [https://builds.apache.org/job/HBase-1.2-IT/124/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 3488ec4be8212b18370a7fb08c260ea5c87764d8) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727647#comment-14727647 ] Hudson commented on HBASE-14229: FAILURE: Integrated in HBase-1.2 #148 (See [https://builds.apache.org/job/HBase-1.2/148/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 3488ec4be8212b18370a7fb08c260ea5c87764d8) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727707#comment-14727707 ] Hudson commented on HBASE-14229: FAILURE: Integrated in HBase-1.3 #145 (See [https://builds.apache.org/job/HBase-1.3/145/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 1003d5a6d518e41868686d24de569fc2e29e) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727639#comment-14727639 ] Hudson commented on HBASE-14229: SUCCESS: Integrated in HBase-1.3-IT #128 (See [https://builds.apache.org/job/HBase-1.3-IT/128/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 1003d5a6d518e41868686d24de569fc2e29e) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727752#comment-14727752 ] Hudson commented on HBASE-14229: FAILURE: Integrated in HBase-1.1 #647 (See [https://builds.apache.org/job/HBase-1.1/647/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 670d9e77c5548df375f830a654ffed6f9d038005) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727776#comment-14727776 ] Hudson commented on HBASE-14229: FAILURE: Integrated in HBase-TRUNK #6773 (See [https://builds.apache.org/job/HBase-TRUNK/6773/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 15a88d2e1bd03ce26eb3e9f39ba31e95c2b78fc6) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728378#comment-14728378 ] Hudson commented on HBASE-14229: FAILURE: Integrated in HBase-0.98 #1108 (See [https://builds.apache.org/job/HBase-0.98/1108/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 76243a8a93f457ccbb643ab0314e29bac5200517) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728420#comment-14728420 ] Hudson commented on HBASE-14229: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1061 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1061/]) HBASE-14229 Flushing canceled by coprocessor still leads to memstoreSize set down (Yerui Sun) (tedyu: rev 76243a8a93f457ccbb643ab0314e29bac5200517) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727997#comment-14727997 ] Ted Yu commented on HBASE-14229: Ran 0.98 patch through test suite which passed. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726625#comment-14726625 ] Yerui Sun commented on HBASE-14229: --- [~yuzhih...@gmail.com], thanks a lot for your help to test and merge this patch. I ran through test suite on 0.98 and master branches and passed locally, as you did, but the QA failed. It's really confused me, could you please explain a bit more about why QA didn't work correctly, and how could I avoid these failure happened again with future patches? > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726633#comment-14726633 ] Ted Yu commented on HBASE-14229: Sean has a patch dealing with the warning about LICENSE.vm After that is merged, QA run should be more stable. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726105#comment-14726105 ] Ted Yu commented on HBASE-14229: [~apurtell]: Can you take a look at HBASE-14229-0.98-v2.patch ? > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726100#comment-14726100 ] Ted Yu commented on HBASE-14229: Ran master patch through test suite which passed. Going to commit soon. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun >Assignee: Yerui Sun > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1.patch, HBASE-14229-master.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725249#comment-14725249
]
Hadoop QA commented on HBASE-14229:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753511/HBASE-14229-0.98-v2.patch
against 0.98 branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
ATTACHMENT ID: 12753511
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.4.0.
Compilation errors resume:
[ERROR] Error invoking method 'get(java.lang.Integer)' in
java.util.ArrayList at META-INF/LICENSE.vm[line 1619, column 22]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) on
project hbase-assembly: Error rendering velocity resource. Error invoking
method 'get(java.lang.Integer)' in java.util.ArrayList at
META-INF/LICENSE.vm[line 1619, column 22]: InvocationTargetException: Index: 0,
Size: 0 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hbase-assembly
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15379//console
This message is automatically generated.
> Flushing canceled by coprocessor still leads to memstoreSize set down
> -
>
> Key: HBASE-14229
> URL: https://issues.apache.org/jira/browse/HBASE-14229
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>Reporter: Yerui Sun
> Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch,
> HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch,
> HBASE-14229-branch-1.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store,
> final InternalScanner scanner)" and return NULL when calling this method,
> will cancel flush request, leaving snapshot un-flushed, and no new storefile
> created. But the HRegion.internalFlushCache still set down memstoreSize to 0
> by totalFlushableSize.
> If there's no write requests anymore, the memstoreSize will remaining as 0,
> and no more flush quests will be processed because of the checking of
> memstoreSize.get() <=0 at the beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If
> we argree with this, I'll apply a patch later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725645#comment-14725645
]
Hadoop QA commented on HBASE-14229:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753550/HBASE-14229-master.patch
against master branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
ATTACHMENT ID: 12753550
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.4.0.
Compilation errors resume:
[ERROR] Error invoking method 'get(java.lang.Integer)' in
java.util.ArrayList at META-INF/LICENSE.vm[line 1619, column 22]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process (default) on
project hbase-assembly: Error rendering velocity resource. Error invoking
method 'get(java.lang.Integer)' in java.util.ArrayList at
META-INF/LICENSE.vm[line 1619, column 22]: InvocationTargetException: Index: 0,
Size: 0 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hbase-assembly
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15380//console
This message is automatically generated.
> Flushing canceled by coprocessor still leads to memstoreSize set down
> -
>
> Key: HBASE-14229
> URL: https://issues.apache.org/jira/browse/HBASE-14229
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>Reporter: Yerui Sun
> Attachments: HBASE-14229-0.98-v2.patch, HBASE-14229-0.98.patch,
> HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1-v2.patch,
> HBASE-14229-branch-1.patch, HBASE-14229-master.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store,
> final InternalScanner scanner)" and return NULL when calling this method,
> will cancel flush request, leaving snapshot un-flushed, and no new storefile
> created. But the HRegion.internalFlushCache still set down memstoreSize to 0
> by totalFlushableSize.
> If there's no write requests anymore, the memstoreSize will remaining as 0,
> and no more flush quests will be processed because of the checking of
> memstoreSize.get() <=0 at the beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If
> we argree with this, I'll apply a patch later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723606#comment-14723606
]
Hadoop QA commented on HBASE-14229:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753310/HBASE-14229-branch-1-v2.patch
against branch-1 branch at commit df341c4299ea21e4e1ca09652f6126633f2307c5.
ATTACHMENT ID: 12753310
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:red}-1 findbugs{color}. The patch appears to cause Findbugs
(version 2.0.3) to fail.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn post-site goal
to fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15353//testReport/
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15353//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15353//console
This message is automatically generated.
> Flushing canceled by coprocessor still leads to memstoreSize set down
> -
>
> Key: HBASE-14229
> URL: https://issues.apache.org/jira/browse/HBASE-14229
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>Reporter: Yerui Sun
> Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch,
> HBASE-14229-branch-1.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store,
> final InternalScanner scanner)" and return NULL when calling this method,
> will cancel flush request, leaving snapshot un-flushed, and no new storefile
> created. But the HRegion.internalFlushCache still set down memstoreSize to 0
> by totalFlushableSize.
> If there's no write requests anymore, the memstoreSize will remaining as 0,
> and no more flush quests will be processed because of the checking of
> memstoreSize.get() <=0 at the beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If
> we argree with this, I'll apply a patch later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723639#comment-14723639
]
Ted Yu commented on HBASE-14229:
The test suite wasn't run:
{code}
WARNING: 2 rogue build processes detected, terminating.
{code}
Mind attaching your patch again ?
> Flushing canceled by coprocessor still leads to memstoreSize set down
> -
>
> Key: HBASE-14229
> URL: https://issues.apache.org/jira/browse/HBASE-14229
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>Reporter: Yerui Sun
> Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch,
> HBASE-14229-branch-1.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store,
> final InternalScanner scanner)" and return NULL when calling this method,
> will cancel flush request, leaving snapshot un-flushed, and no new storefile
> created. But the HRegion.internalFlushCache still set down memstoreSize to 0
> by totalFlushableSize.
> If there's no write requests anymore, the memstoreSize will remaining as 0,
> and no more flush quests will be processed because of the checking of
> memstoreSize.get() <=0 at the beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If
> we argree with this, I'll apply a patch later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723728#comment-14723728 ] Ted Yu commented on HBASE-14229: +1 on patch v2. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun > Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723857#comment-14723857
]
Hadoop QA commented on HBASE-14229:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12753316/HBASE-14229-branch-1-v2.patch
against branch-1 branch at commit 498c1845ab7b01710955153c27501fdc7492849d.
ATTACHMENT ID: 12753316
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3818 checkstyle errors (more than the master's current 3816 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics.testMoveRegion(TestRemoveRegionMetrics.java:118)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15355//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15355//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15355//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15355//console
This message is automatically generated.
> Flushing canceled by coprocessor still leads to memstoreSize set down
> -
>
> Key: HBASE-14229
> URL: https://issues.apache.org/jira/browse/HBASE-14229
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1
>Reporter: Yerui Sun
> Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch,
> HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch
>
>
> A Coprocessor override "public InternalScanner preFlush(final Store store,
> final InternalScanner scanner)" and return NULL when calling this method,
> will cancel flush request, leaving snapshot un-flushed, and no new storefile
> created. But the HRegion.internalFlushCache still set down memstoreSize to 0
> by totalFlushableSize.
> If there's no write requests anymore, the memstoreSize will remaining as 0,
> and no more flush quests will be processed because of the checking of
> memstoreSize.get() <=0 at the beginning of internalFlushCache.
> This issue may not cause data loss, but it will confuse coprocessor users. If
> we argree with this, I'll apply a patch later.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723975#comment-14723975 ] Ted Yu commented on HBASE-14229: Ran patch through test suite in branch-1.1 which passed. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun > Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723978#comment-14723978 ] Ted Yu commented on HBASE-14229: [~sunyerui]: Mind attaching patch for master branch ? > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun > Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724750#comment-14724750 ] Yerui Sun commented on HBASE-14229: --- BTW, I also applied a patch for 0.98 branch, it seems didn't tested by Hadoop QA. Should we need still work on merging it into 0.98-branch, or just fix this issue in 1.x and upper? > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun > Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724748#comment-14724748 ] Yerui Sun commented on HBASE-14229: --- Of course Ted, I will apply a master patch in this week. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun > Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724761#comment-14724761 ] Ted Yu commented on HBASE-14229: You can reattach 0.98 patch for QA run. > Flushing canceled by coprocessor still leads to memstoreSize set down > - > > Key: HBASE-14229 > URL: https://issues.apache.org/jira/browse/HBASE-14229 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 >Reporter: Yerui Sun > Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1-v2.patch, > HBASE-14229-branch-1-v2.patch, HBASE-14229-branch-1.patch > > > A Coprocessor override "public InternalScanner preFlush(final Store store, > final InternalScanner scanner)" and return NULL when calling this method, > will cancel flush request, leaving snapshot un-flushed, and no new storefile > created. But the HRegion.internalFlushCache still set down memstoreSize to 0 > by totalFlushableSize. > If there's no write requests anymore, the memstoreSize will remaining as 0, > and no more flush quests will be processed because of the checking of > memstoreSize.get() <=0 at the beginning of internalFlushCache. > This issue may not cause data loss, but it will confuse coprocessor users. If > we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709186#comment-14709186 ] Ted Yu commented on HBASE-14229: You can run the failed tests locally to see if any test failure is reproducible. Last week there was fix for zombie tests. Please identify new checkstyle warning and fix it. Then you can attach new patch. Flushing canceled by coprocessor still leads to memstoreSize set down - Key: HBASE-14229 URL: https://issues.apache.org/jira/browse/HBASE-14229 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: sunyerui Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1.patch A Coprocessor override public InternalScanner preFlush(final Store store, final InternalScanner scanner) and return NULL when calling this method, will cancel flush request, leaving snapshot un-flushed, and no new storefile created. But the HRegion.internalFlushCache still set down memstoreSize to 0 by totalFlushableSize. If there's no write requests anymore, the memstoreSize will remaining as 0, and no more flush quests will be processed because of the checking of memstoreSize.get() =0 at the beginning of internalFlushCache. This issue may not cause data loss, but it will confuse coprocessor users. If we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709127#comment-14709127 ] sunyerui commented on HBASE-14229: -- Hi [~te...@apache.org], I noticed this patch was set as 'patch available' by you in last week. The Hadoop QA run tests on this patch and some unit tests failed, but I don't think all of them was failed because of this patch. Should I need to fix all these failed tests and re-post new patch, or just waiting for your review? Looking forward your reply, thank you. Flushing canceled by coprocessor still leads to memstoreSize set down - Key: HBASE-14229 URL: https://issues.apache.org/jira/browse/HBASE-14229 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: sunyerui Attachments: HBASE-14229-0.98.patch, HBASE-14229-branch-1.patch A Coprocessor override public InternalScanner preFlush(final Store store, final InternalScanner scanner) and return NULL when calling this method, will cancel flush request, leaving snapshot un-flushed, and no new storefile created. But the HRegion.internalFlushCache still set down memstoreSize to 0 by totalFlushableSize. If there's no write requests anymore, the memstoreSize will remaining as 0, and no more flush quests will be processed because of the checking of memstoreSize.get() =0 at the beginning of internalFlushCache. This issue may not cause data loss, but it will confuse coprocessor users. If we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[
https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704238#comment-14704238
]
Hadoop QA commented on HBASE-14229:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12751018/HBASE-14229-branch-1.patch
against branch-1 branch at commit 32b1064c6c372bd8b862ecbeb8877ad23e3e8220.
ATTACHMENT ID: 12751018
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
3821 checkstyle errors (more than the master's current 3819 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
org.apache.hadoop.hbase.regionserver.wal.TestProtobufLog
org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
org.apache.hadoop.hbase.regionserver.compactions.TestCompactionWithThroughputController
org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass
org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
org.apache.hadoop.hbase.regionserver.TestMajorCompaction
org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod
org.apache.hadoop.hbase.regionserver.TestZKLessSplitOnCluster
org.apache.hadoop.hbase.regionserver.TestScannerRetriableFailure
org.apache.hadoop.hbase.backup.TestHFileArchiving
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
org.apache.hadoop.hbase.regionserver.TestJoinedScanners
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.regionserver.wal.TestDurability
org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.coprocessor.TestBigDecimalColumnInterpreter
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.TestMetaTableAccessor
org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.regionserver.TestPriorityRpc
{color:red}-1 core zombie tests{color}. There are 11 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestGetClosestAtOrBefore.testUsingMetaAndBinary(TestGetClosestAtOrBefore.java:88)
at
[jira] [Commented] (HBASE-14229) Flushing canceled by coprocessor still leads to memstoreSize set down
[ https://issues.apache.org/jira/browse/HBASE-14229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699685#comment-14699685 ] stack commented on HBASE-14229: --- Sounds like a bug. Patch appreciated if you have one. Thank you [~sunyerui] Flushing canceled by coprocessor still leads to memstoreSize set down - Key: HBASE-14229 URL: https://issues.apache.org/jira/browse/HBASE-14229 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.98.13, 1.0.2, 1.2.0, 1.1.1 Reporter: sunyerui A Coprocessor override public InternalScanner preFlush(final Store store, final InternalScanner scanner) and return NULL when calling this method, will cancel flush request, leaving snapshot un-flushed, and no new storefile created. But the HRegion.internalFlushCache still set down memstoreSize to 0 by totalFlushableSize. If there's no write requests anymore, the memstoreSize will remaining as 0, and no more flush quests will be processed because of the checking of memstoreSize.get() =0 at the beginning of internalFlushCache. This issue may not cause data loss, but it will confuse coprocessor users. If we argree with this, I'll apply a patch later. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
