[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353360#comment-15353360 ] huaxiang sun commented on HBASE-14730: -- HBASE-16137 is opened to track the findbug warning. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353347#comment-15353347 ] huaxiang sun commented on HBASE-14730: -- Will open a new jira to track. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1535#comment-1535 ] stack commented on HBASE-14730: --- This issue is closed now. Do a new issue? > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353316#comment-15353316 ] huaxiang sun commented on HBASE-14730: -- [~anoop.hbase] Thanks for explain. [~saint@gmail.com], [~anoop.hbase], I just searched the stackoverflow. It seems there is a way to workaround this warning. I will try to come up with a new patch, thanks. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352418#comment-15352418 ] Anoop Sam John commented on HBASE-14730: Sorry for that Stack. We added static variable so as to reduce the log warns. But just thinking.. It is a clear wrong usage from customer.. They use feature which need write Cell tags but V3 is not used. Still write happens via HFileWriterV2. So let us log warn more? Just a new thought > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352411#comment-15352411 ] Anoop Sam John commented on HBASE-14730: With HFile V3, writing Tags to files will happen. It can be turned off using that boolean state in HFileContext. But this is not exposed for user modification. The code handles that when it see that there are no tags as part of any of the Cells in new File. Places where turning ON this context state (It should be ON by default) is a bug for us. I mean the ImportTSV case etc. This jira speaks abt end user usage of tag related attributes for data and V3 is not enabled. So there is no problem in the fix. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352394#comment-15352394 ] stack commented on HBASE-14730: --- Lads. This patch makes for a new findbugs warning: https://builds.apache.org/job/PreCommit-HBASE-Build/2390/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html If you are good w/ the code, i can fix the findbugs warning... just say. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351943#comment-15351943 ] huaxiang sun commented on HBASE-14730: -- Hi [~anoop.hbase], with HFile version 3, includesTags in HFileContext can still be set to false, please see HBASE-15707. The warning message may not be appropriate here. Do you have suggestion for the warning message? Another thought, for master/hbase-2.0, do you think it is a good idea for the includesTags to be true by default? If it needs to be set to false, user can call api to set. Thanks. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337178#comment-15337178 ] Hudson commented on HBASE-14730: SUCCESS: Integrated in HBase-1.3-IT #714 (See [https://builds.apache.org/job/HBase-1.3-IT/714/]) HBASE-14730 region server needs to log warnings when there are (antonov: rev 39ee3091a149dc85141b80a34a74f8f6283c4011) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337128#comment-15337128 ] Hudson commented on HBASE-14730: FAILURE: Integrated in HBase-1.3 #744 (See [https://builds.apache.org/job/HBase-1.3/744/]) HBASE-14730 region server needs to log warnings when there are (antonov: rev 39ee3091a149dc85141b80a34a74f8f6283c4011) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337030#comment-15337030 ] Hudson commented on HBASE-14730: FAILURE: Integrated in HBase-1.4 #222 (See [https://builds.apache.org/job/HBase-1.4/222/]) HBASE-14730 region server needs to log warnings when there are (antonov: rev 1f37cdfb4b970649d30a6ff41f00c7cf0b46aabc) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336818#comment-15336818 ] Mikhail Antonov commented on HBASE-14730: - I see - thanks! > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336815#comment-15336815 ] huaxiang sun commented on HBASE-14730: -- Hi [~mantonov], [~mbertozzi] just mentioned that a patch would be needed for master branch as well. For bulkload tools, it is possible to forget to set includesTags, like HBASE-15707. I am going to work on a patch for the master. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1533#comment-1533 ] Mikhail Antonov commented on HBASE-14730: - Pushed to branch-1 and branch-1.3 Thanks! > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336659#comment-15336659 ] Mikhail Antonov commented on HBASE-14730: - It cherry-picked cleanly in b-1. let me commit it . Thanks for checking! > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336651#comment-15336651 ] huaxiang sun commented on HBASE-14730: -- Yeah, it exists in b-1. Not sure if patch for branch-1.2 still applies to branch-1, if not, I can work on one, thanks! > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336637#comment-15336637 ] Mikhail Antonov commented on HBASE-14730: - In b-1 there's HFileWriterV2. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336632#comment-15336632 ] huaxiang sun commented on HBASE-14730: -- Hi [~mantonov], in master and b-1, maybe b-1.3, there is no v2 writer, only v3 writer, so the patch is not needed for these branches. I will double check and confirm. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336589#comment-15336589 ] Mikhail Antonov commented on HBASE-14730: - [~anoop.hbase] [~huaxiang] that wasn't committed to other branches, master, b-1, b-1.3? Any reason for that? Going to port to other branches unless there's a reason not to. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064226#comment-15064226 ] Hudson commented on HBASE-14730: FAILURE: Integrated in HBase-1.0 #1124 (See [https://builds.apache.org/job/HBase-1.0/1124/]) HBASE-14730 region server needs to log warnings when there are (matteo.bertozzi: rev 736f5b3abf16e922439af614d4754e0dfa9858a2) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.1.3, 1.0.4 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063105#comment-15063105 ] Hudson commented on HBASE-14730: FAILURE: Integrated in HBase-1.1-JDK8 #1710 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1710/]) HBASE-14730 region server needs to log warnings when there are (matteo.bertozzi: rev af1f6ee18860ca3c6f2117a01fd6b9006e7ffefa) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.1.3, 1.0.4 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062781#comment-15062781 ] Hudson commented on HBASE-14730: FAILURE: Integrated in HBase-1.2 #451 (See [https://builds.apache.org/job/HBase-1.2/451/]) HBASE-14730 region server needs to log warnings when there are (matteo.bertozzi: rev a67f581a92f76906ac0c68535aa71cec6798318f) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.1.3, 1.0.4 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062736#comment-15062736 ] Hudson commented on HBASE-14730: FAILURE: Integrated in HBase-1.2-IT #348 (See [https://builds.apache.org/job/HBase-1.2-IT/348/]) HBASE-14730 region server needs to log warnings when there are (matteo.bertozzi: rev a67f581a92f76906ac0c68535aa71cec6798318f) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Fix For: 1.2.0, 1.1.3, 1.0.4 > > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062377#comment-15062377 ] Matteo Bertozzi commented on HBASE-14730: - sure, let me commit that now. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062374#comment-15062374 ] Anoop Sam John commented on HBASE-14730: [~mbertozzi] You will commit the patch? > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062351#comment-15062351 ] huaxiang sun commented on HBASE-14730: -- [~anoop.hbase] Thanks a lot for reviewing and the comments. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062070#comment-15062070 ] Anoop Sam John commented on HBASE-14730: Patch looks good. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061323#comment-15061323
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16893//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16893//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16893//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16893//console
This message is automatically generated.
> region server needs to log warnings when there are attributes configured for
> cells with hfile v2
>
>
> Key: HBASE-14730
> URL: https://issues.apache.org/jira/browse/HBASE-14730
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch,
> HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch
>
>
> User can configure cell attributes with hfile.format.version 2. When cells
> are flushed from memStore to Hfile, attributes are not saved. Warnings need
> to be logged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061029#comment-15061029 ] huaxiang sun commented on HBASE-14730: -- Rename the patch so it can be picked up for branch-1.2. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061030#comment-15061030 ] huaxiang sun commented on HBASE-14730: -- Created HBASE-14995 > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, > HBASE-14730-v002-1.2.0.patch, HBASE-14730-v002_branch-1.2.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061026#comment-15061026
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12778108/HBASE-14730-v002-1.2.0.patch
against master branch at commit 6a0159046e5301cb45ee2c878ad7583bf9ad94ce.
ATTACHMENT ID: 12778108
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16887//console
This message is automatically generated.
> region server needs to log warnings when there are attributes configured for
> cells with hfile v2
>
>
> Key: HBASE-14730
> URL: https://issues.apache.org/jira/browse/HBASE-14730
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch,
> HBASE-14730-v002-1.2.0.patch
>
>
> User can configure cell attributes with hfile.format.version 2. When cells
> are flushed from memStore to Hfile, attributes are not saved. Warnings need
> to be logged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060956#comment-15060956
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] With help from [~mbertozzi], we found the flag you mentioned. I
uploaded the latest patch. Also found that in DefaultMemStore.java, it can be
optimized for tagsPresent, will create another jira for the optimization.
Thanks.
private boolean addToCellSet(Cell e) {
boolean b = this.cellSet.add(e);
// In no tags case this NoTagsKeyValue.getTagsLength() is a cheap call.
// When we use ACL CP or Visibility CP which deals with Tags during
// mutation, the TagRewriteCell.getTagsLength() is a cheaper call. We do not
// parse the byte[] to identify the tags length.
-if(e.getTagsLength() > 0) {
+if(!tagsPresent && (e.getTagsLength() > 0)) {
tagsPresent = true;
}
setOldestEditTimeToNow();
return b;
}
> region server needs to log warnings when there are attributes configured for
> cells with hfile v2
>
>
> Key: HBASE-14730
> URL: https://issues.apache.org/jira/browse/HBASE-14730
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch,
> HBASE-14730-v002-1.2.0.patch
>
>
> User can configure cell attributes with hfile.format.version 2. When cells
> are flushed from memStore to Hfile, attributes are not saved. Warnings need
> to be logged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060653#comment-15060653 ] huaxiang sun commented on HBASE-14730: -- [~anoop.hbase] I checked the master branch, the v2 writer is gone, HFileWriterImpl is v3. I tried to search the boolean you mentioned and could not find it. The only thing I found is that in OffheapKeyValue, there is a boolean hasTag, which makes getTagsLength() faster when there is no tag. Thanks. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034171#comment-15034171 ] huaxiang sun commented on HBASE-14730: -- [~anoop.hbase] [~mbertozzi] Thanks for reviewing and comments. I will take care of the comments and send out a new patch. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033726#comment-15033726 ] Anoop Sam John commented on HBASE-14730: The fix has to come for trunk also. There also one can change to use HFileV2. In trunk am sure we can check one boolean during flush which says whether tags are part of any of the cells being flushed. In this patch we check tags length with every cell.. Parsing tags length is not so simple op FYI. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033725#comment-15033725 ] Anoop Sam John commented on HBASE-14730: Yes IMO also warn log per flush seems too much. Already raised this concern. Ya per life time of an RS once is the best way. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032169#comment-15032169
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12774844/HBASE-14730-v001-1.2.0.patch
against master branch at commit 999ae691559a49321138eb7718eb204435639db9.
ATTACHMENT ID: 12774844
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16701//console
This message is automatically generated.
> region server needs to log warnings when there are attributes configured for
> cells with hfile v2
>
>
> Key: HBASE-14730
> URL: https://issues.apache.org/jira/browse/HBASE-14730
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch
>
>
> User can configure cell attributes with hfile.format.version 2. When cells
> are flushed from memStore to Hfile, attributes are not saved. Warnings need
> to be logged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032134#comment-15032134 ] Matteo Bertozzi commented on HBASE-14730: - is a warn per flush too often? if we remove the static on warnCellWithTags we can get the warn per flush. but maybe is too much. otherwise as it is we log just once for all the RS lifetime. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Affects Versions: 1.0.0, 1.1.0, 1.2.0 >Reporter: huaxiang sun >Assignee: huaxiang sun > Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch > > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028059#comment-15028059
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12774446/HBASE-14730-v001.patch
against master branch at commit e73a9594c218ed969a2f5b0b356d7b8d0e1474c0.
ATTACHMENT ID: 12774446
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16674//console
This message is automatically generated.
> region server needs to log warnings when there are attributes configured for
> cells with hfile v2
>
>
> Key: HBASE-14730
> URL: https://issues.apache.org/jira/browse/HBASE-14730
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 1.0.0, 1.1.0, 1.2.0
>Reporter: huaxiang sun
>Assignee: huaxiang sun
> Attachments: HBASE-14730-v001.patch
>
>
> User can configure cell attributes with hfile.format.version 2. When cells
> are flushed from memStore to Hfile, attributes are not saved. Warnings need
> to be logged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985874#comment-14985874 ] huaxiang sun commented on HBASE-14730: -- Discussed with [~mbertozzi], Adding a flag in Writer can solve this issue, working on the patch. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: huaxiang sun >Assignee: huaxiang sun > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985641#comment-14985641 ] huaxiang sun commented on HBASE-14730: -- [~anoop.hbase] Yes, I meant cell tags. That is the concern I have as well. I am seeking better advice as well. Thought about adding a warning per flush, it seems a hack to me coding wise. Thanks. > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: huaxiang sun >Assignee: huaxiang sun > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984777#comment-14984777 ] Anoop Sam John commented on HBASE-14730: Adding a log for every flush will be too much of log info? > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: huaxiang sun >Assignee: huaxiang sun > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
[ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984775#comment-14984775 ] Anoop Sam John commented on HBASE-14730: bq.When cells are flushed from memStore to Hfile, attributes are not saved. You mean Cell Tags? > region server needs to log warnings when there are attributes configured for > cells with hfile v2 > > > Key: HBASE-14730 > URL: https://issues.apache.org/jira/browse/HBASE-14730 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: huaxiang sun >Assignee: huaxiang sun > > User can configure cell attributes with hfile.format.version 2. When cells > are flushed from memStore to Hfile, attributes are not saved. Warnings need > to be logged. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
