[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-05 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133841#comment-15133841
 ] 

Hudson commented on HBASE-15197:


FAILURE: Integrated in HBase-Trunk_matrix #682 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/682/])
HBASE-15197 Expose filtered read requests metric to metrics framework 
(chenheng: rev 8f20bc748de60f8da3ab7f66c6a198515d53de35)
* hbase-protocol/src/main/protobuf/ClusterStatus.proto
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/RegionLoad.java
* 
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerLoad.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
* 
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
* 
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java
* 
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapper.java
* 
hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java
* 
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/TestRegionServerMetrics.java
* 
hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java
* 
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java
* 
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionServer.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java


> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197-v1.patch, HBASE-15197-v2.patch, 
> HBASE-15197.patch, HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-04 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133322#comment-15133322
 ] 

Ted Yu commented on HBASE-15197:


[~chenheng]:
Please go ahead with commit.

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197-v1.patch, HBASE-15197-v2.patch, 
> HBASE-15197.patch, HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-04 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133551#comment-15133551
 ] 

Heng Chen commented on HBASE-15197:
---

Push to master.

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197-v1.patch, HBASE-15197-v2.patch, 
> HBASE-15197.patch, HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-03 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130243#comment-15130243
 ] 

Hadoop QA commented on HBASE-15197:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 43s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 24s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 31s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 18m 
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
52s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 8s 
{color} | {color:red} hbase-protocol in the patch failed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 6s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 36s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 24s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 24s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 24s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 34s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 34s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 34s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 18m 
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
52s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
21m 47s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 7s 
{color} | {color:red} hbase-protocol in the patch failed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 8s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 20s 
{color} | {color:green} hbase-protocol in the patch passed with JDK v1.8.0_72. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 48s 
{color} | {color:green} hbase-client in the 

[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128687#comment-15128687
 ] 

Ted Yu commented on HBASE-15197:


{code}
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:584:
@Override:5: error: Method length is 159 lines (max allowed is 150).
{code}
Even if the change in this method doesn't wrap to new line, the length of 
method would still exceed 150.
Nothing to be done for the above warning.

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197.patch, HBASE-15197.patch, 
> WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128694#comment-15128694
 ] 

Ted Yu commented on HBASE-15197:


{code}
140   /** the current total read requests made to region */
141   optional uint64 filtered_read_requests_count = 19;
{code}
Please modify the comment to match new field.

lgtm otherwise

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197.patch, HBASE-15197.patch, 
> WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127894#comment-15127894
 ] 

Hadoop QA commented on HBASE-15197:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 45s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 28s 
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 29s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 
58s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s 
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 26s 
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 26s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 26s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 28s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 28s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 28s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 24s 
{color} | {color:red} hbase-server: patch generated 1 new + 434 unchanged - 1 
fixed = 435 total (was 435) {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
22m 3s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
4s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 20s 
{color} | {color:green} hbase-protocol in the patch passed with JDK v1.8.0_66. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 44s 

[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129909#comment-15129909
 ] 

Heng Chen commented on HBASE-15197:
---

trigger QA.  https://builds.apache.org/job/PreCommit-HBASE-Build/410/

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197-v1.patch, HBASE-15197-v2.patch, 
> HBASE-15197.patch, HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129971#comment-15129971
 ] 

Hadoop QA commented on HBASE-15197:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 51s 
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
31s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 11s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 53s 
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 18m 
36s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
10s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 8s 
{color} | {color:red} hbase-protocol in the patch failed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 
39s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 42s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 42s 
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 41s 
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 16s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 0s 
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 0s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 0s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 21m 
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
9s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
31m 56s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 8s 
{color} | {color:red} hbase-protocol in the patch failed. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m 
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 27s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 8s 
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 42s 
{color} | {color:green} hbase-protocol in the patch passed with JDK v1.8.0_72. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 30s 
{color} | {color:green} hbase-client in the 

[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129609#comment-15129609
 ] 

Hadoop QA commented on HBASE-15197:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 34s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
5s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
12s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 15s 
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 10s 
{color} | {color:red} hbase-hadoop2-compat in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 25s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 23s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_72. 
{color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 23s {color} | 
{color:red} hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 25s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_91. 
{color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 25s {color} | 
{color:red} hbase-server in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 25s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 1s 
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-server 
(total was 435, now 435). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
22m 13s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
3s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
54s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 50s 
{color} | {color:green} 

[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-02 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129689#comment-15129689
 ] 

Heng Chen commented on HBASE-15197:
---

+1 on patch v2.   If no other concerns, let me commit it later.  [~tedyu] :)

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197-v1.patch, HBASE-15197-v2.patch, 
> HBASE-15197.patch, HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Eungsop Yoo (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126917#comment-15126917
 ] 

Eungsop Yoo commented on HBASE-15197:
-

After running below command at the root directory of HBase project, the 
compilation errors are removed.
{code}
mvn clean install -DskipTests
{code}
I think Test environment should do this before running test.

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Priority: Minor
> Attachments: HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127570#comment-15127570
 ] 

Heng Chen commented on HBASE-15197:
---

See HBASE-15128  Sean Busbey comment about build with USE_YETUS_PRERELEASE

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Priority: Minor
> Attachments: HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125941#comment-15125941
 ] 

Heng Chen commented on HBASE-15197:
---

LGTM. +1

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Priority: Minor
> Attachments: HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Eungsop Yoo (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125962#comment-15125962
 ] 

Eungsop Yoo commented on HBASE-15197:
-

I have no problem in my PC for running tests. What should I do in this case?

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Priority: Minor
> Attachments: HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Eungsop Yoo (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127624#comment-15127624
 ] 

Eungsop Yoo commented on HBASE-15197:
-

I don't have a login account for builds.apache.org. Someone please help me.

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Priority: Minor
> Attachments: HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127749#comment-15127749
 ] 

Hadoop QA commented on HBASE-15197:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 38s 
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 37s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 10m 
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s 
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 25s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 15s 
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 11s 
{color} | {color:red} hbase-hadoop2-compat in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 28s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 26s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_66. 
{color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 26s {color} | 
{color:red} hbase-server in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 26s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 28s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_91. 
{color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 28s {color} | 
{color:red} hbase-server in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 28s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 35s 
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-server 
(total was 435, now 435). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
56s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
25m 2s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
8s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s 
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s 
{color} | {color:green} 

[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Heng Chen (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127641#comment-15127641
 ] 

Heng Chen commented on HBASE-15197:
---

OK  
https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HBASE-Build/382/

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Assignee: Eungsop Yoo
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15197.patch, HBASE-15197.patch, 
> WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-02-01 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126436#comment-15126436
 ] 

Ted Yu commented on HBASE-15197:


If you look at:
https://builds.apache.org/job/PreCommit-HBASE-Build/365/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_66.txt

You would see the compilation error.

> Expose filtered read requests metric to metrics framework and Web UI
> 
>
> Key: HBASE-15197
> URL: https://issues.apache.org/jira/browse/HBASE-15197
> Project: HBase
>  Issue Type: Improvement
>Reporter: Eungsop Yoo
>Priority: Minor
> Attachments: HBASE-15197.patch, WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-15197) Expose filtered read requests metric to metrics framework and Web UI

2016-01-31 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125891#comment-15125891
 ] 

Hadoop QA commented on HBASE-15197:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 7 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s 
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m 
0s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
0s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 7s 
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s 
{color} | {color:green} master passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 32s 
{color} | {color:green} master passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 17s 
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 12s 
{color} | {color:red} hbase-hadoop2-compat in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 29s 
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 29s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.8.0_66. 
{color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 29s {color} | 
{color:red} hbase-server in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 29s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 30s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_91. 
{color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 30s {color} | 
{color:red} hbase-server in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 30s {color} 
| {color:red} hbase-server in the patch failed with JDK v1.7.0_91. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 21s 
{color} | {color:red} Patch generated 1 new checkstyle issues in hbase-server 
(total was 435, now 435). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
56s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 1s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 
16s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s 
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 32s 
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 57s 
{color} | {color:green}