[jira] [Commented] (HBASE-15266) add precommit check for "catch Throwable"
[ https://issues.apache.org/jira/browse/HBASE-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146712#comment-15146712 ] Sean Busbey commented on HBASE-15266: - Exceptions to a rule are likely to exist, and the judgement of our committers should be able to handle identifying appropriate uses and ensuring that we're handling things correctly (for example making sure we're not discarding Errors). > add precommit check for "catch Throwable" > - > > Key: HBASE-15266 > URL: https://issues.apache.org/jira/browse/HBASE-15266 > Project: HBase > Issue Type: New Feature > Components: test >Reporter: Sean Busbey >Priority: Minor > > Catching Throwable is usually incorrect because it gets all of the Error > derived problems, like ThreadDeath, OutOfMemoryError, VM malfunctions, linker > problems, etc. > I was surprised to see findbugs did not flag catching throwable in the > patches on HBASE-9393. We should add a precommit check that looks expressly > for it, in our "hbase antipatterns" test plugin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15266) add precommit check for "catch Throwable"
[ https://issues.apache.org/jira/browse/HBASE-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146456#comment-15146456 ] Heng Chen commented on HBASE-15266: --- IMO some monitor threads need to catch throwable. > add precommit check for "catch Throwable" > - > > Key: HBASE-15266 > URL: https://issues.apache.org/jira/browse/HBASE-15266 > Project: HBase > Issue Type: New Feature > Components: test >Reporter: Sean Busbey >Priority: Minor > > Catching Throwable is usually incorrect because it gets all of the Error > derived problems, like ThreadDeath, OutOfMemoryError, VM malfunctions, linker > problems, etc. > I was surprised to see findbugs did not flag catching throwable in the > patches on HBASE-9393. We should add a precommit check that looks expressly > for it, in our "hbase antipatterns" test plugin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15266) add precommit check for "catch Throwable"
[ https://issues.apache.org/jira/browse/HBASE-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146445#comment-15146445 ] Anoop Sam John commented on HBASE-15266: I have seen many a places in our code base, we have catch of Throwable.. > add precommit check for "catch Throwable" > - > > Key: HBASE-15266 > URL: https://issues.apache.org/jira/browse/HBASE-15266 > Project: HBase > Issue Type: New Feature > Components: test >Reporter: Sean Busbey >Priority: Minor > > Catching Throwable is usually incorrect because it gets all of the Error > derived problems, like ThreadDeath, OutOfMemoryError, VM malfunctions, linker > problems, etc. > I was surprised to see findbugs did not flag catching throwable in the > patches on HBASE-9393. We should add a precommit check that looks expressly > for it, in our "hbase antipatterns" test plugin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
