[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272672#comment-15272672 ] Hudson commented on HBASE-15357: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1212 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1212/]) HBASE-15357 TableInputFormatBase getSplitKey does not handle signed (apurtell: rev 176bd1cd3c4d2a271dbfb81f411364691712c2b7) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan1.java > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272281#comment-15272281 ] Hudson commented on HBASE-15357: FAILURE: Integrated in HBase-0.98-matrix #340 (See [https://builds.apache.org/job/HBase-0.98-matrix/340/]) HBASE-15357 TableInputFormatBase getSplitKey does not handle signed (apurtell: rev 176bd1cd3c4d2a271dbfb81f411364691712c2b7) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan1.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265212#comment-15265212 ] Hudson commented on HBASE-15357: SUCCESS: Integrated in HBase-1.3-IT #643 (See [https://builds.apache.org/job/HBase-1.3-IT/643/]) HBASE-15357 TableInputFormatBase getSplitKey does not handle signed (tedyu: rev 73129389423117f23b0f658408c6ee04294d9f07) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan1.java > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265199#comment-15265199 ] Hudson commented on HBASE-15357: FAILURE: Integrated in HBase-1.3 #679 (See [https://builds.apache.org/job/HBase-1.3/679/]) HBASE-15357 TableInputFormatBase getSplitKey does not handle signed (tedyu: rev 73129389423117f23b0f658408c6ee04294d9f07) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan1.java > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265174#comment-15265174 ] Hudson commented on HBASE-15357: FAILURE: Integrated in HBase-1.4 #127 (See [https://builds.apache.org/job/HBase-1.4/127/]) HBASE-15357 TableInputFormatBase getSplitKey does not handle signed (tedyu: rev 57ca428c542b8bdb56e1b14d8e4fea533c12710a) * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan1.java > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265131#comment-15265131 ] Hudson commented on HBASE-15357: FAILURE: Integrated in HBase-Trunk_matrix #883 (See [https://builds.apache.org/job/HBase-Trunk_matrix/883/]) HBASE-15357 TableInputFormatBase getSplitKey does not handle signed (tedyu: rev c236409c3b9fb02bcd26cb632b9cb5b5f7a80652) * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan1.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt, > 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[
https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265121#comment-15265121
]
Hadoop QA commented on HBASE-15357:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s {color}
| {color:red} HBASE-15357 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.2.1/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12801578/15357-branch-1.v3.txt
|
| JIRA Issue | HBASE-15357 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/1692/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> TableInputFormatBase getSplitKey does not handle signed bytes correctly
> ---
>
> Key: HBASE-15357
> URL: https://issues.apache.org/jira/browse/HBASE-15357
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
>Reporter: Nathan Schile
>Assignee: Nathan Schile
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 15357-branch-1.v2.txt, 15357-branch-1.v3.txt,
> 15357.v2.txt, HBASE-15357.patch
>
>
> When auto-balance is enabled in TableInputFormatBase and the table key is a
> binary key, the getSplitKey method does not function correctly for signed
> bytes. The proposed solution it to utilize
> org.apache.hadoop.hbase.util.Bytes#split method to find the split key.
> org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive
> operation, so if another solution is preferred, that is fine. In addition,
> handling of a split key that is equal to the TableSplit end key is added to
> calculateRebalancedSplits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265005#comment-15265005 ] Ted Yu commented on HBASE-15357: With patch for branch-1, TestTableInputFormatScan1#testGetSplitsPoint currently fails. > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Fix For: 2.0.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[
https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264961#comment-15264961
]
Hadoop QA commented on HBASE-15357:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
52s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
38s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m
40s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 103m 41s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 135m 1s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12801529/15357.v2.txt |
| JIRA Issue | HBASE-15357 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
|
| git revision | master / 730b077 |
| Default Java | 1.7.0_79 |
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238013#comment-15238013 ] Ted Yu commented on HBASE-15357: Can you re-attach patch for another QA run ? > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Attachments: HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204484#comment-15204484 ] Nathan Schile commented on HBASE-15357: --- What is the next step for this JIRA? Thanks. > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Attachments: HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[
https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173160#comment-15173160
]
Nathan Schile commented on HBASE-15357:
---
For reference the current code returns a split point of -4, when the split
point should be 124.
{code}
byte[] start = { 120 }; // 'x'
byte[] end = { -128 }; // '€'
byte[] splitPoint = { -4 };
{code}
> TableInputFormatBase getSplitKey does not handle signed bytes correctly
> ---
>
> Key: HBASE-15357
> URL: https://issues.apache.org/jira/browse/HBASE-15357
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
>Reporter: Nathan Schile
>Assignee: Nathan Schile
> Attachments: HBASE-15357.patch
>
>
> When auto-balance is enabled in TableInputFormatBase and the table key is a
> binary key, the getSplitKey method does not function correctly for signed
> bytes. The proposed solution it to utilize
> org.apache.hadoop.hbase.util.Bytes#split method to find the split key.
> org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive
> operation, so if another solution is preferred, that is fine. In addition,
> handling of a split key that is equal to the TableSplit end key is added to
> calculateRebalancedSplits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[
https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171584#comment-15171584
]
Hadoop QA commented on HBASE-15357:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
2s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
33s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 21s
{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 47s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 53s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 3s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 112m 1s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 88m 51s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 250m 10s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_72 Failed junit tests |
hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController |
| | hadoop.hbase.client.TestBlockEvictionFromClient |
| JDK v1.7.0_95 Timed out junit tests |
org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver |
| | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.mapreduce.TestRowCounter |
[jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
[ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171400#comment-15171400 ] Nathan Schile commented on HBASE-15357: --- Review board: https://reviews.apache.org/r/44155/diff/1#index_header > TableInputFormatBase getSplitKey does not handle signed bytes correctly > --- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce >Reporter: Nathan Schile >Assignee: Nathan Schile > Attachments: HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a > binary key, the getSplitKey method does not function correctly for signed > bytes. The proposed solution it to utilize > org.apache.hadoop.hbase.util.Bytes#split method to find the split key. > org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive > operation, so if another solution is preferred, that is fine. In addition, > handling of a split key that is equal to the TableSplit end key is added to > calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
