[jira] [Commented] (HBASE-16418) Reduce duration of sleep waiting for region reopen in IntegrationTestBulkLoad#installSlowingCoproc()
[
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422138#comment-15422138
]
Hudson commented on HBASE-16418:
FAILURE: Integrated in Jenkins build HBase-1.4 #352 (See
[https://builds.apache.org/job/HBase-1.4/352/])
HBASE-16418 Reduce duration of sleep waiting for region reopen in (tedyu: rev
8d93b62f0402dabc77bf2cfaf7f12a6b17bf4155)
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestBulkLoad.java
> Reduce duration of sleep waiting for region reopen in
> IntegrationTestBulkLoad#installSlowingCoproc()
>
>
> Key: HBASE-16418
> URL: https://issues.apache.org/jira/browse/HBASE-16418
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 16418.v1.txt
>
>
> Currently we have the following code:
> {code}
> desc.addCoprocessor(SlowMeCoproScanOperations.class.getName());
> HBaseTestingUtility.modifyTableSync(admin, desc);
> //sleep for sometime. Hope is that the regions are closed/opened before
> //the sleep returns. TODO: do this better
> Thread.sleep(3);
> {code}
> Instead of sleeping for fixed duration, we should detect when the regions
> have reopened with custom Coprocessor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16418) Reduce duration of sleep waiting for region reopen in IntegrationTestBulkLoad#installSlowingCoproc()
[
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422075#comment-15422075
]
Hudson commented on HBASE-16418:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1422 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/1422/])
HBASE-16418 Reduce duration of sleep waiting for region reopen in (tedyu: rev
d5080e82fb47b5499b72fbafbbc52f4f432622d3)
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestBulkLoad.java
> Reduce duration of sleep waiting for region reopen in
> IntegrationTestBulkLoad#installSlowingCoproc()
>
>
> Key: HBASE-16418
> URL: https://issues.apache.org/jira/browse/HBASE-16418
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 16418.v1.txt
>
>
> Currently we have the following code:
> {code}
> desc.addCoprocessor(SlowMeCoproScanOperations.class.getName());
> HBaseTestingUtility.modifyTableSync(admin, desc);
> //sleep for sometime. Hope is that the regions are closed/opened before
> //the sleep returns. TODO: do this better
> Thread.sleep(3);
> {code}
> Instead of sleeping for fixed duration, we should detect when the regions
> have reopened with custom Coprocessor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16418) Reduce duration of sleep waiting for region reopen in IntegrationTestBulkLoad#installSlowingCoproc()
[
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421920#comment-15421920
]
Hadoop QA commented on HBASE-16418:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 30m 57s
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 1s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.3.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 0s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s
{color} | {color:green} master passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 6s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 18s
{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 3s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.0 Server=1.12.0 Image:yetus/hbase:date2016-08-15 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12823772/16418.v1.txt |
| JIRA Issue | HBASE-16418 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux e695ace707ad 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build
[jira] [Commented] (HBASE-16418) Reduce duration of sleep waiting for region reopen in IntegrationTestBulkLoad#installSlowingCoproc()
[
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421897#comment-15421897
]
Ted Yu commented on HBASE-16418:
This JIRA targets 1.x branches.
> Reduce duration of sleep waiting for region reopen in
> IntegrationTestBulkLoad#installSlowingCoproc()
>
>
> Key: HBASE-16418
> URL: https://issues.apache.org/jira/browse/HBASE-16418
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 16418.v1.txt
>
>
> Currently we have the following code:
> {code}
> desc.addCoprocessor(SlowMeCoproScanOperations.class.getName());
> HBaseTestingUtility.modifyTableSync(admin, desc);
> //sleep for sometime. Hope is that the regions are closed/opened before
> //the sleep returns. TODO: do this better
> Thread.sleep(3);
> {code}
> Instead of sleeping for fixed duration, we should detect when the regions
> have reopened with custom Coprocessor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16418) Reduce duration of sleep waiting for region reopen in IntegrationTestBulkLoad#installSlowingCoproc()
[
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421817#comment-15421817
]
Stephen Yuan Jiang commented on HBASE-16418:
Agree, the wait in IntegrationTestBulkLoad is unnecessary. The patch to remove
unnecessary sleep looks good.
Also in master branch, the Admin.modifyTable returns Future, we could use get()
to simplify the logic in HBaseTestingUtility.modifyTableSync().
> Reduce duration of sleep waiting for region reopen in
> IntegrationTestBulkLoad#installSlowingCoproc()
>
>
> Key: HBASE-16418
> URL: https://issues.apache.org/jira/browse/HBASE-16418
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 16418.v1.txt
>
>
> Currently we have the following code:
> {code}
> desc.addCoprocessor(SlowMeCoproScanOperations.class.getName());
> HBaseTestingUtility.modifyTableSync(admin, desc);
> //sleep for sometime. Hope is that the regions are closed/opened before
> //the sleep returns. TODO: do this better
> Thread.sleep(3);
> {code}
> Instead of sleeping for fixed duration, we should detect when the regions
> have reopened with custom Coprocessor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16418) Reduce duration of sleep waiting for region reopen in IntegrationTestBulkLoad#installSlowingCoproc()
[
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421805#comment-15421805
]
Ted Yu commented on HBASE-16418:
{code}
Thread.sleep(1 * 1000l);
} else {
LOG.debug("All regions updated.");
break;
}
} while (status.getFirst() != 0 && i++ < 500);
{code}
modifyTableSync() already waits 500 seconds at maximum.
Looks like the extra wait in IntegrationTestBulkLoad is not necessary.
> Reduce duration of sleep waiting for region reopen in
> IntegrationTestBulkLoad#installSlowingCoproc()
>
>
> Key: HBASE-16418
> URL: https://issues.apache.org/jira/browse/HBASE-16418
> Project: HBase
> Issue Type: Test
>Reporter: Ted Yu
>Priority: Minor
>
> Currently we have the following code:
> {code}
> desc.addCoprocessor(SlowMeCoproScanOperations.class.getName());
> HBaseTestingUtility.modifyTableSync(admin, desc);
> //sleep for sometime. Hope is that the regions are closed/opened before
> //the sleep returns. TODO: do this better
> Thread.sleep(3);
> {code}
> Instead of sleeping for fixed duration, we should detect when the regions
> have reopened with custom Coprocessor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
