[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500181#comment-15500181 ] Yu Li commented on HBASE-16626: --- Thanks all for review [~tedyu], [~anoop.hbase], [~ram_krish], [~chenheng], [~stack], and thanks [~anoop.hbase] for help commit this. > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 2.0.0 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500183#comment-15500183 ] Charlie Qiangeng Xu commented on HBASE-16626: - First patch in community! Thank you Anoop and all others, you guys are very supportive and responsive :) > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 2.0.0 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495546#comment-15495546 ] Anoop Sam John commented on HBASE-16626: It was because of some old force push.. Now I changed my git local commit repo.. Hope it wont come with later commits from me. Sorry for this > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 2.0.0 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493674#comment-15493674 ] Hudson commented on HBASE-16626: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1606 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1606/]) HBASE-16626 User customized RegionScanner from 1.X is incompatible with (anoopsamjohn: rev 56be3ac7c8d203710f844cd799f2fa3496f0515a) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 2.0.0 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[
https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493223#comment-15493223
]
Heng Chen commented on HBASE-16626:
---
{code}
commit 56be3ac7c8d203710f844cd799f2fa3496f0515a
Author: anoopsamjohn
Date: Thu Sep 15 18:07:43 2016 +0530
HBASE-16626 User customized RegionScanner from 1.X is incompatible with
2.0.0's off-heap part. (Charlie Qiangeng Xu)
commit e6f8f6dbd0f7e801fd0fbafbe8cb35492bf08285
Merge: 156a8b2 1d6c90b
Author: anoopsamjohn
Date: Thu Sep 15 18:07:12 2016 +0530
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/hbase
{code}
There is one merge action log in git log, is it OK? [~anoop.hbase]
> User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap
> part
> -
>
> Key: HBASE-16626
> URL: https://issues.apache.org/jira/browse/HBASE-16626
> Project: HBase
> Issue Type: Sub-task
> Components: Offheaping
>Affects Versions: 2.0.0
>Reporter: Charlie Qiangeng Xu
>Assignee: Charlie Qiangeng Xu
> Fix For: 2.0.0
>
> Attachments: HBASE-16626-v1.patch
>
>
> Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a
> new interface Shipper which contains a "shipped()" method.
> In our case, some application user defined customized scanner that implements
> Interface RegionScanner in 1.X .
> After we back ported the Off Heap feature of 2.0.0,
> RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when
> executing scanner.shipped(). It is because the customized scanner didn't
> override the shipped method yet.
> Instead of forcing every user to add a empty implementation(if they don't
> really need to scan the file or the RS don't use L2 cache, they don't need to
> do anything in shipped method) , adding a default method of shipped in
> Interface RegionScanner might be a better way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493023#comment-15493023 ] binlijin commented on HBASE-16626: -- +1 > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[
https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489703#comment-15489703
]
Hadoop QA commented on HBASE-16626:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
44s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 21s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 4s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 46s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 134m 1s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient |
| | org.apache.hadoop.hbase.client.TestMetaWithReplicas |
| | org.apache.hadoop.hbase.client.TestEnableTable |
| | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12828384/HBASE-16626-v1.patch |
| JIRA Issue | HBASE-16626 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 0f5e9d3f7ceb 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 4c6a98b |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/3543/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/3543/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/3543/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489468#comment-15489468 ] ramkrishna.s.vasudevan commented on HBASE-16626: +1. I think it is a jdk8 feature to add a defualt method in an interface. Nice. > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489454#comment-15489454 ] Anoop Sam John commented on HBASE-16626: +1 > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > Attachments: HBASE-16626-v1.patch > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489371#comment-15489371 ] Anoop Sam John commented on HBASE-16626: Other interfaces extending Shipper are marked Private. +1 to add default impl in RegionScanner alone. > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489260#comment-15489260 ] Charlie Qiangeng Xu commented on HBASE-16626: - Thank you [~tedyu] for adding me! Just added a empty implementation default method in Interface RegionScanner. Or maybe should I add this to Interface Shipper so that the patch could cover more sub scanner interfaces? One concern would be, if added to Interface Shipper, the user extending e.g. Interface KeyValueScanner(one that also extends Shipper) might forget to create their shipped function to invoke returnBlockToCache. Any thought [~anoop.hbase]? > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu >Assignee: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488205#comment-15488205 ] Ted Yu commented on HBASE-16626: Added Charlie as contributor. > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488200#comment-15488200 ] Yu Li commented on HBASE-16626: --- [~stack], [~busbey], [~tedyu], [~xharlie] is my workmate and could you help add him into the contributor list, so he could assign this JIRA to himself? Many thanks. > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488196#comment-15488196 ] Yu Li commented on HBASE-16626: --- We also encountered HBASE-16609, and I guess more will expose if there's any since we already start A/B testing for the offheap backpoted version, JFYI. > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488180#comment-15488180 ] Yu Li commented on HBASE-16626: --- For branch-1 it's a little bit awkward, since for jdk7 or lower we have to change RegionScanner to abstract class to add a default behavior, which also requires customer code to change (implements RegionScanner -> extends RegionScanner)... So we decided to change the customer coprocessor code directly (and luckily our customer accept this way)... Just to make it clear to others, for branch-1 the problem only exists after we did a backport of the read-path offheap work, no need to worry if using official released versions. :-) > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487589#comment-15487589 ] stack commented on HBASE-16626: --- Yes. Master is jdk8 so you could make use of the new language feature in master. What will you do for branch 1.x? > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16626) User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap part
[ https://issues.apache.org/jira/browse/HBASE-16626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487290#comment-15487290 ] Anoop Sam John commented on HBASE-16626: bq.adding a default method of shipped in Interface RegionScanner might be a better way. +1 > User customized RegionScanner from 1.X is incompatible with 2.0.0's off-heap > part > - > > Key: HBASE-16626 > URL: https://issues.apache.org/jira/browse/HBASE-16626 > Project: HBase > Issue Type: Sub-task > Components: Offheaping >Affects Versions: 1.2.2, 1.1.6 >Reporter: Charlie Qiangeng Xu > Fix For: 2.0.0 > > > Introduced by 2.0.0's off-heap feature, the interface RegionScanner extends a > new interface Shipper which contains a "shipped()" method. > In our case, some application user defined customized scanner that implements > Interface RegionScanner in 1.X . > After we back ported the Off Heap feature of 2.0.0, > RegionScannerShippedCallBack throws a "java.lang.AbstractMethodError" when > executing scanner.shipped(). It is because the customized scanner didn't > override the shipped method yet. > Instead of forcing every user to add a empty implementation(if they don't > really need to scan the file or the RS don't use L2 cache, they don't need to > do anything in shipped method) , adding a default method of shipped in > Interface RegionScanner might be a better way. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
