[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-13 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822510#comment-15822510
 ] 

Enis Soztutar commented on HBASE-17315:
---

bq. the test failed for me
This was caused by HBASE-17463. Now the test runs successfully. 

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch, 
> HBASE-17315.HBASE-14850.v6.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-11 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819797#comment-15819797
 ] 

Enis Soztutar commented on HBASE-17315:
---

[~sudeeps] the test failed for me on top of HBASE-17451, did you run it? 

{code}
TESTING ALL TESTS
PASS<100ms  2 Passed   0 Skipped   0 Failed   
//connection:connection-pool-test
PASS<100ms  3 Passed   0 Skipped   0 Failed   
//serde:client-deserializer-test
PASS<100ms  4 Passed   0 Skipped   0 Failed   //serde:client-serializer-test
PASS<100ms  1 Passed   0 Skipped   0 Failed   
//serde:region-info-deserializer-test
PASS<100ms  4 Passed   0 Skipped   0 Failed   //serde:server-name-test
PASS<100ms  3 Passed   0 Skipped   0 Failed   //serde:table-name-test
PASS<100ms  3 Passed   0 Skipped   0 Failed   //serde:zk-deserializer-test
PASS<100ms  1 Passed   0 Skipped   0 Failed   //utils:user-util-test
PASS<100ms  7 Passed   0 Skipped   0 Failed   //core:cell-test
[Fatal Error] :1:1: Premature end of file.
FAIL<100ms  0 Passed   0 Skipped   1 Failed   //core:client-test
FAILURE //core:client-test main: test program aborted before finishing

STANDARD OUT
Running main() from gmock_main.cc
[==] Running 6 tests from 1 test case.
[--] Global test environment set-up.
[--] 6 tests from Client
[ RUN  ] Client.EmptyConfigurationPassedToClient
WARNING: Logging before InitGoogleLogging() is written to STDERR
E0112 01:17:27.853519   546 client.cc:43] Empty Configuration object passed to 
Client.
[   OK ] Client.EmptyConfigurationPassedToClient (4 ms)
[ RUN  ] Client.ConfigurationPassedToClient
2017-01-12 01:17:27,855:546(0x7f8427701800):ZOO_INFO@log_env@726: Client 
environment:zookeeper.version=zookeeper C client 3.4.8
2017-01-12 01:17:27,855:546(0x7f8427701800):ZOO_INFO@log_env@730: Client 
environment:host.name=7212e6c54514
2017-01-12 01:17:27,855:546(0x7f8427701800):ZOO_INFO@log_env@737: Client 
environment:os.name=Linux
2017-01-12 01:17:27,855:546(0x7f8427701800):ZOO_INFO@log_env@738: Client 
environment:os.arch=3.10.0-514.2.2.el7.x86_64
2017-01-12 01:17:27,855:546(0x7f8427701800):ZOO_INFO@log_env@739: Client 
environment:os.version=#1 SMP Tue Dec 6 23:06:41 UTC 2016
2017-01-12 01:17:27,855:546(0x7f8427701800):ZOO_INFO@log_env@747: Client 
environment:user.name=(null)
2017-01-12 01:17:27,856:546(0x7f8427701800):ZOO_INFO@log_env@755: Client 
environment:user.home=/root
2017-01-12 01:17:27,856:546(0x7f8427701800):ZOO_INFO@log_env@767: Client 
environment:user.dir=/usr/src/hbase/hbase-native-client
2017-01-12 01:17:27,856:546(0x7f8427701800):ZOO_INFO@zookeeper_init@800: 
Initiating client connection, host=localhost:2181 sessionTimeout=1000 
watcher=(nil) sessionId=0 sessionPasswd= context=(nil) flags=0
2017-01-12 
01:17:27,857:546(0x7f842080d700):ZOO_ERROR@handle_socket_error_msg@1722: Socket 
[::1:2181] zk retcode=-4, errno=111(Connection refused): server refused to 
accept the client
2017-01-12 
01:17:27,857:546(0x7f842080d700):ZOO_ERROR@handle_socket_error_msg@1722: Socket 
[127.0.0.1:2181] zk retcode=-4, errno=111(Connection refused): server refused 
to accept the client
2017-01-12 01:17:27,871:546(0x7f8427701800):ZOO_INFO@zookeeper_close@2543: 
Freeing zookeeper resources for sessionId=0

I0112 01:17:27.871677   546 location-cache.cc:73] Closed connection to 
ZooKeeper.
[   OK ] Client.ConfigurationPassedToClient (17 ms)
[ RUN  ] Client.DefaultConfiguration
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@726: Client 
environment:zookeeper.version=zookeeper C client 3.4.8
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@730: Client 
environment:host.name=7212e6c54514
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@737: Client 
environment:os.name=Linux
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@738: Client 
environment:os.arch=3.10.0-514.2.2.el7.x86_64
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@739: Client 
environment:os.version=#1 SMP Tue Dec 6 23:06:41 UTC 2016
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@747: Client 
environment:user.name=(null)
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@755: Client 
environment:user.home=/root
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@log_env@767: Client 
environment:user.dir=/usr/src/hbase/hbase-native-client
2017-01-12 01:17:27,872:546(0x7f8427701800):ZOO_INFO@zookeeper_init@800: 
Initiating client connection, host=localhost:2181 sessionTimeout=1000 
watcher=(nil) sessionId=0 sessionPasswd= context=(nil) flags=0
2017-01-12 
01:17:27,873:546(0x7f8424759700):ZOO_ERROR@handle_socket_error_msg@1722: Socket 
[127.0.0.1:2181] zk retcode=-4, errno=111(Connection refused): server refused 
to accept the client
2017-01-12 
01:17:27,873:546(0x7f8424759700):ZOO_ERROR@handle_socket_error_msg@1722: Socket 
[::1:2181] zk retcode=-4,

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818187#comment-15818187
 ] 

Hadoop QA commented on HBASE-17315:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color} 
| {color:red} HBASE-17315 does not apply to HBASE-14850. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12846815/HBASE-17315.HBASE-14850.v6.patch
 |
| JIRA Issue | HBASE-17315 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5236/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch, 
> HBASE-17315.HBASE-14850.v6.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-09 Thread Sudeep Sunthankar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813759#comment-15813759
 ] 

Sudeep Sunthankar commented on HBASE-17315:
---

Thanks [~enis]

{quote}
{code}
hbase::TestUtil *test_util = new hbase::TestUtil();
..
+  delete test_util;
{code}
{quote}
There was a feedback in one of the earlier issues, not to include smart 
pointers in test cases, hence I refrained from it.

{quote}
{code}
 // ASSERT_TRUE(table != nullptr) << "Unable to get connection to Table.";
{code}
{quote}
Since we moved, it from unique_ptr to return by value, I had commented out the 
part. 
I will be uncomment it in the next patch and also include changes for 
RequestConverter and ResponseConverter classes.

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-09 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813544#comment-15813544
 ] 

Enis Soztutar commented on HBASE-17315:
---

Thanks Sudeep for the updated patch. 

No need for optional here: 
{code}
+  std::shared_ptr conf_;
{code}

Change these two to false for now (since they won't be implemented in the 
initial cut): 
{code}
+  pb_msg->set_client_handles_partials(true);
+  pb_msg->set_client_handles_heartbeats(true);
{code}

Maybe move this class
{code}
/hbase-native-client/core/protobuf_request_builder.cc 
{code}
to the {{serde}} directory and name it request-converter. Also extract out this 
logic: 
{code}
+  for (auto cell : get_resp->result().cell()) {
+std::shared_ptr pcell =
+std::make_shared(cell.row(), cell.family(), cell.qualifier(), 
cell.timestamp(),
+   cell.value(), 
static_cast(cell.cell_type()));
+vcells.push_back(pcell);
+  }
+
+  hbase::Result result(vcells, get_resp->result().exists(), 
get_resp->result().stale(),
+   get_resp->result().partial());
{code}
into a class called response-converter. 

Also we have discussed internally that retuning via unique_ptr's is better for 
Table::Get() and Client::Table methods for now. We can always revisit later.  

Why this? 
{code}
hbase::TestUtil *test_util = new hbase::TestUtil();
..
+  delete test_util;
{code}
Why not unique_ptr, and release()? 

Looking at the way you use configuration for tests, maybe we should do 
Conf.set(), etc methods, and maybe do a TestConfigurationLoader or something 
which is not XML-file based. This way it will be much easier for future tests. 
We can do this in a later patch though, no need to change this now. 

Did you want to enable this assertion? 
{code}
+  // ASSERT_TRUE(table != nullptr) << "Unable to get connection to Table.";
{code}

Otherwise looks pretty good. 

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-09 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810997#comment-15810997
 ] 

Hadoop QA commented on HBASE-17315:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 8s 
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} HBASE-14850 passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} HBASE-14850 passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
2s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
4s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 13s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
3s {color} | {color:green} the patch passed {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 1s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2017-01-09 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12846271/HBASE-17315.HBASE-14850.v5.patch
 |
| JIRA Issue | HBASE-17315 |
| Optional Tests |  shellcheck  shelldocs  cc  compile  |
| uname | Linux 03df465a90f0 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 
10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-14850 / 50bcb9f |
| shellcheck | v0.4.5 |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5195/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-06 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806215#comment-15806215
 ] 

Enis Soztutar commented on HBASE-17315:
---

Forgot to mention this: 
{code}
+  if (get.Timerange().IsAllTime()) {
{code} 
is this supposed to be a !. Maybe remove this if altogether? 
 

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-06 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805752#comment-15805752
 ] 

Enis Soztutar commented on HBASE-17315:
---

A typo here: 
{code}
- * Licensed to the Apache Software Foundation (ASF) under one
+ w * Licensed to the Apache Software Foundation (ASF) under one
{code}

For both of these constructors: 
{code}
+Client::Client(const std::string _quorum,
+   const std::shared_ptr 
)
{code}

The zk_quorum will be read from the Configuration. No need for applications to 
pass it anymore. So this: 
{code}
auto zk_quorum =
+  (conf) ? conf->Get("hbase.zookeeper.quorum", "localhost:2181")
{code} 
should happen internally within the LocationCache, or Client. Plus, the 
{{hbase.zookeeper.quorum}} should be extracted as a constant somewhere. 

You should not have a shared_ptr to an optional value like this: 
{code}
+  std::shared_ptr conf_ =
{code}
The configuration parser returns an optional, but for our purposes, if the 
configuration cannot be parsed from optional, then the Client should raise an 
error back.  

For these (and maybe others): 
{code}
std::unique_ptr Table::Get(const hbase::Get )
std::unique_ptr Table(const TableName _name);
{code}

Why are we returning via unique_ptr? Isnt' move semantics automatically kick in 
via optimization when we return by value? 

Remove this:
{code}
+  // client_->Close();
{code}

Why are we catching exception, and returning nullptr? 
{code}
+  catch (const std::runtime_error ) {
+LOG(ERROR) << "Caught exception while performing Table::Get() :-" << 
rex.what();
+return nullptr;
+  }
{code} 
we should raise the exception, back to the application. 


> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-05 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803355#comment-15803355
 ] 

Hadoop QA commented on HBASE-17315:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 8s 
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} HBASE-14850 passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} HBASE-14850 passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
5s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
25m 5s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
3s {color} | {color:green} the patch passed {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 45s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:date2017-01-06 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12845925/HBASE-17315.HBASE-14850.v4.patch
 |
| JIRA Issue | HBASE-17315 |
| Optional Tests |  shellcheck  shelldocs  cc  compile  |
| uname | Linux 9e8c883f56d4 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-14850 / 50bcb9f |
| shellcheck | v0.4.5 |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5155/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-04 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799911#comment-15799911
 ] 

Enis Soztutar commented on HBASE-17315:
---

bq. I suppose we would also require a Configuration instance in the Table 
class. Should we pass along a Configuration instance from the Client class 
during construction of Table or instantiate a new one in Table itself.
We should pass the Configuration from the Client to the Table. Parsing 
configuration from the XML file is costly, we should do that only once. 

The Client should have constructors with or without Configuration being passed. 
If not passed, the Client can use HBaseConfigurationLoader to load the default 
configuration. 


> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-04 Thread Sudeep Sunthankar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799895#comment-15799895
 ] 

Sudeep Sunthankar commented on HBASE-17315:
---

Thanks for the review [~enis]. Going ahead, I suppose we would also require a 
Configuration instance in the Table class. Should we pass along a Configuration 
instance from the Client class during construction of Table  or instantiate a 
new one in Table itself.

Thanks

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-03 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796993#comment-15796993
 ] 

Enis Soztutar commented on HBASE-17315:
---

Thanks Sudeep for the updated patch. 

Is it possible to cut this patch in half so that it is easier to commit this 
sooner. Let's leave the ResultScanner and all scan related functionality out of 
this patch, and focus on the Table and Client changes. Table can only contain 
Get() and Close() methods. Let's do the ResultScanner changes as a different 
patch. 

A couple of comments: 
 - no need for {{cleanup_connection_on_close_}}. This is from a different era 
in the Java land. 
 - Instead of these: 
{code}
+  const std::shared_ptr () const;
+  const std::shared_ptr () const;
{code}
pass them to the Table at construction time. 
 - Client::GetTable() should be named Client::Table() 
 - Is this right? 
{code}
+  client_.reset(new Client(*table.client_));
{code}
 - You can remove this
{{TODO check if consistency is STRONG or TIMELINE and fire Get() accordingly}} 

> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794145#comment-15794145
 ] 

Hadoop QA commented on HBASE-17315:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 7s 
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} HBASE-14850 passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} HBASE-14850 passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 2s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
4s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 17m 23s 
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 19m 50s 
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 22m 16s 
{color} | {color:red} Patch causes 11 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 24m 44s 
{color} | {color:red} Patch causes 11 errors with Hadoop v2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
3s {color} | {color:green} the patch passed {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 22s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:date2017-01-03 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12845320/HBASE-17315.HBASE-14850.v3.patch
 |
| JIRA Issue | HBASE-17315 |
| Optional Tests |  shellcheck  shelldocs  cc  compile  |
| uname | Linux ee9144ec05f8 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-14850 / f29860f |
| shellcheck | v0.4.5 |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5119/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-17315) [C++] HBase Client and Table Implementation

2017-01-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793762#comment-15793762
 ] 

Hadoop QA commented on HBASE-17315:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m 7s 
{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 2s 
{color} | {color:green} HBASE-14850 passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} HBASE-14850 passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
2s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed with JDK v1.8.0_111 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed with JDK v1.7.0_121 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 1s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
4s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
27m 6s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 
3s {color} | {color:green} the patch passed {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 43s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2017-01-02 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12845272/HBASE-17315.HBASE-14850.v2.patch
 |
| JIRA Issue | HBASE-17315 |
| Optional Tests |  shellcheck  shelldocs  cc  compile  |
| uname | Linux 61a91d88625a 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 
10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-14850 / f29860f |
| shellcheck | v0.4.5 |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/5118/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> [C++] HBase Client and Table Implementation
> ---
>
> Key: HBASE-17315
> URL: https://issues.apache.org/jira/browse/HBASE-17315
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sudeep Sunthankar
>Assignee: Sudeep Sunthankar
> Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)