[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763969#comment-15763969 ] Hudson commented on HBASE-17333: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2165 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2165/]) HBASE-17333 HBASE-17294 always ensures CompactingMemstore is default (ramkrishna: rev db5953c6fec74b044e01525273c7d107a51720b9) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763317#comment-15763317 ] ramkrishna.s.vasudevan commented on HBASE-17333: Pushed to master. Thanks for the discussion here. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763303#comment-15763303 ] ramkrishna.s.vasudevan commented on HBASE-17333: So I will go ahead and commit this patch. Will raise a new JIRA and leave it for either [~anastas] or [~eshcar] to take it up so that Compacting Memstore in BASIC mode becomes the default. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763186#comment-15763186 ] Anoop Sam John commented on HBASE-17333: DD As Stack said.. IMO also we should do BASIC as the default (So go with Compacting Memstore as the default) for 2.0 release. Only issue was this was not done clearly in a separate jira but done as a side effect of another issue which was not in any way telling this. (Either via the title or description) So as of now we will do that jira HBASE-17294 but with NONE as default type. And will raise another one to make BASIC the default. That will make sure get more attention and devs can raise concerns/Suggestions if any under that. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762253#comment-15762253 ] stack commented on HBASE-17333: --- [~anastas] Yes. You do. Turning it off for now and then filing an issue to turn it on with a clear subject so we loud about what we are doing. Will need to fix any issues (and alleviate any concerns -- e.g. the above ask for perf data by [~devaraj] -- in mean time. Thanks. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762229#comment-15762229 ] Anastasia Braginsky commented on HBASE-17333: - I am not sure what is the final suggestion here. Is it just to change one line in the CompactingMemStore.java? Meaning to set the COMPACTING_MEMSTORE_TYPE_DEFAULT to NONE (?) And we will turn it back when all the tests are going to be clear with the BASIC setting? Do I see the picture clear? > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762167#comment-15762167 ] stack commented on HBASE-17333: --- [~devaraj] BASIC was default. Suggest you ask question about perf to get @eshcar input on HBASE-17294. On doc., yeah, there is a lag. Will be addressed. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762082#comment-15762082 ] Devaraj Das commented on HBASE-17333: - Guys, wondering if we have perf tests that prove BASIC is performant/beneficial in all cases (as release-noted in HBASE-17294). If so, why isn't that the default. Also, this doc https://docs.google.com/document/d/10k4hqi4mCCpVrPodp1Q4rV0XsZ4TZtULOa-FOoe-_hw/edit should be brought up to date w.r.t the developments happening. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761992#comment-15761992 ] stack commented on HBASE-17333: --- +1 on patch and +1 on [~anoop.hbase] suggestion above. Thanks [~ram_krish] > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761921#comment-15761921 ] Anoop Sam John commented on HBASE-17333: +1 Pls raise another issue to change the default to be basic so that default memstore is changed to be compacting memstore. [~anastas] / [~eshcar] > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch, > HBASE-17333_2.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761896#comment-15761896 ] ramkrishna.s.vasudevan commented on HBASE-17333: Ok fine. Will change it accordingly then. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761868#comment-15761868 ] stack commented on HBASE-17333: --- All reasonable. Can we just set the default to NONE? > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761854#comment-15761854 ] ramkrishna.s.vasudevan commented on HBASE-17333: See my description. I was actually not sure on the purpose of that HBASE-17294. Ya I agree that first we commit the change in such a way that we ensure all tests pass. Later we make check the bug that occurs due to HBASE-17294 and fix it up. And my other request would be that - as part of HBASE-17294 what ever test was added to work with NONE - should just keep working without adding any change. That would ensure we are fine with all cases. And it ensures that we have moved over to Compacting MS. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761708#comment-15761708 ] Anoop Sam John commented on HBASE-17333: HBASE-17294 was about external configs for compacting memstore. It was not at all saying it clear that we change the default memstore to be compacting one.. So IMHO we can do the change of default impl change as part of another issue. This issue is abt reverting that single liner which makes def memstore as CompactingMS. So that tests can pass again. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15761697#comment-15761697 ] stack commented on HBASE-17333: --- Lads, we want inmemory compaction as default unless it broken or causes performance regression? Do we want to give this issue a clearer title; "Make inmemory compaction default in 2.0" so it gathers attention? Thanks. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[
https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760650#comment-15760650
]
Hadoop QA commented on HBASE-17333:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 34s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
40s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 35s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
25m 16s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
48s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 11s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 129m 16s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12843813/HBASE-17333_1.patch |
| JIRA Issue | HBASE-17333 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux e0b951f3babc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d53f012 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/4975/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/4975/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/4975/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> HBASE-17294 always ensures CompactingMemstore is default
>
>
> Key: HBASE-17333
> URL: https://issues.apache.org/jira/browse/HBASE-17333
> Project:
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[
https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760565#comment-15760565
]
Hadoop QA commented on HBASE-17333:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
47s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 32s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 92m 35s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 131m 21s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12843804/HBASE-17333.patch |
| JIRA Issue | HBASE-17333 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 0a308d480511 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d53f012 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/4974/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/4974/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/4974/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/4974/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
>
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760421#comment-15760421 ] ramkrishna.s.vasudevan commented on HBASE-17333: bq.The way to enable compacting Memstore now is to config the type as basic/eager. I still feel if there is CompactingMemstore (and one needs it) then it should be either Basic/Eager and one among this should be default. So having default type as NONE is not right in this context. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760402#comment-15760402 ] Anoop Sam John commented on HBASE-17333: bq.COMPACTING_MEMSTORE_ENABLED = "hbase.hregion.compacting.memstore"; Why new config? I think in other issue, Eschar removed other configs and tuning points and went with single type config.. Now why we need this? The way to enable compacting Memstore now is to config the type as basic/eager. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch, HBASE-17333_1.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760366#comment-15760366 ] Anoop Sam John commented on HBASE-17333: Same.. Ya when HCD level is null, we go with conf read and then we go with BASIC as default now.. We must change it to be NONE. Single line change only. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760357#comment-15760357 ] ramkrishna.s.vasudevan commented on HBASE-17333: Oh I got the problem with the patch. Am checking for != null and if so again getting from conf. I should rather honour that. Only if null then take it as NONe. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760348#comment-15760348 ] Anoop Sam John commented on HBASE-17333: When at conf level we have say Basic and CF level we have eager (use HCD setter) what should be used? As CF level it is given, we should go with eager. With this patch it is possible? > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760346#comment-15760346 ] ramkrishna.s.vasudevan commented on HBASE-17333: And my other suggestion would be to remove the NONE from the MemoryCompaction ENUM. So if there is an inmemory flush then the default is BASIC. > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-17333.patch > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[
https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760339#comment-15760339
]
ramkrishna.s.vasudevan commented on HBASE-17333:
bq.The issue is this. When read from conf, the default to be used as
HColumnDescriptor.MemoryCompaction.NONE
That single change should fix it.
I don't want to change that. Let the default be BASIC only. If there is no HCD
setting then we should ensure we go with default memstore. Since
{code}
public HColumnDescriptor setInMemoryCompaction(MemoryCompaction
inMemoryCompaction) {
{code}
accepts a MemoryCompaciton who ever is using it will be setting
NONE/BASIC/EAGER. There there is no problem. Only when some one is not using it
explicitly we get this problem. So I think the current way in patch is fine.
bq.Or may be after this commit, that can be closed and we can open a new one to
track, why the test fail with CompactingMS feature
Ya we can do that. Raise another JIRA and dig there.
> HBASE-17294 always ensures CompactingMemstore is default
>
>
> Key: HBASE-17333
> URL: https://issues.apache.org/jira/browse/HBASE-17333
> Project: HBase
> Issue Type: Bug
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-17333.patch
>
>
> Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am
> not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA
> is to discuss and revert back to default memstore only if the family is not
> configured for in memory flush/compaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[
https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760303#comment-15760303
]
Anoop Sam John commented on HBASE-17333:
{code}
if (inMemoryCompaction != null) {
246 inMemoryCompaction = HColumnDescriptor.MemoryCompaction
247
.valueOf(conf.get(CompactingMemStore.COMPACTING_MEMSTORE_TYPE_KEY,
248 CompactingMemStore.COMPACTING_MEMSTORE_TYPE_DEFAULT));
{code}
When a type is specified at HCD level, that has to be honored whereas this
patch try to change it to global conf level
The issue is this. When read from conf, the default to be used as
HColumnDescriptor.MemoryCompaction.NONE
That single change should fix it.
Only HBASE-17323 this is the test issue? Or any thing else?
Can change some comments and change the title and description of the jira. Or
may be after this commit, that can be closed and we can open a new one to
track, why the test fail with CompactingMS feature
> HBASE-17294 always ensures CompactingMemstore is default
>
>
> Key: HBASE-17333
> URL: https://issues.apache.org/jira/browse/HBASE-17333
> Project: HBase
> Issue Type: Bug
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-17333.patch
>
>
> Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am
> not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA
> is to discuss and revert back to default memstore only if the family is not
> configured for in memory flush/compaction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-17333) HBASE-17294 always ensures CompactingMemstore is default
[ https://issues.apache.org/jira/browse/HBASE-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760273#comment-15760273 ] Anoop Sam John commented on HBASE-17333: Should not be.. +1 to change it so as to ake DefaultMS as default > HBASE-17294 always ensures CompactingMemstore is default > > > Key: HBASE-17333 > URL: https://issues.apache.org/jira/browse/HBASE-17333 > Project: HBase > Issue Type: Bug >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > > Was the purpose of HBASE-17294 is to make Compacting Memstore as default? Am > not sure on that. But that patch makes DefaultMemstore as a Noop. This JIRA > is to discuss and revert back to default memstore only if the family is not > configured for in memory flush/compaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
