[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990411#comment-15990411 ] Hudson commented on HBASE-17857: ABORTED: Integrated in Jenkins build HBase-HBASE-14614 #190 (See [https://builds.apache.org/job/HBase-HBASE-14614/190/]) HBASE-17857 Remove IS annotations from IA.Public classes (zhangduo: rev a66d491892514fd4a188d6ca87d6260d8ae46184) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaSettingsFactory.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/NullComparator.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Decryptor.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBytesBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/KeepDeletedCells.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/StructIterator.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyProvider.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableBuilder.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/errorhandling/TimeoutException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/security/SecurityCapability.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MutationSerialization.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/TableNotEnabledException.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ScanLabelGenerator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Operation.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ProcedureInfo.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/TableExistsException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/IncompatibleFilterException.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/GroupingTableMapper.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytesTerminated.java * (edit) hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/HBaseContext.scala * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RegexStringComparator.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowMutations.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/SnapshotType.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionLocation.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/KeyValueSortReducer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/UnsupportedCryptoException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/NoServerForRegionException.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaType.java * (edit) hbase-spark/src/main/scala/org/apache/spark/sql/datasources/hbase/HBaseTableCatalog.scala * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/snapshot/UnknownSnapshotException.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/MD5Hash.java * (edit) hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/KeyFamilyQualifier.scala * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/coprocessor/BypassCoprocessorException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/CompactionState.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableMultiplexer.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSplit.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java *
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956739#comment-15956739 ] Hudson commented on HBASE-17857: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2803 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2803/]) HBASE-17857 Remove IS annotations from IA.Public classes (zhangduo: rev a66d491892514fd4a188d6ca87d6260d8ae46184) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Decryptor.java * (edit) hbase-spark/src/main/scala/org/apache/spark/sql/datasources/hbase/HBaseTableCatalog.scala * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/SyncCoprocessorRpcChannel.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedInt16.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlobVar.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableInputFormatBase.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoding.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Response.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/IdentityTableMapper.java * (edit) hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/HBaseDStreamFunctions.scala * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/DroppedSnapshotException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/UnsupportedCellCodecException.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/RawBytes.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedNumeric.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Connection.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormat.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/RowCounter.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnection.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/types/OrderedBlob.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TsvImporterTextMapper.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/snapshot/TablePartiallyOpenException.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMap.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/MD5Hash.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowTooBigException.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Cluster.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/TableCFs.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/MemoryCompactionPolicy.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/TableNotFoundException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaScope.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/TableInfoMissingException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerRunningException.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/KeyValueSerialization.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationException.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReader.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java * (edit)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956440#comment-15956440 ] Duo Zhang commented on HBASE-17857: --- Will commit shortly. > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch, > HBASE-17857-v2.patch, HBASE-17857-v3.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15955270#comment-15955270
]
Hadoop QA commented on HBASE-17857:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
1s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
20s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
51s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 38s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
14s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 2m 37s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
27m 23s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 6s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s
{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 48s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 16s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 105m 11s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 29s
{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 35s
{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 52s
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
36s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 182m 26s
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954713#comment-15954713
]
Duo Zhang commented on HBASE-17857:
---
{quote}
Is it the case that from now on, we will say we will mark unstable new feature
API as IA private intentionally?
{quote}
IMO, yes. Make it public only if we think it is stable enough.
> Remove IS annotations from IA.Public classes
>
>
> Key: HBASE-17857
> URL: https://issues.apache.org/jira/browse/HBASE-17857
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17857.patch, HBASE-17857-v1.patch,
> HBASE-17857-v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954577#comment-15954577 ] Jerry He commented on HBASE-17857: -- Is it the case that from now on, we will say we will mark unstable new feature API as IA private intentionally? > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch, > HBASE-17857-v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953371#comment-15953371 ] Duo Zhang commented on HBASE-17857: --- The AsyncAdmin is still under development so I think it is OK to declare it as IA.Private? And for the backoff stuffs, yeah they have been released out as IA.Public, for two years, still unstable... For AsyncAdmin, if we want to declare it as IA.Public, then HBASE-17359 will be a blocker for 2.0 release... This is what I do not want to see... For the backoff stuffs, my only concern is lack of maintenance. It has been there for two years but still unstable, and seems only be used in AsyncProcess. Anyway, I think it is OK to only remove the IS annotations here and open a new issue to address these two classes. But we need to set the new issue as blocker for 2.0 release. Thanks. > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch, > HBASE-17857-v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952866#comment-15952866 ] Sean Busbey commented on HBASE-17857: - Can we do the removal of InterfaceStability and the changing of some things to IA.Private as two different subtasks? I'd like to review those we're claiming to have as Private now. If they've been in releases already I'll want to argue for them to be declared IA.Public (and implicitly stable). > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch, > HBASE-17857-v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952327#comment-15952327
]
Hadoop QA commented on HBASE-17857:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 24s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
2s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 48s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
0s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 43s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
17s {color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 2m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 9s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 47s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s
{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 52s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 15s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 104m 10s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 32s
{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 34s
{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 49s
{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
36s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 182m 43s {color}
|
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951965#comment-15951965 ] Duo Zhang commented on HBASE-17857: --- [~jerryhe] Thanks for your reminding. Will take a look. > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951959#comment-15951959 ] Jerry He commented on HBASE-17857: -- There are a few scala source files in hbase-spark you may want to include in your script. > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951859#comment-15951859 ] Duo Zhang commented on HBASE-17857: --- Thanks boss [~stack]. Let me reply on the mailing list about the progress to see if there are objections. And also, we need to open another issue to track the IS annotations for IA.LimitedPrivate classes. There are several classes declared as IA.LimitedPrivate but do not have IS annotations. Yeah this is less critical than IA.Public API so we should not let it block the main issue. Thanks. > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951201#comment-15951201
]
Hadoop QA commented on HBASE-17857:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 25s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
31s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 3s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
28s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
24s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 54s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 24s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 24s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 7s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 44s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 10s
{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 8s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 30s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 110m 55s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 3s
{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 37s
{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
23s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 189m 37s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12861445/HBASE-17857-v1.patch |
| JIRA Issue | HBASE-17857 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 5891a8d73df7 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2
15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
|
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951173#comment-15951173 ] stack commented on HBASE-17857: --- Skimmed. +1. Excellent. Nice doc in TestIA thingy class. Thanks. > Remove IS annotations from IA.Public classes > > > Key: HBASE-17857 > URL: https://issues.apache.org/jira/browse/HBASE-17857 > Project: HBase > Issue Type: Sub-task > Components: API >Affects Versions: 2.0.0 >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17857.patch, HBASE-17857-v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950755#comment-15950755
]
Hadoop QA commented on HBASE-17857:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 32s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
50s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 1s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 1s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s
{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 42s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 44s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s
{color} | {color:green} hbase-annotations in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 58s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 7s {color} |
{color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 120m 39s
{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 15s
{color} | {color:green} hbase-endpoint in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 17s
{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
29s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 197m 4s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12861402/HBASE-17857.patch |
| JIRA Issue | HBASE-17857 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux db5e0fcd76af 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950506#comment-15950506
]
Duo Zhang commented on HBASE-17857:
---
And this is the classes which are marked as IA.Public and also IS.Unstable.
{noformat}
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScanResultConsumer.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableRegionLocator.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBase.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/CompactType.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnection.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawScanResultConsumer.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
./hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
./hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AsyncAggregationClient.java
{noformat}
For {{Scan}}, the unstable part is an inner class called ReadType, I think it
is OK to remove the unstable annotation for it.
And for async client related part, I suggest we mark AsyncAdmin related as
IA.Private first and change it to IA.Public when we finish the most works and
it is ready for end user.
For {{CompactType}}, I think we should remove the unstable mark as it is used
in Admin interface which is IA.Public and consisdered to be stable.
And for {{HBaseCommonTestingUtility}}, why Unstable? It is sub class
{{HBaseTestingUtility}} is evolving... Let's just remove it.
And for backoff related classess, Let's make it IA.Private first as it is not
complete and seems there is no progress on it.
Thanks.
> Remove IS annotations from IA.Public classes
>
>
> Key: HBASE-17857
> URL: https://issues.apache.org/jira/browse/HBASE-17857
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HBASE-17857) Remove IS annotations from IA.Public classes
[
https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950476#comment-15950476
]
Duo Zhang commented on HBASE-17857:
---
The script is like this
{noformat}
#!/bin/bash
IS_PUBLIC=`awk '{print $1}' < $1 | grep -s "^@InterfaceAudience.Public"`
if [ ! -n "$IS_PUBLIC" ]; then
# echo "Skipping $1"
exit 1
fi
echo "Processing $1"
grep -v "^[ ]*@InterfaceStability." $1 > /tmp/tmp.java
mv /tmp/tmp.java $1
{noformat}
And executed with
{noformat}
find . -type f -name *.java -exec ./rm_anno.sh {} \;
{noformat}
> Remove IS annotations from IA.Public classes
>
>
> Key: HBASE-17857
> URL: https://issues.apache.org/jira/browse/HBASE-17857
> Project: HBase
> Issue Type: Sub-task
> Components: API
>Affects Versions: 2.0.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
