[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513055#comment-16513055
]
Hadoop QA commented on HBASE-18304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-18304 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12880263/HBASE-18304.master.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13257/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Start enforcing upperbounds on dependencies
> ---
>
> Key: HBASE-18304
> URL: https://issues.apache.org/jira/browse/HBASE-18304
> Project: HBase
> Issue Type: Task
> Components: build, dependencies
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
>Priority: Major
> Labels: beginner
> Attachments: HBASE-18304.master.001.patch,
> HBASE-18304.master.002.patch, HBASE-18304.master.002.patch,
> HBASE-18304.master.003.patch
>
>
> would be nice to get this going before our next major version.
> http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[ https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513039#comment-16513039 ] Mike Drob commented on HBASE-18304: --- I tried to pick this up again and so far I've been running into several dependencies where we don't depend on it at all, but enforcer plugin complains because it turns out hadoop is internally inconsistent (usually between hadoop-client and hadoop-minicluster having transitive dependancies on things). This might be a bug in the enforcer plugin, or we should push hadoop to be cleaner before we start trying to enforce things on our own side. > Start enforcing upperbounds on dependencies > --- > > Key: HBASE-18304 > URL: https://issues.apache.org/jira/browse/HBASE-18304 > Project: HBase > Issue Type: Task > Components: build, dependencies >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Tamas Penzes >Priority: Major > Labels: beginner > Attachments: HBASE-18304.master.001.patch, > HBASE-18304.master.002.patch, HBASE-18304.master.002.patch, > HBASE-18304.master.003.patch > > > would be nice to get this going before our next major version. > http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382574#comment-16382574
]
Hadoop QA commented on HBASE-18304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-18304 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12880263/HBASE-18304.master.003.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11755/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Start enforcing upperbounds on dependencies
> ---
>
> Key: HBASE-18304
> URL: https://issues.apache.org/jira/browse/HBASE-18304
> Project: HBase
> Issue Type: Task
> Components: build, dependencies
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
>Priority: Major
> Labels: beginner
> Attachments: HBASE-18304.master.001.patch,
> HBASE-18304.master.002.patch, HBASE-18304.master.002.patch,
> HBASE-18304.master.003.patch
>
>
> would be nice to get this going before our next major version.
> http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112938#comment-16112938
]
Tamas Penzes commented on HBASE-18304:
--
Hi [~busbey],
Please see my comments inline.
> 1042 com.google.protobuf:protobuf-java
> This is going to be a nightmare due to our purposeful handling of multiple
> versions. But maybe I'm misunderstanding it, since shouldn't our internal use
> of protobuf 3 be masked since we relocate it in third-party-deps?
We do only reference protobuf 3.3.0 in hbase-protocol-shaded now, but it is a
dependency of hbase-client, hbase-procedure and hbase-server. Through the
transitive dependencies it causes conflict in this three module.
If I exclude protobuf from the dependency hbase-protocol-shaded in these three
modules, it looks okay. Is it?
> 1043 org.slf4j:slf4j-log4j12
> This one should be easy to just set to latest.
If I add org.slf4j:slf4j-log4j12:${slf4j.version} to hbase-client as dependency
it solves the problem.
> 1044 com.google.guava:guava
> Maybe solved for us by our move to third-party-deps? Shouldn't only Hadoop's
> show up? or is the conflict in spark or some such? (questions for the
> eventual follow-on JIRA)
Almost solved. org.tachyonproject:tachyon-client uses guava 14.0.1, and is
referenced directly and transitively from org.apache.spark:spark-core_2.10.
Otherwise we only use guava version 11.0.2. If I can exclude it from
spark-core_2.10 transitive dependencies in hbase-spark and hbase-spark-it it
works.
> 1045 com.thoughtworks.paranamer:paranamer
> 1046 commons-net:commons-net
> 1047 net.java.dev.jets3t:jets3t
> These should go okay.
Go okay as being excluded from the check or if I add them to hbase-spark and
hbase-spark-it as direct dependency?
> 1048 org.scala-lang:scala-library
> 1049 org.scala-lang:scala-reflect
> These are probably just an error in our spark module. Best not to try to
> address it until we close out HBASE-16179
Okay. They stay excluded from the check.
> 1050 io.netty:netty
> I think also solved by our move to third-party-deps on HBASE-18271
Just as with guava org.apache.spark:spark-core_2.10 causes the problem. It uses
netty version 3.8.0.Final as transitive dependency while we use 3.6.2.Final
everywhere else.
Should I exclude it from spark-core's dependencies manually?
Thanks, Tamaas
> Start enforcing upperbounds on dependencies
> ---
>
> Key: HBASE-18304
> URL: https://issues.apache.org/jira/browse/HBASE-18304
> Project: HBase
> Issue Type: Task
> Components: build, dependencies
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18304.master.001.patch,
> HBASE-18304.master.002.patch, HBASE-18304.master.002.patch
>
>
> would be nice to get this going before our next major version.
> http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111069#comment-16111069
]
Sean Busbey commented on HBASE-18304:
-
Thanks for digging into this [~tamaas]. I like the incremental approach of
making sure we don't get new mismatched dependencies and then working through
the list of current excludes.
Rough back of the envelope, I expect the current list to go like this:
bq. 1042
com.google.protobuf:protobuf-java
This is going to be a nightmare due to our purposeful handling of multiple
versions. But maybe I'm misunderstanding it, since shouldn't our internal use
of protobuf 3 be masked since we relocate it in third-party-deps?
bq. 1043org.slf4j:slf4j-log4j12
This one should be easy to just set to latest.
bq. 1044com.google.guava:guava
Maybe solved for us by our move to third-party-deps? Shouldn't only Hadoop's
show up? or is the conflict in spark or some such? (questions for the eventual
follow-on JIRA)
{quote}
1045
com.thoughtworks.paranamer:paranamer
1046commons-net:commons-net
1047net.java.dev.jets3t:jets3t
{quote}
These should go okay.
{quote}
1048org.scala-lang:scala-library
1049org.scala-lang:scala-reflect
{quote}
These are probably just an error in our spark module. Best not to try to
address it until we close out HBASE-16179
bq. 1050io.netty:netty
I think also solved by our move to third-party-deps on HBASE-18271
> Start enforcing upperbounds on dependencies
> ---
>
> Key: HBASE-18304
> URL: https://issues.apache.org/jira/browse/HBASE-18304
> Project: HBase
> Issue Type: Task
> Components: build, dependencies
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-18304.master.001.patch,
> HBASE-18304.master.002.patch, HBASE-18304.master.002.patch
>
>
> would be nice to get this going before our next major version.
> http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111049#comment-16111049
]
Hadoop QA commented on HBASE-18304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
44s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
24s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
5s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
47s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
27s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}142m
20s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}182m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12880017/HBASE-18304.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux c2115ac8b563 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f260f09 |
| Default Java | 1.8.0_131 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7888/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7888/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Start enforcing upperbounds on dependencies
> ---
>
> Key: HBASE-18304
> URL: https://issues.apache.org/jira/browse/HBASE-18304
> Project: HBase
> Issue Type: Task
> Components: build, dependencies
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
>
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110716#comment-16110716
]
Hadoop QA commented on HBASE-18304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
43s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
30s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
17s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
4s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
53s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 48s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}147m 37s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanAll |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook |
| | org.apache.hadoop.hbase.client.TestAsyncTableBatch |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.TestMultiVersions |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi |
| | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi |
| | org.apache.hadoop.hbase.client.TestMultiRespectsLimits |
| | org.apache.hadoop.hbase.coprocessor.TestMasterObserver |
| | org.apache.hadoop.hbase.client.TestServerBusyException |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.client.TestMetaWithReplicas |
| | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption |
| | org.apache.hadoop.hbase.TestClusterBootOrder |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotas |
| | org.apache.hadoop.hbase.TestJMXConnectorServer |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[ https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109028#comment-16109028 ] Mike Drob commented on HBASE-18304: --- Scala versioning was discussed as part of the spark support, I think even bugfix versions there are risky was the consensus. Stack has been talking about shading Netty over on HBASE-18271 because we pull an older version from Hadoop I think, so we're stuck with the conflict there. Guava... we use a shaded 22, but hadoop depends on an older version as well, so we're stuck with that. I would not add it as declared. I'm not sure about the others, I assume it's a similar situation. Starting to think this issue causes more problems than it solves. > Start enforcing upperbounds on dependencies > --- > > Key: HBASE-18304 > URL: https://issues.apache.org/jira/browse/HBASE-18304 > Project: HBase > Issue Type: Task > Components: build, dependencies >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18304.master.001.patch > > > would be nice to get this going before our next major version. > http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[ https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107251#comment-16107251 ] Tamas Penzes commented on HBASE-18304: -- Hi [~mdrob], We do have other dependencies which have conflicts. * org.slf4j:slf4j-log4j12 * com.google.guava:guava * com.thoughtworks.paranamer:paranamer * commons-net:commons-net * net.java.dev.jets3t:jets3t * org.scala-lang:scala-library * org.scala-lang:scala-reflect * io.netty:netty Should I exclude all of them from the check (just like protobuf) or fix the issues by updating minor/build versions? Or should I exclude them now and update the versions/re-include them in a separate ticket? None of them need a major version update, so they should not cause problems, but I cannot guarantee. scala version from 2.10.4 to 2.10.5 (doesn't look risky) netty.hadoop.version from 3.6.2.Final to 3.8.0.Final (might be risky) Some dependencies are only transitive at the moment, but the conflicts can be solved by adding them as provided dependencies with the following versions numbers: paranamer.version -> 2.6 guava.version -> 14.0.1 jets3t.version -> 0.9.0 commons-net.version -> 3.1 It is also possible to exclude these dependencies with the older version from the tree and only keep the newest ones, but it would be harder to maintain. The enforcer plugin must also be updated to a newer version to handle excludes: maven-enforcer-plugin.version -> 3.0.0-M1 Regards, Tamaas > Start enforcing upperbounds on dependencies > --- > > Key: HBASE-18304 > URL: https://issues.apache.org/jira/browse/HBASE-18304 > Project: HBase > Issue Type: Task > Components: build, dependencies >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18304.master.001.patch > > > would be nice to get this going before our next major version. > http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105482#comment-16105482
]
Hadoop QA commented on HBASE-18304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
56s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
21s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
34s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m
47s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
3s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
16s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
10s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
47s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 73m 27s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
4s{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
36s{color} | {color:green} hbase-spark-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}139m
51s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}281m 46s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.client.TestScanWithoutFetchingData |
| | org.apache.hadoop.hbase.mapreduce.TestWALPlayer |
| | org.apache.hadoop.hbase.coprocessor.TestHTableWrapper |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.mapreduce.TestTableInputFormat |
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[ https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104988#comment-16104988 ] Mike Drob commented on HBASE-18304: --- Hi [~tamaas], when I said to exclude the protobuf dep I meant to exclude it from the configuration, not the actual dependency tree. I think we can use the mechanism in MENFORCER-273 to do this. > Start enforcing upperbounds on dependencies > --- > > Key: HBASE-18304 > URL: https://issues.apache.org/jira/browse/HBASE-18304 > Project: HBase > Issue Type: Task > Components: build, dependencies >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-18304.master.001.patch > > > would be nice to get this going before our next major version. > http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[ https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103403#comment-16103403 ] Mike Drob commented on HBASE-18304: --- We intentionally use two versions of protobuf - there's some light reading at https://hbase.apache.org/book.html#protobuf if you're inclined to understand the history of why that is. To help you move forward, is it possible to exclude the protobuf versions while enforcing for everything else? > Start enforcing upperbounds on dependencies > --- > > Key: HBASE-18304 > URL: https://issues.apache.org/jira/browse/HBASE-18304 > Project: HBase > Issue Type: Task > Components: build, dependencies >Affects Versions: 2.0.0 >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > > would be nice to get this going before our next major version. > http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18304) Start enforcing upperbounds on dependencies
[
https://issues.apache.org/jira/browse/HBASE-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103391#comment-16103391
]
Tamas Penzes commented on HBASE-18304:
--
Hi,
I've added the RequireUpperBoundDeps enforcer plugin to the project which
immediately complained about the use of old version of
com.google.protobuf:protobuf-java.
{code}
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (require-upper-bound-deps) @
hbase-procedure ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps
failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for
com.google.protobuf:protobuf-java:2.5.0 paths to dependency are:
+-org.apache.hbase:hbase-procedure:3.0.0-SNAPSHOT
+-org.apache.hbase:hbase-common:3.0.0-SNAPSHOT
+-com.google.protobuf:protobuf-java:2.5.0
and
+-org.apache.hbase:hbase-procedure:3.0.0-SNAPSHOT
+-org.apache.hbase:hbase-protocol-shaded:3.0.0-SNAPSHOT
+-com.google.protobuf:protobuf-java:2.5.0 (managed) <--
com.google.protobuf:protobuf-java:3.2.0
and
+-org.apache.hbase:hbase-procedure:3.0.0-SNAPSHOT
+-org.apache.hbase:hbase-common:3.0.0-SNAPSHOT
+-com.google.protobuf:protobuf-java:2.5.0 (managed) <--
com.google.protobuf:protobuf-java:3.2.0
and
+-org.apache.hbase:hbase-procedure:3.0.0-SNAPSHOT
+-org.apache.hadoop:hadoop-common:2.7.1
+-com.google.protobuf:protobuf-java:2.5.0 (managed) <--
com.google.protobuf:protobuf-java:3.2.0
{code}
>From the main pom.xml I've already seen that it won't be simple:
{code}
2.5.0
{code}
Okay, but let's try to update it to 3.2.0 agains the comment, let's see what
happens (it can show the cause of the comment):
{code}
INFO] --- maven-compiler-plugin:3.6.1:compile (default-compile) @
hbase-protocol ---
[INFO] Compiling 31 source files to
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/target/classes
[INFO]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java:
Some input files use or override a deprecated API.
[INFO]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java:
Recompile with -Xlint:deprecation for details.
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java:[30,52]
cannot find symbol
symbol: class LiteralByteString
[ERROR]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java:[44,16]
cannot find symbol
symbol: class LiteralByteString
location: class com.google.protobuf.HBaseZeroCopyByteString
[ERROR]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java:[55,16]
cannot find symbol
symbol: class BoundedByteString
location: class com.google.protobuf.HBaseZeroCopyByteString
[ERROR]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java:[68,24]
cannot find symbol
symbol: class LiteralByteString
location: class com.google.protobuf.HBaseZeroCopyByteString
[ERROR]
/Users/tamaspenzes/projects/hbase-apache/hbase-protocol/src/main/java/com/google/protobuf/HBaseZeroCopyByteString.java:[69,16]
cannot find symbol
symbol: class LiteralByteString
location: class com.google.protobuf.HBaseZeroCopyByteString
[INFO] 5 errors
{code}
Only five errors, because the build died after the first failed subproject.
These classes (LiteralByteString and BoundedByteString) became private inner
classes of ByteString recently. (I guess with version 3.0)
But there might be other changes in the API too.
Should I create a separate ticket for updating ProtoBuf which we use all over
the code?
I could set it as a dependency for this ticket.
Thank, Tamaas
> Start enforcing upperbounds on dependencies
> ---
>
> Key: HBASE-18304
> URL: https://issues.apache.org/jira/browse/HBASE-18304
> Project: HBase
> Issue Type: Task
> Components: build, dependencies
>Affects Versions: 2.0.0
>Reporter: Sean Busbey
>Assignee: Tamas Penzes
> Labels: beginner
> Fix For: 2.0.0
>
>
> would be nice to get this going before our next major version.
> http://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
