[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131059#comment-16131059 ] Hudson commented on HBASE-18430: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/]) HBASE-18430 fixed typo (misty: rev 70a357dc5cc74ae6a354c907959f644f563aeee4) * (edit) src/main/asciidoc/_chapters/appendix_contributing_to_documentation.adoc > Typo in "contributing to documentation" page > > > Key: HBASE-18430 > URL: https://issues.apache.org/jira/browse/HBASE-18430 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Coral >Assignee: Coral > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18430.patch > > > Be sure to set the component to Documentation in addition any other involved > components. > Missing "to." Should be: > Be sure to set the component to Documentation in addition *to* any other > involved components. > http://hbase.apache.org/book.html#appendix_contributing_to_documentation -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097092#comment-16097092 ] Hudson commented on HBASE-18430: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3415 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3415/]) HBASE-18430 fixed typo (misty: rev 70a357dc5cc74ae6a354c907959f644f563aeee4) * (edit) src/main/asciidoc/_chapters/appendix_contributing_to_documentation.adoc > Typo in "contributing to documentation" page > > > Key: HBASE-18430 > URL: https://issues.apache.org/jira/browse/HBASE-18430 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Coral >Assignee: Coral > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18430.patch > > > Be sure to set the component to Documentation in addition any other involved > components. > Missing "to." Should be: > Be sure to set the component to Documentation in addition *to* any other > involved components. > http://hbase.apache.org/book.html#appendix_contributing_to_documentation -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096862#comment-16096862 ] Coral commented on HBASE-18430: --- Awesome. Thanks for the help, [~misty]! I appreciate it. > Typo in "contributing to documentation" page > > > Key: HBASE-18430 > URL: https://issues.apache.org/jira/browse/HBASE-18430 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Coral >Assignee: Coral > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18430.patch > > > Be sure to set the component to Documentation in addition any other involved > components. > Missing "to." Should be: > Be sure to set the component to Documentation in addition *to* any other > involved components. > http://hbase.apache.org/book.html#appendix_contributing_to_documentation -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096860#comment-16096860
]
Misty Stanley-Jones commented on HBASE-18430:
-
No worries. The sign-off is not a HBase requirement, just a personal preference
for some of us. It just adds that little "Signed-off by" line to the commit
message. It's actually something that happens during the {{git commit}}, not
the {{git format-patch}}. Your {{git format-patch}} is perfect. If you commit
and then realize you didn't sign off, you can do {{git commit --amend -s}}. I
do that all the time. :) You can always look at your existing commit by doing
{{git log -n1}}.
> Typo in "contributing to documentation" page
>
>
> Key: HBASE-18430
> URL: https://issues.apache.org/jira/browse/HBASE-18430
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Coral
>Assignee: Coral
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved
> components.
> Missing "to." Should be:
> Be sure to set the component to Documentation in addition *to* any other
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096842#comment-16096842 ] Coral commented on HBASE-18430: --- Works for me. I'll add the sign-off line in the future. > Typo in "contributing to documentation" page > > > Key: HBASE-18430 > URL: https://issues.apache.org/jira/browse/HBASE-18430 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Coral >Assignee: Coral > Fix For: 3.0.0, 2.0.0-alpha-2 > > Attachments: HBASE-18430.patch > > > Be sure to set the component to Documentation in addition any other involved > components. > Missing "to." Should be: > Be sure to set the component to Documentation in addition *to* any other > involved components. > http://hbase.apache.org/book.html#appendix_contributing_to_documentation -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096837#comment-16096837
]
Mike Drob commented on HBASE-18430:
---
This JIRA might not be the best venue to hash out git internals, but it looks
like we already have all the information even without the sign-off line?
{noformat}
mdrob@mdrob-MBP:~/IdeaProjects/hbase$ git log -1 70a357dc5c --format=full
commit 70a357dc5cc74ae6a354c907959f644f563aeee4 (origin/master, origin/HEAD)
Author: coral
Commit: Misty Stanley-Jones
HBASE-18430 fixed typo
Signed-off-by: Misty Stanley-Jones
{noformat}
> Typo in "contributing to documentation" page
>
>
> Key: HBASE-18430
> URL: https://issues.apache.org/jira/browse/HBASE-18430
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Coral
>Assignee: Coral
> Fix For: 3.0.0, 2.0.0-alpha-2
>
> Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved
> components.
> Missing "to." Should be:
> Be sure to set the component to Documentation in addition *to* any other
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096828#comment-16096828 ] Misty Stanley-Jones commented on HBASE-18430: - With that having been said, this LGTM and I will commit it. Thanks [~coral.w]! > Typo in "contributing to documentation" page > > > Key: HBASE-18430 > URL: https://issues.apache.org/jira/browse/HBASE-18430 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Coral >Assignee: Coral > Attachments: HBASE-18430.patch > > > Be sure to set the component to Documentation in addition any other involved > components. > Missing "to." Should be: > Be sure to set the component to Documentation in addition *to* any other > involved components. > http://hbase.apache.org/book.html#appendix_contributing_to_documentation -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096829#comment-16096829
]
Coral commented on HBASE-18430:
---
Should I be using a different command to create the patch? I used this command
that I got from the doc:
{code:java}
git format-patch --stdout origin/master > HBASE-123456.patch
{code}
I'm new to git, so thanks for the help. :)
> Typo in "contributing to documentation" page
>
>
> Key: HBASE-18430
> URL: https://issues.apache.org/jira/browse/HBASE-18430
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Coral
>Assignee: Coral
> Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved
> components.
> Missing "to." Should be:
> Be sure to set the component to Documentation in addition *to* any other
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096826#comment-16096826
]
Misty Stanley-Jones commented on HBASE-18430:
-
No, {{-s}} is not cryptographic signing. You use {{-S}} for that. Gotta love
{{git}}. I didn't realize that about the subject. I don't recall seeing it in
other patches created using {{git format-patch}}, but when I look back at my
old patches it is there. Sorry about that!
The {{-s}} is useful for committers who are committing others' patches. It adds
a sign-off line for you beneath the sign-off line for the contributor. It's not
a current requirement, and I forget to do it half the time myself.
> Typo in "contributing to documentation" page
>
>
> Key: HBASE-18430
> URL: https://issues.apache.org/jira/browse/HBASE-18430
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Coral
>Assignee: Coral
> Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved
> components.
> Missing "to." Should be:
> Be sure to set the component to Documentation in addition *to* any other
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096820#comment-16096820
]
Mike Drob commented on HBASE-18430:
---
[~misty] the \[PATCH] is auto generated by {{git format-patch}} and gets
stripped if you use {{git am}}.
Also, I didn't know we cryptographically signed our commits. We should update
the docs and {{dev-support/submit-patch.py}} for that.
> Typo in "contributing to documentation" page
>
>
> Key: HBASE-18430
> URL: https://issues.apache.org/jira/browse/HBASE-18430
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Coral
>Assignee: Coral
> Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved
> components.
> Missing "to." Should be:
> Be sure to set the component to Documentation in addition *to* any other
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[
https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096810#comment-16096810
]
Misty Stanley-Jones commented on HBASE-18430:
-
Looks great. Please amend the commit message to remove the {{[patch]}} prefix,
as we don't use that. Also consider signing your commit by adding the {{-s}}
flag to the git commit message. To do both things at once, do a command like:
{code}
git commit --amend -s
{code}
> Typo in "contributing to documentation" page
>
>
> Key: HBASE-18430
> URL: https://issues.apache.org/jira/browse/HBASE-18430
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Coral
>Assignee: Coral
> Attachments: HBASE-18430.patch
>
>
> Be sure to set the component to Documentation in addition any other involved
> components.
> Missing "to." Should be:
> Be sure to set the component to Documentation in addition *to* any other
> involved components.
> http://hbase.apache.org/book.html#appendix_contributing_to_documentation
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18430) Typo in "contributing to documentation" page
[ https://issues.apache.org/jira/browse/HBASE-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096722#comment-16096722 ] Coral commented on HBASE-18430: --- Hi [~misty]! I'm taking over the HBase doc at Cloudera. I've heard many good things about you and your doc is great, so thank you. :) I'm just fixing this little one while I figure out the process of contributing upstream. I'll definitely take you up on your offer for review in the future. I appreciate it! > Typo in "contributing to documentation" page > > > Key: HBASE-18430 > URL: https://issues.apache.org/jira/browse/HBASE-18430 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Coral >Assignee: Coral > > Be sure to set the component to Documentation in addition any other involved > components. > Missing "to." Should be: > Be sure to set the component to Documentation in addition *to* any other > involved components. > http://hbase.apache.org/book.html#appendix_contributing_to_documentation -- This message was sent by Atlassian JIRA (v6.4.14#64029)
