[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970977#comment-16970977
]
Hudson commented on HBASE-18439:
Results for branch branch-2.2
[build #688 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/688/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/688//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/688//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/688//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970971#comment-16970971
]
Hudson commented on HBASE-18439:
Results for branch branch-1.3
[build #1033 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1033/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1033//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1033//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/1033//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970936#comment-16970936
]
Hudson commented on HBASE-18439:
Results for branch branch-1.4
[build #1082 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1082/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1082//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1082//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1082//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970847#comment-16970847
]
Hudson commented on HBASE-18439:
Results for branch master
[build #1531 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1531/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1531//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1531//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1531//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970771#comment-16970771
]
Hudson commented on HBASE-18439:
Results for branch branch-1
[build #1132 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1132/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1132//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1132//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1132//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970714#comment-16970714
]
Hudson commented on HBASE-18439:
Results for branch branch-2.1
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1704//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970682#comment-16970682
]
Hudson commented on HBASE-18439:
Results for branch branch-2
[build #2348 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2348//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970623#comment-16970623
]
Hudson commented on HBASE-18439:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #671 (See
[https://builds.apache.org/job/HBase-1.3-IT/671/])
HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same
(jan.hentschel: rev f7ca22fd4890a952fcf8fa66254fe08567bf2306)
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomRsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceRegionsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeSplitPolicyAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RollingBatchRestartRsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeBloomFilterAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRsHoldingMetaAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ForceBalancerAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/BatchRestartRsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SnapshotTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/TruncateTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRsHoldingTableAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActiveMasterAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeCompressionAction.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/DumpClusterStatusAction.java
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3
>
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967602#comment-16967602
]
Rabi Kumar K C commented on HBASE-18439:
Assigning the ticket to myself as this has remained stale for a while. Will
open a PR soon for this. Hopefully this is still required.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Rabi Kumar K C
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921263#comment-16921263
]
Rabi Kumar K C commented on HBASE-18439:
Hi [~mdrob] If this is not done yet and still needs to be finished can I take
this up?? I am planning to create logger for each sub class of Action and
create a private LoggerFactory.getLogger(.class) and remove static
present in Logger of Action class.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Jui-Yu Hsieh
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129793#comment-16129793
]
Jui-Yu Hsieh commented on HBASE-18439:
--
Thank you~ I will keep in touch with you
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Jui-Yu Hsieh
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129455#comment-16129455
]
Mike Drob commented on HBASE-18439:
---
[~johnfly2003] let me know if you need any help with this.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Jui-Yu Hsieh
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115736#comment-16115736
]
Jui-Yu Hsieh commented on HBASE-18439:
--
Thank you :)[#Sahil Aggarwal]
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Jui-Yu Hsieh
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115733#comment-16115733
]
Chia-Ping Tsai commented on HBASE-18439:
I have added [~johnfly2003] to contributors.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115731#comment-16115731
]
Sahil Aggarwal commented on HBASE-18439:
[~johnfly2003] Sure, i haven't started on it yet. I can't find you to assign it
to you, probably because you are not added to contributers.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115728#comment-16115728
]
Jui-Yu Hsieh commented on HBASE-18439:
--
ｓｏｒｒｙ～
I made a mistake about the time
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
[
https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115714#comment-16115714
]
Jui-Yu Hsieh commented on HBASE-18439:
--
Hi , Sahil Aggarwal ,
I want to solve this issue.
Could you assign this issue to me ? thanks.
> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> --
>
> Key: HBASE-18439
> URL: https://issues.apache.org/jira/browse/HBASE-18439
> Project: HBase
> Issue Type: Bug
> Components: integration tests
>Reporter: Mike Drob
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super
> class. We should have them declare distinct loggers, either each one in class
> or perhaps we can do something dynamically like
> {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the
> static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the
> MethodHandles approach in general is how logger resolution happens in Solr
> and it actually works out pretty well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
