[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160761#comment-16160761 ] stack commented on HBASE-18782: --- They are in place thoughout, yes. They were added once and then have not been maintained since. Original idea was that we could feed hbase piecemeal to external CI sites like Travis -- Travis doesn't like projects of our size and test-duration -- first passing it the i/o tests, then the region tests, then the mapreduce tests, and so on. It cross-cuts our modularization. Not sure it the way to go. Either we double-down on the "test-type" categorization -- we already have another categorization dimension of small/medium/large which has decent definition up in refguide -- and exploit it in someway (at mo. it is just unused noise) or we purge it as a failed experiment. I'm for the latter. > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160740#comment-16160740 ] Sean Busbey commented on HBASE-18782: - I see the test categorizations, which I thought we used extensively? > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160722#comment-16160722 ] stack commented on HBASE-18782: --- bq. Is that fine Yes. After yetus goes in, whats in hbase-annotation is nought but categorizations, categorizations we do not make use of that I know of; either we double-down on the categorizations or remove them (and hbase-annotations module). > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160703#comment-16160703 ] Sean Busbey commented on HBASE-18782: - I'm rebasing my work to move to yetus audience annotation in HBASE-17823 and I just got to the impact of this commit. to make sure I'm not undoing any of your intent here [~stack], I wanted to check in. At the moment, I've got the dependency on yetus annotations put into the hbase-build-configuration pom, essentially using it as short hand for "any hbase module with java code should have this dependency". With that change in place, the few modules where you've removed annotation (e.g. hbase-external-blockcache) will have the annotations jar as a dependency and I can put back in the explicit IA.Private. Is that fine, or would you prefer I make it so that the dep doesn't show up? > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160633#comment-16160633 ] Hudson commented on HBASE-18782: FAILURE: Integrated in Jenkins build HBase-2.0 #493 (See [https://builds.apache.org/job/HBase-2.0/493/]) HBASE-18782 Module untangling work (stack: rev 7be38cbc6a96fe0d9fa9ce49379982ebdcfbbad8) * (edit) hbase-archetypes/hbase-client-project/pom.xml * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java * (edit) hbase-examples/pom.xml * (edit) hbase-rest/pom.xml * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/util/ForeignExceptionUtil.java * (edit) hbase-it/pom.xml * (edit) hbase-protocol/pom.xml * (edit) hbase-protocol-shaded/pom.xml * (edit) hbase-spark-it/pom.xml * (edit) hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160629#comment-16160629 ] Hudson commented on HBASE-18782: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3695 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3695/]) HBASE-18782 Module untangling work (stack: rev 591d86ab29bfebe1e87657c030319d17c7c8ef44) * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java * (edit) hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/util/ForeignExceptionUtil.java * (edit) hbase-examples/pom.xml * (edit) hbase-rest/pom.xml * (edit) hbase-spark-it/pom.xml * (edit) hbase-it/pom.xml * (edit) hbase-archetypes/hbase-client-project/pom.xml * (edit) hbase-external-blockcache/src/main/java/org/apache/hadoop/hbase/io/hfile/MemcachedBlockCache.java * (edit) hbase-protocol-shaded/pom.xml * (edit) hbase-protocol/pom.xml > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160532#comment-16160532 ] stack commented on HBASE-18782: --- Oh, thanks for review [~appy] > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160531#comment-16160531 ] stack commented on HBASE-18782: --- bq. imo, 5 lines comments on top of classes don't look any better. They allow undo of the tangle brought on by one class only. bq. But it's a nit right now, and meat of the change is untangling other deps. Yeah. The move to use yetus annotations makes it so we could near do away with hbase-annotations altogether. Remaining are typing labels we don't honor. We should either take them on or just strip them. > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160112#comment-16160112 ] Appy commented on HBASE-18782: -- lgtm. imo, 5 lines comments on top of classes don't look any better. :-) I think things will drift back to everything depending on annotations again, which kind of makes sense to me. I guess in any future, if we want hbase classes to be well labelled, that's the only way(?). Btw, I filtered out that module from my structure101 view. But it's a nit right now, and meat of the change is untangling other deps. So +1. > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[
https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160083#comment-16160083
]
Hadoop QA commented on HBASE-18782:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
27s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
10s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 20s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
53s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
12s{color} | {color:green} hbase-external-blockcache in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
16s{color} | {color:green} hbase-spark-it in the patch passed.
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160073#comment-16160073 ] stack commented on HBASE-18782: --- .004 Don't change hbase-shell pom. Be conservative. > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch, HBASE-18782.master.002.patch, > HBASE-18782.master.003.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[
https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160021#comment-16160021
]
Hadoop QA commented on HBASE-18782:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
15s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
10s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
19s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
50s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
45s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
12s{color} | {color:green} hbase-external-blockcache in the patch passed.
[jira] [Commented] (HBASE-18782) Module untangling work
[
https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159762#comment-16159762
]
Hadoop QA commented on HBASE-18782:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
10s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
19s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 3s{color}
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
23s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
56s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
3s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-external-blockcache in the patch passed.
{color} |
|
[jira] [Commented] (HBASE-18782) Module untangling work
[ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159716#comment-16159716 ] stack commented on HBASE-18782: --- .002 is less ambitious. > Module untangling work > -- > > Key: HBASE-18782 > URL: https://issues.apache.org/jira/browse/HBASE-18782 > Project: HBase > Issue Type: Task >Reporter: stack >Assignee: stack > Attachments: HBASE-18782.master.001.patch, > HBASE-18782.master.002.patch > > > Here is a bit of module untangling work done using structure 101. In a few > places we depend on modules but are not making use of the dependency. In > other places we depended on a module just because we had one references only, > one we could undo. > After this little exercise, we have nicer layering and stuff like > hbase-protocol and hbase-protocol-shaded no longer depend on other hbase > components. Not everything depends on annotations anymore. > There is way more work to do here but this will do for now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18782) Module untangling work
[
https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159326#comment-16159326
]
Hadoop QA commented on HBASE-18782:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
1s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
0s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
15s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 50s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-spark-it {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
20s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 2s{color}
| {color:red} hbase-shell in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 58s{color}
| {color:red} hbase-endpoint in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
19s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
42s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color}
