[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[
https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612959#comment-16612959
]
Hadoop QA commented on HBASE-18829:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 2m
57s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
24s{color} | {color:red} hbase-server: The patch generated 7 new + 213
unchanged - 0 fixed = 220 total (was 213) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
24s{color} | {color:red} patch has 16 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
49s{color} | {color:red} The patch causes 17 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
55s{color} | {color:red} The patch causes 17 errors with Hadoop v3.0.0. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
36s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 51s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 18s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-18829 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12887586/HBASE-18829.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 71e74fc45b27 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / dc1dedb073 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/14405/artifact/patchprocess/patch-mvninstall-root.txt
|
| compile |
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612941#comment-16612941 ] Allan Yang commented on HBASE-18829: Any progress on this? +1 to revert this. Taking the Region's lock (write lock) first and set closing to true later will cause the new coming request waiting on the region's lock(read lock) in startRegionOperation. This is no good, since write lock has priority for Java's ReadWriteLock, the region closing operation will finish first, and those new coming request will still throw a NotServingRegionException to client, the waiting is useless. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Attachments: 18829.v1.txt, HBASE-18829.patch > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[
https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346420#comment-16346420
]
Hadoop QA commented on HBASE-18829:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
6s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
59s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}106m 10s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}145m 42s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.io.hfile.TestCacheOnWrite |
| | hadoop.hbase.TestZooKeeper |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18829 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12887412/18829.v1.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 973e871e8240 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 08bcd64c25 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit |
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171080#comment-16171080 ] Vincent Poon commented on HBASE-18829: -- The lock is a non-fair mode lock, so in theory there are no guarantees as to when the writelock will be obtained when there are many readers contending for the lock as well. Setting this.closing(true) at least prevents other readers from trying to obtain the read lock, giving the writer eventual access to the lock. At least, that's my understanding of the intention from looking at the code. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt, HBASE-18829.patch > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171044#comment-16171044 ] Allan Yang commented on HBASE-18829: I am still not get the point why should we revert? Isn't better we acquire the close lock first before we set the closing to true? > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt, HBASE-18829.patch > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[
https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169570#comment-16169570
]
Hadoop QA commented on HBASE-18829:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 5m
16s{color} | {color:red} branch has 12 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 3m
55s{color} | {color:red} patch has 12 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
59s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18829 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12887586/HBASE-18829.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d30291f23bd5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 190a660 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8669/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8669/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Consider reverting HBASE-14893 Race between mutation on region and region
> closing operation
>
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169002#comment-16169002 ] Andrew Purtell commented on HBASE-18829: I want to see rigorous testing of this change before we commit it. I don't want a repeat of the storefile locking change. Rigorous implies ~24 hours of testing with ITBLL. I will insist on post of evidence of positive results like this before a commit, thanks. I think everyone can appreciate the abundance of caution. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168680#comment-16168680 ] Vincent Poon commented on HBASE-18829: -- PHOENIX-3111 introduced a preClose() hook which stalls the region closing until all scanners are done, which sidesteps the race condition in HBASE-14893. However, that is problematic because it might stall forever - PHOENIX-4214 Assuming PHOENIX-4214 can be fixed, then HBASE-14893 doesn't matter to Phoenix. The decision to revert / not-revert should be based on its correctness from HBase's perspective. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168671#comment-16168671 ] Sergey Soldatov commented on HBASE-18829: - [~lhofhansl] I have strong feeling that Phoenix code is not relying on this behavior anymore ([~jamestaylor] and [~rajeshbabu] may correct me). Initially HBASE-14893 was introduced to avoid failing batchMutate because of closing state. Right now Phoenix is waiting for the completeness of batch mutations in preClose(), so closing state would not be set until we complete (or fail) our operations. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[
https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168633#comment-16168633
]
Hadoop QA commented on HBASE-18829:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
44s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
59s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
56s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 23s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}102m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18829 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12887412/18829.v1.txt |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4043d0eca903 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a6d8ced |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168505#comment-16168505 ] Josh Elser commented on HBASE-18829: bq. If Phoenix has solution in place dealing with the NotServingRegionException, it would be safer to revert. It seems like this would be the better long-term solution to make (we're not under the gun right now). Admittedly, I haven't traced through the HRegion code to appreciate the concurrency. Unless I've missed it, there's no other reason that HBASE-14893 was done than letting the Phoenix code work without a more substantial change downstream. In that case, I think the revert makes sense and we can do a "non-lazy" fix in Phoenix land. I think this is what Lars is saying too. This means we'd improve this dodgy code via PHOENIX-3177? Or just PHOENIX-4214? What's your take, [~rajeshbabu]? > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168469#comment-16168469 ] Ted Yu commented on HBASE-18829: If Phoenix has solution in place dealing with the NotServingRegionException, it would be safer to revert. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168459#comment-16168459 ] Lars Hofhansl commented on HBASE-18829: --- Then again, this is since 27/Nov/15. So now I'd be worried about code implemented since then relying on this behavior. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168411#comment-16168411 ] Lars Hofhansl commented on HBASE-18829: --- My comment from HBASE-14893: +1 on reverting. The intention here was good. At the same time I think that accommodating this way in HBase for an issue in Phoenix is too dangerous. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
