[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281374#comment-16281374 ] Chia-Ping Tsai commented on HBASE-19340: LGTM > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.3.2, 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch, > HBASE-19340-branch-1.2.batch, HBASE-19340-branch-1.3.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281370#comment-16281370 ] zhaoyuan commented on HBASE-19340: -- :) [~chia7712] Please help me to review this patch > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch, > HBASE-19340-branch-1.2.batch, HBASE-19340-branch-1.3.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281307#comment-16281307
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
1s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
40s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
6s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
9s{color} | {color:red} The patch generated 67 new + 943 unchanged - 27 fixed =
1010 total (was 970) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
14s{color} | {color:red} The patch generated 157 new + 876 unchanged - 8 fixed
= 1033 total (was 884) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
7s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
43s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:dca6535 |
| JIRA Issue | HBASE-19340 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901001/HBASE-19340-branch-1.3.batch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux f9e7f520ad72 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | branch-1.3 / 6d8c080 |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_161 |
| Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_152
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_161 |
| rubocop | v0.51.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/10280/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/10280/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10280/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10280/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281242#comment-16281242 ] zhaoyuan commented on HBASE-19340: -- OK, let me check it out. > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch, > HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281228#comment-16281228 ] Chia-Ping Tsai commented on HBASE-19340: bq. I have backported all missed options except PRIORITY The priority setting is introduced by HBASE-16095. It exists in branch-1.3+. Do you mind making the patch for branch-1.3? Just add the PRIORITY I believe. > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch, > HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279793#comment-16279793 ] zhaoyuan commented on HBASE-19340: -- I have backported all missed options except PRIORITY .I didn't find a constant property named PRIORITY in source code in branch-1.2. Others go well in test. IFY sir [~chia7712] > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch, > HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279782#comment-16279782
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 37m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
1s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
3s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
9s{color} | {color:red} The patch generated 60 new + 887 unchanged - 26 fixed =
947 total (was 913) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 87 new + 790 unchanged - 5 fixed =
877 total (was 795) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
6s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
4s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:e77c578 |
| JIRA Issue | HBASE-19340 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900805/HBASE-19340-branch-1.2.batch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux 8e50a2bb35de 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-1.2 / 358e2d7 |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_161 |
| Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_152
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_161 |
| rubocop | v0.51.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/10253/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/10253/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10253/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10253/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
>
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279542#comment-16279542 ] zhaoyuan commented on HBASE-19340: -- My pleasure. > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279399#comment-16279399
]
Chia-Ping Tsai commented on HBASE-19340:
bq. I learned from HBASE-17736 and I found you have already add configuration
such as split_policy and flush_policy in admin.create() method. I think maybe
we should add the same logic in admin.alter() method or I missed the code
Parsing the option is implemented in {{update_htd_from_arg}} which is used by
admin.create and admin.alter. The admin.rb has a bit changes between
branch-1.4+ and branch-1.2/1.3. see HBASE-15845
bq. Please help me to review this patch If it is convenient for you.
The patch LGTM. Do you want to backport all missed options here?
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
> Attachments: HBASE-19340-branch-1.2.batch
>
>
> Recently I wanna try to alter the split policy for a table on my cluster
> which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute
> of the HTable so I run the command in hbase shell console below.
> alter 'tablex',SPLIT_POLICY =>
> 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy'
> However, It gave the information like this and I confused
> Unknown argument ignored: SPLIT_POLICY
> Updating all regions with the new schema...
> So I check the source code That admin.rb might miss the setting for this
> argument .
> htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if
> arg[MAX_FILESIZE]
> htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY]
> ...
> So I think it may be a bug ,is it?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278283#comment-16278283 ] zhaoyuan commented on HBASE-19340: -- Hi [~chia7712] Please help me to review this patch If it is convenient for you. I learned from HBASE-17736(sorry I don't know how to add an issue link quickly in comment) and I found you have already add configuration such as split_policy and flush_policy in admin.create() method. I think maybe we should add the same logic in admin.alter() method or I missed the code . Hope to hear from you.Thanks. > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278263#comment-16278263
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 47 new + 891 unchanged - 22 fixed
= 938 total (was 913) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 27 new + 790 unchanged - 5 fixed =
817 total (was 795) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
11s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:e77c578 |
| JIRA Issue | HBASE-19340 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900639/HBASE-19340-branch-1.2.batch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux f06b6334fcfd 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-1.2 / b28455e |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_161 |
| Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_152
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_161 |
| rubocop | v0.51.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/10231/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/10231/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10231/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10231/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
>
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275881#comment-16275881 ] zhaoyuan commented on HBASE-19340: -- It seemed I should control the change to a minimum， I will check it later and thanks for your advice [~chia7712] > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274250#comment-16274250
]
Chia-Ping Tsai commented on HBASE-19340:
{quote}
What should I do with the results of rubocop and ruby-lint test output.
Such as /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:E:196:7:
undefined method assert_match .
{quote}
The warnings look like false positives to me.
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
> Attachments: HBASE-19340-branch-1.2.batch
>
>
> Recently I wanna try to alter the split policy for a table on my cluster
> which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute
> of the HTable so I run the command in hbase shell console below.
> alter 'tablex',SPLIT_POLICY =>
> 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy'
> However, It gave the information like this and I confused
> Unknown argument ignored: SPLIT_POLICY
> Updating all regions with the new schema...
> So I check the source code That admin.rb might miss the setting for this
> argument .
> htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if
> arg[MAX_FILESIZE]
> htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY]
> ...
> So I think it may be a bug ,is it?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274240#comment-16274240 ] Chia-Ping Tsai commented on HBASE-19340: Why do we need the changes in HTD? Seems the logic is same. > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274120#comment-16274120 ] zhaoyuan commented on HBASE-19340: -- Hi [~chia7712] What should I do with the results of rubocop and ruby-lint test output. Such as /testptch/hbase/hbase-shell/src/test/ruby/hbase/admin_test.rb:E:196:7: undefined method assert_match . What did I miss ?It confused me ... > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274106#comment-16274106
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m
7s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
1s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
28s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
27s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
10s{color} | {color:red} The patch generated 38 new + 894 unchanged - 19 fixed
= 932 total (was 913) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 21 new + 794 unchanged - 1 fixed =
815 total (was 795) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
21s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273897#comment-16273897 ] zhaoyuan commented on HBASE-19340: -- Let me checkout the failed test cases > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340-branch-1.2.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273881#comment-16273881
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
16s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
18s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_161 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
29s{color} | {color:green} the patch passed with JDK v1.7.0_161 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
8s{color} | {color:red} The patch generated 17 new + 904 unchanged - 9 fixed =
921 total (was 913) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 11 new + 794 unchanged - 1 fixed =
805 total (was 795) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 56s{color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3.
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed with JDK v1.8.0_152 {color} |
| {color:green}+1{color}
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273847#comment-16273847
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
5s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} HBASE-19340 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:e77c578 |
| JIRA Issue | HBASE-19340 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900132/HBASE-19340.batch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10166/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
> Attachments: HBASE-19340.batch
>
>
> Recently I wanna try to alter the split policy for a table on my cluster
> which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute
> of the HTable so I run the command in hbase shell console below.
> alter 'tablex',SPLIT_POLICY =>
> 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy'
> However, It gave the information like this and I confused
> Unknown argument ignored: SPLIT_POLICY
> Updating all regions with the new schema...
> So I check the source code That admin.rb might miss the setting for this
> argument .
> htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if
> arg[MAX_FILESIZE]
> htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY]
> ...
> So I think it may be a bug ,is it?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273826#comment-16273826 ] zhaoyuan commented on HBASE-19340: -- May be I should rename the patch > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340.branch-1.v0.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[
https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272887#comment-16272887
]
Hadoop QA commented on HBASE-19340:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-19340 does not apply to branch-1. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.6.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19340 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12899980/HBASE-19340.branch-1.v0.batch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10154/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
> ---
>
> Key: HBASE-19340
> URL: https://issues.apache.org/jira/browse/HBASE-19340
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.2.6
>Reporter: zhaoyuan
>Assignee: zhaoyuan
> Fix For: 1.2.8
>
> Attachments: HBASE-19340.branch-1.v0.batch
>
>
> Recently I wanna try to alter the split policy for a table on my cluster
> which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute
> of the HTable so I run the command in hbase shell console below.
> alter 'tablex',SPLIT_POLICY =>
> 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy'
> However, It gave the information like this and I confused
> Unknown argument ignored: SPLIT_POLICY
> Updating all regions with the new schema...
> So I check the source code That admin.rb might miss the setting for this
> argument .
> htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if
> arg[MAX_FILESIZE]
> htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY]
> ...
> So I think it may be a bug ,is it?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272657#comment-16272657 ] Chia-Ping Tsai commented on HBASE-19340: Could you click the "submit patch" to trigger the QA? > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340.branch-1.v0.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272351#comment-16272351 ] zhaoyuan commented on HBASE-19340: -- OK，I wil backport the test cases and push the new patch later > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340.branch-1.v0.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271330#comment-16271330 ] Chia-Ping Tsai commented on HBASE-19340: Please also backport the test cases. > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340.branch-1.v0.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270351#comment-16270351 ] zhaoyuan commented on HBASE-19340: -- I have already pushed the patch and I run mvn test,It looked good to me. Please help me to review the code if it is convenient to you [~chia7712],Thanks! > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan >Assignee: zhaoyuan > Fix For: 1.2.8 > > Attachments: HBASE-19340.branch-1.v0.batch > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266292#comment-16266292 ] zhaoyuan commented on HBASE-19340: -- Let me try to work on this patch~ > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan > Fix For: 1.2.8 > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19340) SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell
[ https://issues.apache.org/jira/browse/HBASE-19340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265330#comment-16265330 ] Chia-Ping Tsai commented on HBASE-19340: We should backport HBASE-17736 and HBASE-17729 to branch-1.3 and 1.2. [~smartZY] Thanks for the report. Do you want to submit the patch? The patches in HBASE-17736 and HBASE-17729 are good references. I will help to review your patch. Or I can deal with the backport if you have no free cycle. :) > SPLIT_POLICY and FLUSH_POLICY cann't be set directly by hbase shell > --- > > Key: HBASE-19340 > URL: https://issues.apache.org/jira/browse/HBASE-19340 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.6 >Reporter: zhaoyuan > Fix For: 1.2.8 > > Attachments: 19340.branch-1.2.txt > > > Recently I wanna try to alter the split policy for a table on my cluster > which version is 1.2.6 and as far as I know The SPLIT_POLICY is an attribute > of the HTable so I run the command in hbase shell console below. > alter 'tablex',SPLIT_POLICY => > 'org.apache.hadoop.hbase.regionserver.DisabledRegionSplitPolicy' > However, It gave the information like this and I confused > Unknown argument ignored: SPLIT_POLICY > Updating all regions with the new schema... > So I check the source code That admin.rb might miss the setting for this > argument . > htd.setMaxFileSize(JLong.valueOf(arg.delete(MAX_FILESIZE))) if > arg[MAX_FILESIZE] > htd.setReadOnly(JBoolean.valueOf(arg.delete(READONLY))) if arg[READONLY] > ... > So I think it may be a bug ,is it? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
