[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315799#comment-16315799
]
Hudson commented on HBASE-19674:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4361 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4361/])
HBASE-19674: Improve make_patch.sh (jan.hentschel: rev
8ae2a2150b517123cde214bb5543557b562c4c01)
* (edit) dev-support/make_patch.sh
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Fix For: 3.0.0
>
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch, HBASE-19674.20180103-160831.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309865#comment-16309865
]
Hadoop QA commented on HBASE-19674:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
3s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} The patch generated 0 new + 1 unchanged - 20 fixed =
1 total (was 21) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19674 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12904422/HBASE-19674.20180103-160831.patch
|
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux ab8538914028 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / d8ef30c5e1 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| shellcheck | v0.4.4 |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10874/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch, HBASE-19674.20180103-160831.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309853#comment-16309853
]
Niels Basjes commented on HBASE-19674:
--
To illustrate it now creates files named like this (this list is ordered by the
file timestamp):
{quote}
HBASE-19674.20180103-160831.patch
HBASE-19674.v01.patch
HBASE-19674.v02.patch
HBASE-19674.v03.patch
HBASE-19674.DummyMaster.v01.patch
HBASE-19674.DummyMaster.v02.patch
HBASE-19674.DummyMaster.v03.patch
HBASE-19674.DummyMaster.v03-addendum.patch
HBASE-19674.DummyMaster.v04.patch
HBASE-19674.DummyMaster.v04-addendum.patch
HBASE-19674.DummyMaster.20180103-161150.patch
HBASE-19674.DummyMaster.20180103-161151.patch
HBASE-19674.DummyMaster.20180103-161152.patch
HBASE-19674.DummyMaster.20180103-161153-addendum.patch
HBASE-19674.DummyMaster.20180103-161154-addendum.patch
HBASE-19674.20180103-161205.patch
HBASE-19674.20180103-161207.patch
HBASE-19674.20180103-161208.patch
HBASE-19674.v03-addendum.patch
{quote}
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch, HBASE-19674.20180103-160831.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309444#comment-16309444
]
Jan Hentschel commented on HBASE-19674:
---
My point is, instead of changing the semantics of {{make_patch}} to something
new it should be unified to follow the naming scheme of the {{submit-patch}}
script (and what is described in the book).
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309368#comment-16309368
]
Niels Basjes commented on HBASE-19674:
--
[~Jan Hentschel]:
I checked this and found
http://hbase.apache.org/book.html#submitting.patches.create
{quote}Patch name is automatically formatted as (JIRA).(branch name).(patch
number).patch to follow Yetus' naming rules.{quote}
And according to
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames/ (which is
mentioned if a patch needs rebasing) can handle both orderings correctly.
I have created several patches using this script over the last few days and it
works fine with Yetus.
https://issues.apache.org/jira/browse/HBASE-19673
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308817#comment-16308817
]
Jan Hentschel commented on HBASE-19674:
---
The general format of the existing script seems to be different than the one
from {{submit-patch}}. There's the format is ...patch,
such as HBASE-19674.master.001.patch. If I remember correctly, this is also the
format we describe in the book. I think it would be better to align these two.
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306844#comment-16306844
]
Hadoop QA commented on HBASE-19674:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} The patch generated 0 new + 1 unchanged - 20 fixed =
1 total (was 21) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19674 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12904068/HBASE-19674.20171230-152443.patch
|
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux fa5416f594fc 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 0d0964aa6a |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| shellcheck | v0.4.4 |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10804/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch
>
>
> I have 4 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> My working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) Improve: I personally prefer using the timestamp as the 'version' of the
> patch because these are much easier to order.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19674) make_patch.sh version increment fails
[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306763#comment-16306763
]
Hadoop QA commented on HBASE-19674:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
3s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
0s{color} | {color:red} The patch generated 9 new + 16 unchanged - 5 fixed = 25
total (was 21) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19674 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12904063/HBASE-19674.20171230-131310.patch
|
| Optional Tests | asflicense shellcheck shelldocs |
| uname | Linux 55172bdeecbe 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 0d0964aa6a |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| shellcheck | v0.4.4 |
| shellcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/10801/artifact/patchprocess/diff-patch-shellcheck.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10801/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> make_patch.sh version increment fails
> -
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
>Reporter: Niels Basjes
>Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch
>
>
> I have 4 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> My working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) Improve: I personally prefer using the timestamp as the 'version' of the
> patch because these are much easier to order.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
