[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383013#comment-16383013
 ] 

stack commented on HBASE-19678:
---

[~yuzhih...@gmail.com] See above. Clean up the mess please.

> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329297#comment-16329297
 ] 

stack commented on HBASE-19678:
---

[~yuzhih...@gmail.com] I have to do my own investigation as to what is going on 
in this issue. Why no clarifying note on the end here that explains the state? 
(Author is wrong in the commits as is the adding BELUGA BEHR as suffix in 
parenthesis).

 

The committed patch looks like it got applied and then reverted:

 

commit c2ca90f0fb5177372e9f72917d67b49014a54b5b
Author: tedyu 
Date: Sun Dec 31 11:32:14 2017 -0800

HBASE-19678 HBase Admin security capabilities should be represented as a Set 
(BELUGA BEHR)

 

commit c394f3919e7981247c60a3d3b075ee554cee826b
Author: tedyu 
Date: Mon Jan 1 14:16:46 2018 -0800

HBASE-19678 HBase Admin security capabilities should be represented as a Set - 
revert due to wrong issue

> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329286#comment-16329286
 ] 

stack commented on HBASE-19678:
---

>From HBASE-19679: "OK, so I made a mistake here. I posted the same patch under 
>two different tickets. The ticket HBASE-19678 should be re-opened as that 
>ticket points out a larger structural issue. This ticket should be closed 
>because of the patch that was submitted as part of HBASE-19678 is a duplicate 
>of the one provided here and was already applied."

> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[Appy (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308619#comment-16308619
 ] 

Appy commented on HBASE-19678:
--

Deleted the wrong patch. Posted it on the other jira HBASE-19679

> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307592#comment-16307592
 ] 

Hudson commented on HBASE-19678:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4327 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4327/])
HBASE-19678 HBase Admin security capabilities should be represented as a 
(tedyu: rev 73ab51e9460f369abcaf52fa85258781f8a9a30e)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/security/Superusers.java


> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19678.1.patch
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[BELUGA BEHR (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307564#comment-16307564
 ] 

BELUGA BEHR commented on HBASE-19678:
-

As mentioned in [HBASE-19679], this is actually still open.  I just posted my 
patch for a different issue under this ticket.

> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19678.1.patch
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19678) HBase Admin security capabilities should be represented as a Set

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307301#comment-16307301
 ] 

Hudson commented on HBASE-19678:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4320 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4320/])
HBASE-19678 HBase Admin security capabilities should be represented as a 
(tedyu: rev 6c2aa4c9ccea04ccf5c9c84de9677bd6232856e1)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/security/Superusers.java


> HBase Admin security capabilities should be represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19678.1.patch
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19678) HBase Admin Security Capabilities Should Be Represented as a Set

[BELUGA BEHR (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307282#comment-16307282
 ] 

BELUGA BEHR commented on HBASE-19678:
-

[~tedyu] It wasn't.  It was just moved up a few lines instead of being buried 
at the end of the method.  Makes it more clear. I know I was surprised to find 
it down there all alone.

> HBase Admin Security Capabilities Should Be Represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HBASE-19678.1.patch
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19678) HBase Admin Security Capabilities Should Be Represented as a Set

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307267#comment-16307267
 ] 

Ted Yu commented on HBASE-19678:


Why was the following call removed ?
{code}
78  superUsers.add(currentUser);
{code}

> HBase Admin Security Capabilities Should Be Represented as a Set
> 
>
> Key: HBASE-19678
> URL: https://issues.apache.org/jira/browse/HBASE-19678
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HBASE-19678.1.patch
>
>
> {code:title=org.apache.hadoop.hbase.client.Admin}
>   /**
>* Return the set of supported security capabilities.
>* @throws IOException
>* @throws UnsupportedOperationException
>*/
>   List getSecurityCapabilities() throws IOException;
> {code}
> The comment says a "set" but it returns a List.  A Set would be the most 
> appropriate data structure here, an immutable one perhaps, because the code 
> that interacts with it looks up information using the _contains_ method which 
> would be served well by a Set.  Please change this interface to return a Set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19678) HBase Admin Security Capabilities Should Be Represented as a Set

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307139#comment-16307139
 ] 

Hadoop QA commented on HBASE-19678:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
51s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
40s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
19m 16s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m  
9s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 95m 
10s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
35s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}142m 11s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19678 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12904093/HBASE-19678.1.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 5faef2e96866 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 0cd6050d09 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813/testReport/ |
| modules | C: hbase-common