[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324810#comment-16324810
]
Hudson commented on HBASE-19752:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4390/])
HBASE-19752 RSGroupBasedLoadBalancer#getMisplacedRegions() should handle
(tedyu: rev f0ba7922f3963276304aee1d354413bcf966e563)
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324797#comment-16324797
]
Andrew Purtell commented on HBASE-19752:
bq. Somehow I used a partial branch-1 patch on branch-1.4
... and didn't check if it even compiled. Never mind if the test passed.
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324746#comment-16324746
]
Ted Yu commented on HBASE-19752:
Commit to branch-1 was correct.
Somehow I used a partial branch-1 patch on branch-1.4
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 1.4.1, 1.5.0, 2.0.0-beta-1
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt, 19752.v6.txt, 19752.v7.branch-1.txt, 19752.v7.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324532#comment-16324532
]
Hadoop QA commented on HBASE-19752:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
53s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
11s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
46s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 58s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
6s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905917/19752.v7.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 34996b0b42fc 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a5601c8eac |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11052/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11052/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324516#comment-16324516
]
Andrew Purtell commented on HBASE-19752:
+1
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt, 19752.v6.txt, 19752.v7.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324497#comment-16324497
]
Ted Yu commented on HBASE-19752:
>From HBASE-19757 :
bq. For HBASE-19752, change the log level to WARN for the second case as
described on the JIRA and you have my +1
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt, 19752.v6.txt, 19752.v7.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324458#comment-16324458
]
Andrew Purtell commented on HBASE-19752:
The first new conditional in v8 patch in getMisplacedRegions looks good.
The second is ok but I don't really understand why we are unable to obtain
RSGroup information for the server. I agree it's not a misplaced region as
such, but I think something else is not right. The log level here should be
WARN.
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt, 19752.v6.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323242#comment-16323242
]
Hadoop QA commented on HBASE-19752:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
12s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
0s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905766/19752.v6.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 913dd80ef680 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4bd6ac3e10 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11030/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11030/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323158#comment-16323158
]
Mike Drob commented on HBASE-19752:
---
Add VisibleForTesting annotation please. I don't really understand the rest of
the issue here, so I will leave the rest of it to [~apurtell]
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323130#comment-16323130
]
Ted Yu commented on HBASE-19752:
[~apurtell]:
Do you have other comment ?
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt,
> 19752.v5.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322599#comment-16322599
]
Hadoop QA commented on HBASE-19752:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 56s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
2s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 45s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905707/19752.v5.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 36a62299bf7a 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 71a1192d67 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11022/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11022/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321679#comment-16321679
]
Guangxu Cheng commented on HBASE-19752:
---
lgtm
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321584#comment-16321584
]
Andrew Purtell commented on HBASE-19752:
Unit test, please
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.1, 1.5.0
>
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt, 19752.v4.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320925#comment-16320925
]
Hadoop QA commented on HBASE-19752:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
26s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
16s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905518/19752.v4.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 66336c170a5d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f0d0501d55 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10986/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320812#comment-16320812
]
Mike Drob commented on HBASE-19752:
---
bq. +LOG.debug("There is no assigned server for " + region);
use parameterized logging here
bq. +LOG.debug("Couldn't obtain rs group information");
include info about which rsgroup/server/region (whatever makes sense)
> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where
> rs group cannot be determined
> -
>
> Key: HBASE-19752
> URL: https://issues.apache.org/jira/browse/HBASE-19752
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread]
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region:
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server:
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
> if (assignedServer != null &&
> (info == null ||
> !info.containsServer(assignedServer.getAddress( {
> RSGroupInfo otherInfo = null;
> otherInfo =
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
> LOG.debug("Found misplaced region: " +
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320737#comment-16320737
]
Hadoop QA commented on HBASE-19752:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
1s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 32s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
17s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905502/19752.v3.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux f83df3a1e475 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f0d0501d55 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10984/testReport/ |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output |
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320645#comment-16320645
]
Hadoop QA commented on HBASE-19752:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 20s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905495/19752.v2.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 20c8198529fd 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f0d0501d55 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit |
[jira] [Commented] (HBASE-19752) RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where rs group cannot be determined
[
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320499#comment-16320499
]
Hadoop QA commented on HBASE-19752:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames for
instructions. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
18s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
14s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
11s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
19s{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 11m
22s{color} | {color:red} The patch causes 11 errors with Hadoop v2.7.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m
32s{color} | {color:red} The patch causes 11 errors with Hadoop v3.0.0. {color}
|
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
14s{color} | {color:red} hbase-rsgroup in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 14s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19752 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905477/19752.v1.txt |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 1833b5ca84c4 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
