[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[
https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430072#comment-16430072
]
Hudson commented on HBASE-20337:
Results for branch HBASE-19064
[build #90 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Update the doc on how to setup shortcircuit reads; its stale
>
>
> Key: HBASE-20337
> URL: https://issues.apache.org/jira/browse/HBASE-20337
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20337.master.001.patch,
> HBASE-20337.master.002.patch
>
>
> The doc is from another era. Update it. Short-circuit reads can make a *big*
> difference when random reading in particular.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[
https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426889#comment-16426889
]
Hudson commented on HBASE-20337:
Results for branch master
[build #284 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/284/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/284//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/284//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/284//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Update the doc on how to setup shortcircuit reads; its stale
>
>
> Key: HBASE-20337
> URL: https://issues.apache.org/jira/browse/HBASE-20337
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20337.master.001.patch,
> HBASE-20337.master.002.patch
>
>
> The doc is from another era. Update it. Short-circuit reads can make a *big*
> difference when random reading in particular.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[ https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425982#comment-16425982 ] stack commented on HBASE-20337: --- Pushed the patch but added note on setting checksum flag to off when reading as hbase does its own checksumming (to save on i/os -- added links to existing explanation on why hbase does its own checksumming). Thanks to [~ram_krish] for the reminder. Also added pointers to shortcircuit HDFS issue since it a good read and to Colin's overview blog done on rollout. > Update the doc on how to setup shortcircuit reads; its stale > > > Key: HBASE-20337 > URL: https://issues.apache.org/jira/browse/HBASE-20337 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20337.master.001.patch, > HBASE-20337.master.002.patch > > > The doc is from another era. Update it. Short-circuit reads can make a big > difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[
https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425020#comment-16425020
]
Hadoop QA commented on HBASE-20337:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}186m
15s{color} | {color:green} root in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
27s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}202m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20337 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12917410/HBASE-20337.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit |
| uname | Linux 4c82fd4b8651 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / b1b0db3195 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/12294/artifact/patchprocess/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12294/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HBASE-Build/12294/artifact/patchprocess/patch-asflicense-problems.txt
|
| Max. process+thread count | 4297 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12294/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Update the doc on how to setup shortcircuit reads; its stale
>
>
> Key: HBASE-20337
> URL: https://issues.apache.org/jira/browse/HBASE-20337
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20337.master.001.patch,
> HBASE-20337.master.002.patch
>
>
> The doc is from another era. Update it. Short-circuit reads can make a big
> difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[ https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424955#comment-16424955 ] Yu Li commented on HBASE-20337: --- +1, nice doc boss. > Update the doc on how to setup shortcircuit reads; its stale > > > Key: HBASE-20337 > URL: https://issues.apache.org/jira/browse/HBASE-20337 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20337.master.001.patch, > HBASE-20337.master.002.patch > > > The doc is from another era. Update it. Short-circuit reads can make a big > difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[ https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424484#comment-16424484 ] Wei-Chiu Chuang commented on HBASE-20337: - LGTM (non-binding) > Update the doc on how to setup shortcircuit reads; its stale > > > Key: HBASE-20337 > URL: https://issues.apache.org/jira/browse/HBASE-20337 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20337.master.001.patch, > HBASE-20337.master.002.patch > > > The doc is from another era. Update it. Short-circuit reads can make a big > difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[ https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424378#comment-16424378 ] stack commented on HBASE-20337: --- .002 addresses [~jojochuang] feedback > Update the doc on how to setup shortcircuit reads; its stale > > > Key: HBASE-20337 > URL: https://issues.apache.org/jira/browse/HBASE-20337 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20337.master.001.patch, > HBASE-20337.master.002.patch > > > The doc is from another era. Update it. Short-circuit reads can make a big > difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[ https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424377#comment-16424377 ] stack commented on HBASE-20337: --- Thanks for the review [~jojochuang] .. I was looking for how to do 'stable' ... I'd forgotten. Thanks for the pointer. Yeah, no metrics and nothing really in logs when all working nicely. Its a nice feature. Can make a big difference when lots of random reading. I could file a few issues I suppose > Update the doc on how to setup shortcircuit reads; its stale > > > Key: HBASE-20337 > URL: https://issues.apache.org/jira/browse/HBASE-20337 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: HBASE-20337.master.001.patch, > HBASE-20337.master.002.patch > > > The doc is from another era. Update it. Short-circuit reads can make a big > difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20337) Update the doc on how to setup shortcircuit reads; its stale
[
https://issues.apache.org/jira/browse/HBASE-20337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424346#comment-16424346
]
Wei-Chiu Chuang commented on HBASE-20337:
-
I'm wondering if it makes sense to use the "stable" Hadoop doc link instead
version "r2.7.3" because eventually HBase will update its dependency on Hadoop.
([https://hadoop.apache.org/docs/r2.7.3/hadoop-project-dist/hadoop-hdfs/ShortCircuitLocalReads.html)]
(stable currently maps to hadoop 2.9.0)
{quote}Otherwise, shortcircuit read operates quietly in background. It does not
provide metrics so no optics on how effective it is
{quote}
I didn't realize this is the case. Maybe we should add those metrics in Hadoop
code.
> Update the doc on how to setup shortcircuit reads; its stale
>
>
> Key: HBASE-20337
> URL: https://issues.apache.org/jira/browse/HBASE-20337
> Project: HBase
> Issue Type: Sub-task
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20337.master.001.patch
>
>
> The doc is from another era. Update it. Short-circuit reads can make a big
> difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
