[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759460#comment-16759460
]
Hudson commented on HBASE-20577:
Results for branch branch-2.2
[build #15 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/15/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/15//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/15//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/15//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch,
> after_patch_LogLevel_CLI.png, after_patch_get_log_level.png,
> after_patch_require_field_validation.png, after_patch_set_log_level_bad.png,
> after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png, rest_after_addendum_patch.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759449#comment-16759449
]
Hudson commented on HBASE-20577:
Results for branch branch-2
[build #1657 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1657/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1657//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1657//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1657//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch,
> after_patch_LogLevel_CLI.png, after_patch_get_log_level.png,
> after_patch_require_field_validation.png, after_patch_set_log_level_bad.png,
> after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png, rest_after_addendum_patch.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758062#comment-16758062 ] Duo Zhang commented on HBASE-20577: --- +1 for branch-2. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757910#comment-16757910 ] Sean Busbey commented on HBASE-20577: - sounds like a nice feature for inclusion in our upcoming minor release line(s). > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757664#comment-16757664 ] Nihal Jain commented on HBASE-20577: I wonder if we want this in branch-2. After HBASE-20693 would be in place, we can surely take this one into branch-2. Would be a nice usability/UI improvement. What are your thoughts? [~busbey], [~Apache9], [~stack] > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504692#comment-16504692
]
Hudson commented on HBASE-20577:
Results for branch master
[build #358 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/358/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/358//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/358//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/358//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch,
> after_patch_LogLevel_CLI.png, after_patch_get_log_level.png,
> after_patch_require_field_validation.png, after_patch_set_log_level_bad.png,
> after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png, rest_after_addendum_patch.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504688#comment-16504688 ] Nihal Jain commented on HBASE-20577: Understood! Thanks [~allan163] for your review and response. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504671#comment-16504671
]
Allan Yang commented on HBASE-20577:
{quote}
So the problem is not occuring now. Right?
{quote}
Just tried your patch, catching FileNotFoundException may not be enough after I
made the change in HBASE-20679. After adding my code (apache-jsp jar is used),
a ServletException was thrown. But you can forget about HBASE-20679,
FileNotFoundException is good enough. you can check in. I will change later in
HBASE-20679.
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch,
> after_patch_LogLevel_CLI.png, after_patch_get_log_level.png,
> after_patch_require_field_validation.png, after_patch_set_log_level_bad.png,
> after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png, rest_after_addendum_patch.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504646#comment-16504646 ] Nihal Jain commented on HBASE-20577: [~allan163] So the problem is not occuring now. Right? > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504605#comment-16504605 ] Allan Yang commented on HBASE-20577: +1 for the addendum, I noticed this problem when I'm implementing HBASE-20679. TestLogLevel failed because of the absence of 'header.jsp' and 'foot.jsp'. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503898#comment-16503898 ] Nihal Jain commented on HBASE-20577: Ok understood. I have attached [^HBASE-20577.master.ADDENDUM.patch] patch which will fall back to original log level design if 'header.jsp'/'footer.jsp' is not present. Will take care of point 2 in [HBASE-20693|https://issues.apache.org/jira/browse/HBASE-20693] > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, HBASE-20577.master.ADDENDUM.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png, rest_after_addendum_patch.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503876#comment-16503876 ] Ted Yu commented on HBASE-20577: Since this is not in any release yet, you can reopen and attach addendum for #1. We can do refactoring in another JIRA. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502306#comment-16502306 ] Nihal Jain commented on HBASE-20577: Hi [~yuzhih...@gmail.com], while trying out rest server, I discovered that Rest does not have 'header.jsp'. So this throws a FNF exception in loglevel page. My bad, i was not aware of other projects having web UI when I wrote this fix. Sorry for the trouble. Anyways, I think it would be wrong to assume all projects' web ui's will be having 'header.jsp'. To mitigate, we can do the following: * 1) fall back to original log level design if 'header.jsp' is not present * 2) Next, we can refactor jsp file of other projects (like rest) to have 'header.jsp' and 'footer.jsp' How should we handle it? Should I create a new JIRA for point 1 and 2 together? Or can we just re-open this issue and add point 1 fix as addendum? And refactor related code in another jira? > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478983#comment-16478983
]
Hudson commented on HBASE-20577:
Results for branch master
[build #334 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/334/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/334//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/334//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/334//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png,
> after_patch_get_log_level.png, after_patch_require_field_validation.png,
> after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478152#comment-16478152
]
Hadoop QA commented on HBASE-20577:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
10s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
51s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20577 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12923776/HBASE-20577.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d12f36e0c0e2 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f4006b5039 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/12859/testReport/ |
| Max. process+thread count | 294 (vs. ulimit of 1) |
| modules | C: hbase-http U: hbase-http |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12859/console |
| Powered by |
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478092#comment-16478092 ] Nihal Jain commented on HBASE-20577: Submitted a new patch after rebase. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478073#comment-16478073 ] Ted Yu commented on HBASE-20577: There was one hunk rejected in hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java Please rebase The patch looks good. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478046#comment-16478046
]
Hadoop QA commented on HBASE-20577:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-20577 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20577 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12923765/HBASE-20577.master.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12858/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png,
> after_patch_get_log_level.png, after_patch_require_field_validation.png,
> after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478033#comment-16478033
]
Nihal Jain commented on HBASE-20577:
{{Reattaching patch for QA to run. Have appended "/n" in FORMS string to print
html tags in a readable format.}}
Please review!
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> HBASE-20577.master.002.patch, after_patch_LogLevel_CLI.png,
> after_patch_get_log_level.png, after_patch_require_field_validation.png,
> after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474525#comment-16474525 ] Wei-Chiu Chuang commented on HBASE-20577: - Got it. Thanks for the clarification! > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > after_patch_LogLevel_CLI.png, after_patch_get_log_level.png, > after_patch_require_field_validation.png, after_patch_set_log_level_bad.png, > after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[
https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474500#comment-16474500
]
Nihal Jain commented on HBASE-20577:
{quote}Would the new patch serve the old purpose (i.e.g changing log level from
command line)?
{quote}
Hi [~jojochuang], I have tested the command line log level tool, it works
perfectly fine as there is no change in the patch with regards to the
processing logic. Attaching a screenshot of the same. Also, the test cases in
{{org.apache.hadoop.hbase.http.log.TestLogLevel}} will ensure that CLI
functionality does not break.
I understand your concern, but this patch is simply an attempt to make hbase UI
consistent across various pages.
> Make Log Level page design consistent with the design of other pages in UI
> --
>
> Key: HBASE-20577
> URL: https://issues.apache.org/jira/browse/HBASE-20577
> Project: HBase
> Issue Type: Improvement
> Components: UI, Usability
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20577.master.001.patch,
> after_patch_get_log_level.png, after_patch_require_field_validation.png,
> after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png,
> before_patch_no_validation_required_field.png
>
>
> The Log Level page in web UI seems out of the place. I think we should make
> it look consistent with design of other pages in HBase web UI.
> Also, validation of required fields should be done, otherwise user should not
> be allowed to click submit button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474468#comment-16474468 ] Wei-Chiu Chuang commented on HBASE-20577: - The original LogLevel looked like its 1990s because it was cloned from Hadoop's LogLevel implementation, and it was intented to be used as acommand line tool (e.g. hadoop daemonlog), so there wasn't much fancy UI. I still find it useful to use hadoop's daemonlog command line tool to change log level dynamically (and you can still use hadoop's daemonlog command against HBase (hint: hbase org.apache.hadoop.log.LogLevel). Partly because getting a browser to enable SPNEGO & kinit is painful, if you run it on a secure cluster. Would the new patch serve the old purpose (i.e.g changing log level from command line)? Or do HBase community think the use of command line loglevel is diminished and everyone uses the web UI instead? Thanks! > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474304#comment-16474304 ] Ted Yu commented on HBASE-20577: Re-triggered QA: https://builds.apache.org/job/PreCommit-HBASE-Build/12812/ > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473527#comment-16473527 ] Ted Yu commented on HBASE-20577: Looking at screenshots, I like the improved user interface. lgtm > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > after_patch_get_log_level.png, after_patch_require_field_validation.png, > after_patch_set_log_level_bad.png, after_patch_set_log_level_success.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20577) Make Log Level page design consistent with the design of other pages in UI
[ https://issues.apache.org/jira/browse/HBASE-20577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473435#comment-16473435 ] Nihal Jain commented on HBASE-20577: Attached a patch with the proposed changes. I have also attached screenshots of how the page would look after patch. > Make Log Level page design consistent with the design of other pages in UI > -- > > Key: HBASE-20577 > URL: https://issues.apache.org/jira/browse/HBASE-20577 > Project: HBase > Issue Type: Improvement > Components: UI, Usability >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20577.master.001.patch, > after_patch_get_log_level_success.png, > after_patch_require_field_validation.png, after_patch_set_log_level.png, > after_patch_set_log_level_bad.png, > before_patch_no_validation_required_field.png > > > The Log Level page in web UI seems out of the place. I think we should make > it look consistent with design of other pages in HBase web UI. > Also, validation of required fields should be done, otherwise user should not > be allowed to click submit button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
