[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613355#comment-16613355 ] Hudson commented on HBASE-21174: Results for branch branch-1 [build #459 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/459/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/459//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/459//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/459//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8, 2.1.1, 2.0.3 > > Attachments: HBASE-21174.branch-1.001.patch, > HBASE-21174.master.001.patch, HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612726#comment-16612726 ] Hudson commented on HBASE-21174: Results for branch branch-1.4 [build #460 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/460/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/460//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/460//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/460//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8, 2.1.1, 2.0.3 > > Attachments: HBASE-21174.branch-1.001.patch, > HBASE-21174.master.001.patch, HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612334#comment-16612334 ] Hadoop QA commented on HBASE-21174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 34s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} branch-1 passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} branch-1 passed with JDK v1.7.0_191 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 25s{color} | {color:green} hbase-rest: The patch generated 0 new + 16 unchanged - 10 fixed = 16 total (was 26) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 38s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 1m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed with JDK v1.8.0_181 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} the patch passed with JDK v1.7.0_191 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 29s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 9s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 | | JIRA Issue | HBASE-21174 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12939419/HBASE-21174.branch-1.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9afb645f6987 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612212#comment-16612212 ] Hudson commented on HBASE-21174: Results for branch master [build #487 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/487/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/487//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/487//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/487//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch, > HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612038#comment-16612038 ] Hudson commented on HBASE-21174: Results for branch branch-2.1 [build #313 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/313/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/313//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/313//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/313//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch, > HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611928#comment-16611928 ] Hudson commented on HBASE-21174: Results for branch branch-2 [build #1237 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1237/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1237//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1237//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1237//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch, > HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611914#comment-16611914 ] Hudson commented on HBASE-21174: Results for branch branch-2.0 [build #803 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/803/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/803//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/803//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/803//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch, > HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611498#comment-16611498 ] Guangxu Cheng commented on HBASE-21174: --- Pushed to branch-2+.Thanks [~yuzhih...@gmail.com] for review. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch, > HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610046#comment-16610046 ] Guangxu Cheng commented on HBASE-21174: --- QA looks good. Will commit it later today if no objections. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch, > HBASE-21174.master.002.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609456#comment-16609456 ] Hadoop QA commented on HBASE-21174: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 9s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} hbase-rest: The patch generated 0 new + 16 unchanged - 6 fixed = 16 total (was 22) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 10s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 11m 11s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 27s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21174 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12939114/HBASE-21174.master.002.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cee9f462113e 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 2aae247e3f | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14380/testReport/ | | Max. process+thread count | 2101 (vs. ulimit of 1) | | modules | C: hbase-rest U: hbase-rest | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14380/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609309#comment-16609309 ] Hadoop QA commented on HBASE-21174: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 52s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 10s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s{color} | {color:red} hbase-rest: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 10s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 10m 25s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 53s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 9s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 35m 47s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21174 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12938987/HBASE-21174.master.001.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 07f6541f0ec0 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 2aae247e3f | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14379/artifact/patchprocess/diff-checkstyle-hbase-rest.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14379/testReport/ | | Max. process+thread count | 2403 (vs. ulimit of 1) | | modules | C: hbase-rest U: hbase-rest | | Console output |
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608469#comment-16608469 ] Ted Yu commented on HBASE-21174: +1, pending QA > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21174) [REST] Failed to parse empty qualifier in TableResource#getScanResource
[ https://issues.apache.org/jira/browse/HBASE-21174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608419#comment-16608419 ] Guangxu Cheng commented on HBASE-21174: --- Attach first patch for review. Due to HBASE-21158, the new unit test for this issue will cause other unit tests to fail. So, after HBASE-21158 is fixed and then trigger QA. > [REST] Failed to parse empty qualifier in TableResource#getScanResource > --- > > Key: HBASE-21174 > URL: https://issues.apache.org/jira/browse/HBASE-21174 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 3.0.0, 2.2.0 >Reporter: Guangxu Cheng >Assignee: Guangxu Cheng >Priority: Major > Attachments: HBASE-21174.master.001.patch > > > {code:xml} > GET /t1/*?column=f:c1=f: > {code} > If I want to get the values of 'f:'(empty qualifier) for all rows in the > table by rest server, I will send the above request. However, this request > will return all column values. > {code:java|title=TableResource#getScanResource|borderStyle=solid} > for (String csplit : column) { > String[] familysplit = csplit.trim().split(":"); > if (familysplit.length == 2) { > if (familysplit[1].length() > 0) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family and column : " + familysplit[0] + " " + > familysplit[1]); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), > Bytes.toBytes(familysplit[1])); > } else { > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0] + " and empty > qualifier."); > } > tableScan.addColumn(Bytes.toBytes(familysplit[0]), null); > } > } else if (StringUtils.isNotEmpty(familysplit[0])) { > if (LOG.isTraceEnabled()) { > LOG.trace("Scan family : " + familysplit[0]); > } > tableScan.addFamily(Bytes.toBytes(familysplit[0])); > } > } > {code} > Through the above code, when the column has an empty qualifier, the empty > qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) > and 'f' (column family) are considered to have the same meaning, which is > wrong. -- This message was sent by Atlassian JIRA (v7.6.3#76005)