[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Sakthi (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944658#comment-16944658
 ] 

Sakthi commented on HBASE-22735:


Okay looks this issue is not applicable in 1.3 coz HBASE-14925 went in 1.4+ . 
Closing this one.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Sakthi (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943403#comment-16943403
 ] 

Sakthi commented on HBASE-22735:


This commit is missing from 1.3. Let me reopen this one for the cherry-pick

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898150#comment-16898150
 ] 

Hudson commented on HBASE-22735:


Results for branch branch-2.2
[build #487 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/487//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898074#comment-16898074
 ] 

Hudson commented on HBASE-22735:


Results for branch branch-2
[build #2138 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2138//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897999#comment-16897999
 ] 

Hudson commented on HBASE-22735:


Results for branch branch-2.1
[build #1441 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1441//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897957#comment-16897957
 ] 

Hudson commented on HBASE-22735:


Results for branch master
[build #1302 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1302/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1302//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1302//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1302//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897958#comment-16897958
 ] 

Hudson commented on HBASE-22735:


Results for branch branch-1
[build #986 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/986//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897890#comment-16897890
 ] 

Hudson commented on HBASE-22735:


Results for branch branch-1.4
[build #936 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/936/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/936//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/936//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/936//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897692#comment-16897692
 ] 

Andrew Purtell commented on HBASE-22735:


Committed. 

I see why admin.rb's getClusterStatus doesn't work in master. It's fine for 
now. The next version of the patch that reverts ClusterStatus will have to 
address it one way or another.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897681#comment-16897681
 ] 

Andrew Purtell commented on HBASE-22735:


Ok, committing

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897166#comment-16897166
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
3s{color} | {color:red} The patch generated 11 new + 10 unchanged - 11 fixed = 
21 total (was 21) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
30s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 30s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/699/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976334/HBASE-22735-master-tmp-justforreview.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux 7136a8b11f6f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 24b970ec51 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/699/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/699/testReport/ |
| Max. process+thread count | 895 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/699/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> 

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897143#comment-16897143
 ] 

Viraj Jasani commented on HBASE-22735:
--

Commit reverted for HBASE-22744: 
[https://github.com/apache/hbase/commit/24b970ec514b22ebc8bfeb043e301b565db4a59c]

Although the patch should work on master now, based on your suggestion, we can 
move forward.

Attaching one patch for reference(HBASE-22735-master-tmp-justforreview.patch), 
which doesn't have method refactoring as of now but contains changes of using 
latest classes(Metrics classes) and not deprecated classes.

[^HBASE-22735-master-tmp-justforreview.patch]

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735-master-tmp-justforreview.patch, 
> HBASE-22735.branch-1.01.patch, HBASE-22735.branch-1.02.patch, 
> HBASE-22735.branch-1.03.patch, HBASE-22735.branch-1.04.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, HBASE-22735.master.04.patch, Screen Shot 
> 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897039#comment-16897039
 ] 

Viraj Jasani commented on HBASE-22735:
--

Ok, so HBASE-22744 was merged ~20 hr ago. 

[~apurtell] I agree with having admin helper methods with impl details and for 
master branch, we can get data from ServerMetrics(instead of ServerLoad), 
RegionMetrics(instead of RegionLoad), ClusterMetrics(instead of ClusterStatus), 
with all data retrieval methods in admin.rb.

However, is it fine to move/refactor the above logic as part of this JIRA? If 
yes, I can work on patch for master and branch-1 having similar 
logic(additional work for master due to recent deprecation). If not, for now, I 
can keep the above logic with list_regions.rb with updated classes(focus only 
on removing deprecated methods so list_regions is alive) and with another 
followup JIRA, I can focus on moving all the logic to admin.rb and that patch 
can just focus on refactoring for all branches only.

Please let me know your preference.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896661#comment-16896661
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 9s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
10s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
7s{color} | {color:red} The patch generated 16 new + 8 unchanged - 107 fixed = 
24 total (was 115) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 
15s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976268/HBASE-22735.branch-1.04.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux dfafbccceff5 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1 / d08463e |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.8.0_222 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/697/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/697/testReport/ |
| Max. process+thread count | 1686 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/697/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' 

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896601#comment-16896601
 ] 

Andrew Purtell commented on HBASE-22735:


[~vjasani] I think you are definitely going to want to use or add helper 
methods in admin.rb because master branch removed ClusterStatus in favor of non 
deprecated alternatives. See HBASE-22744. Helper methods in admin.rb can hide 
the difference from commands like list_regions. 

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896597#comment-16896597
 ] 

Andrew Purtell commented on HBASE-22735:


This seems fine for branch-1s and branch-2s but currently blocked on commit to 
master

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896596#comment-16896596
 ] 

Andrew Purtell commented on HBASE-22735:


Along those lines, there are support functions in admin.rb that are better 
candidates for implementation instead of direct invocation, especially 
admin.rb::getClusterStatus. Minor, but let's do it. 

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896593#comment-16896593
 ] 

Andrew Purtell commented on HBASE-22735:


The trunk patch actually doesn't work

{noformat}
ERROR: missing class name (`org.apache.hadoop.hbase.ClusterStatus')
{noformat}

See also HBASE-22770

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896592#comment-16896592
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
43s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
45s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
4s{color} | {color:red} The patch generated 16 new + 8 unchanged - 107 fixed = 
24 total (was 115) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 
41s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/696/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976268/HBASE-22735.branch-1.04.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux 1de00209ccec 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1 / b294f7b |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.8.0_222 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/696/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/696/testReport/ |
| Max. process+thread count | 1664 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/696/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' 

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896542#comment-16896542
 ] 

Andrew Purtell commented on HBASE-22735:


Thanks, going to commit


> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.branch-1.04.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, HBASE-22735.master.03.patch, 
> HBASE-22735.master.04.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896497#comment-16896497
 ] 

Viraj Jasani commented on HBASE-22735:
--

Oh My Bad. Indeed, I misunderstood. Let me refresh both patch quickly.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png, 
> screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896490#comment-16896490
 ] 

Andrew Purtell commented on HBASE-22735:


I had a look at 
https://issues.apache.org/jira/secure/attachment/12976251/Screen%20Shot%202019-07-30%20at%2011.53.53%20PM.png
 and it looks great, thank you

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png, 
> screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896488#comment-16896488
 ] 

Andrew Purtell commented on HBASE-22735:


Region name should use Bytest.toStringBinary too because region names are byte 
arrays. Maybe you misunderstood. We are only looking for a formatted example 
that doesn't have crazy long region names or keys. 

A follow up issue could tackle the implication for formatting (maybe it would 
be good to cut off really long region name and key strings past some point like 
40 chars)

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png, 
> screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896487#comment-16896487
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 22m 
52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
4s{color} | {color:red} The patch generated 11 new + 10 unchanged - 11 fixed = 
21 total (was 21) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
0s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 11m 12s{color} 
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 13s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAdminShell |
|   | hadoop.hbase.client.TestShell |
|   | hadoop.hbase.client.TestAdminShell2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/695/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976262/HBASE-22735.master.03.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux 9e83fbfaf3b5 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 373c2dc |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.8.0_222 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/695/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/695/artifact/patchprocess/patch-unit-hbase-shell.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/695/testReport/ |
| Max. process+thread count | 2553 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/695/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png, 
> screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and 

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896459#comment-16896459
 ] 

Viraj Jasani commented on HBASE-22735:
--

Provided screenshot with proper format of list_regions without binary keys. 
Updated the patch for branch-1 and master to ensure region name doesn't contain 
those long binary keys(Bytes.toString). 

However, start/end keys might contain(Bytes.toStringBinary).

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.branch-1.03.patch, 
> HBASE-22735.master.01.patch, HBASE-22735.master.02.patch, 
> HBASE-22735.master.03.patch, Screen Shot 2019-07-30 at 11.53.53 PM.png, 
> screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896324#comment-16896324
 ] 

Andrew Purtell commented on HBASE-22735:


Not really useful. 

Perhaps you can set up an empty test cluster (single host, minicluster) and use 
ltt -init_only or something to show a simple schema without crazy long binary 
keys making it all unintelligible. 

And I see an obvious follow up work item for truncating keys in such listings.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896316#comment-16896316
 ] 

Viraj Jasani commented on HBASE-22735:
--

Attaching screenshot of shell with formatting. Hope this would be useful. 
!screenshot.png!

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, list_regions.out, screenshot.png
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896303#comment-16896303
 ] 

Viraj Jasani commented on HBASE-22735:
--

Not exactly. The formatting is off because of my copy paste. Will provide a 
better screenshot

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896300#comment-16896300
 ] 

stack commented on HBASE-22735:
---

Is it meant to be messed up like that? The formatting is all off.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, abc.png, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896288#comment-16896288
 ] 

stack commented on HBASE-22735:
---

Thanks [~vjasani] ... maybe just paste a picture? The .out is filled w/ 
"\x00"... messes up the view.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896150#comment-16896150
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m  
4s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
6s{color} | {color:red} The patch generated 11 new + 13 unchanged - 8 fixed = 
24 total (was 21) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 12m  8s{color} 
| {color:red} hbase-shell in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 52s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAdminShell2 |
|   | hadoop.hbase.client.TestAdminShell |
|   | hadoop.hbase.client.TestShell |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/692/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976219/HBASE-22735.master.02.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux 7f7ac8d5dbb4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 4a61c8b10a |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/692/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/692/artifact/patchprocess/patch-unit-hbase-shell.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/692/testReport/ |
| Max. process+thread count | 2526 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/692/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.branch-1.02.patch, HBASE-22735.master.01.patch, 
> HBASE-22735.master.02.patch, list_regions.out
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> 

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895847#comment-16895847
 ] 

Viraj Jasani commented on HBASE-22735:
--

Sure, I will look into rubocop cleanup.

In the meanwhile, a sample output for reference:

 
{code:java}
hbase(main):001:0> list_regions 'TEST_TABLE3'
Can not find region: 
TEST_TABLE3,,1556742682042.c01915e746f27516c1b37b9278fcd010. , it may be 
disabled or in transition
Can not find region: 
TEST_TABLE3,\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.1bb308132822e5ff3ca87048caaf50b9.
 , it may be disabled or in transition
SERVER_NAME | REGION_NAME | START_KEY | END_KEY | SIZE | REQ | LOCALITY |
-- | 
--
 | 

 | 

 | - | - | -- |
testserver123.rsserv1.abc.def.lpzk.xyz,60020,1564332024546 | 
TEST_TABLE3,,1556742682042.c01915e746f27516c1b37b9278fcd010. | | 
\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | | | |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 | 
TEST_TABLE3,\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.54c6996f01462ef483bb48421f4625f7.
 | 
\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | 
\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | 0 | 15 | 0.0 |
testserver123.rsserv1.abc.def.lpzk.xyz,60020,1564332024546 | 
TEST_TABLE3,\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.1bb308132822e5ff3ca87048caaf50b9.
 | 
\x02\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | 
\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | | | |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 | 
TEST_TABLE3,\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.613b90d5fae73ad37d0a14970a457df4.
 | 
\x03\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | 
\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00
 | 0 | 15 | 0.0 |
testserver123.rsserv2.abc.def.lpzk.xyz,60020,1564332491127 | 
TEST_TABLE3,\x04\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1556742682042.049037c3b9a28d07562c255c28b5b7f0.
 | 

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[stack (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895780#comment-16895780
 ] 

stack commented on HBASE-22735:
---

lgtm

Mind pasting in a sample of what the output looks like now with your changes? 
Thanks.

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895650#comment-16895650
 ] 

Andrew Purtell commented on HBASE-22735:


I know some of those rubocop warnings aren't due to your changes but would you 
mind taking one pass to clean them up a bit? The ones that look not onerous to 
address are EmptyLines, LineLength, MethodCallWithoutArgsParentheses, 
StringLiterals, and VariableName. 

Otherwise lgtm

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895466#comment-16895466
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
8s{color} | {color:red} The patch generated 12 new + 13 unchanged - 8 fixed = 
25 total (was 21) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 
19s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 26s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/686/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976128/HBASE-22735.master.01.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux 7a34870bbf1c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 11f30de2cf |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/686/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/686/testReport/ |
| Max. process+thread count | 2481 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/686/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[HBase QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895441#comment-16895441
 ] 

HBase QA commented on HBASE-22735:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 6s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red}  0m  
5s{color} | {color:red} The patch generated 46 new + 75 unchanged - 40 fixed = 
121 total (was 115) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green}  0m  
2s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 
36s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 18s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.0 Server=19.03.0 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/685/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22735 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12976127/HBASE-22735.branch-1.01.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  rubocop  
ruby_lint  |
| uname | Linux c18637a2728a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1 / b294f7b |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.8.0_222 |
| rubocop | v0.73.0 |
| rubocop | 
https://builds.apache.org/job/PreCommit-HBASE-Build/685/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.3.1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/685/testReport/ |
| Max. process+thread count | 1687 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/685/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
> Attachments: HBASE-22735.branch-1.01.patch, 
> HBASE-22735.master.01.patch
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894580#comment-16894580
 ] 

Andrew Purtell commented on HBASE-22735:


It's not quite right.

bq. [B@364b1061 

This is the output of object.toString() where the object type is byte[]. It 
should be printed with Bytes.toString(object).

The region is still a part of the table even if in transition. We should 
display some bare information like name, start key, and end key. 

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HBASE-22735) list_regions may throw an error if a region is RIT

[Viraj Jasani (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-22735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894417#comment-16894417
 ] 

Viraj Jasani commented on HBASE-22735:
--

[~apurtell] looks like this is handled in master and branch-2 only: HBASE-18894

Verified the patch with branch-1:

 
{code:java}
hbase(main):003:0> list_regions 'T8'

Can not find region: [B@364b1061 , it may be disabled or in transition


{code}
 

This output looks good? Or should we display some bare minimum info like 
server_name, region_name etc?

 

> list_regions may throw an error if a region is RIT
> --
>
> Key: HBASE-22735
> URL: https://issues.apache.org/jira/browse/HBASE-22735
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 1.5.0
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> The 'list_regions' shell command gets a list of regions for a given table and 
> then prints them and some attributes such as the server where they are 
> located, current request count, data locality, and such. 
> However if a region is in transition the command might fail with
> {{ERROR: undefined method `getDataLocality' for nil:NilClass}}
> and there may be other ways this can happen. Protect against use of nil 
> references and just display what we can. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)