[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949897#comment-16949897
 ] 

Hudson commented on HBASE-23115:


Results for branch branch-2.1
[build #1676 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1676/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1676//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1676//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1676//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949798#comment-16949798
 ] 

Hudson commented on HBASE-23115:


Results for branch branch-2.2
[build #659 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Toshihiro Suzuki (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949486#comment-16949486
 ] 

Toshihiro Suzuki commented on HBASE-23115:
--

Pushed into branch-2.1 and branch-2.2. Thank you for the contribution! 
[~kpalanisamy]

> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-10 Thread Karthik Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948885#comment-16948885
 ] 

Karthik Palanisamy commented on HBASE-23115:


[~brfrn169] The change was conflict with HBASE-22543. Fixed it now. 

Please review the new PR #710. Thanks again [~brfrn169]

> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-10 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948602#comment-16948602
 ] 

Hudson commented on HBASE-23115:


Results for branch master
[build #1499 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1499/]: (/) 
*{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1499//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1499//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1499//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-09 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948142#comment-16948142
 ] 

Hudson commented on HBASE-23115:


Results for branch branch-2
[build #2317 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2317/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2317//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2317//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2317//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-09 Thread Karthik Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947860#comment-16947860
 ] 

Karthik Palanisamy commented on HBASE-23115:


Thank you very much [~brfrn169]. I will submit PR today for branch 2.1/2.2.

> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-09 Thread Toshihiro Suzuki (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947765#comment-16947765
 ] 

Toshihiro Suzuki commented on HBASE-23115:
--

Pushed into master, branch-2. But I faced conflicts when committing the patch 
to branch-2.1 and branch-2.2. Can you please make patches for the branches? 
[~kpalanisamy] One patch is okay if the patch can be applied for both the 
branches.

> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-08 Thread Karthik Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947348#comment-16947348
 ] 

Karthik Palanisamy commented on HBASE-23115:


Please, can someone review this change?

> Unit change for StoreFileSize and MemStoreSize
> --
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> table.jsp page have inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp

2019-10-03 Thread Karthik Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944087#comment-16944087
 ] 

Karthik Palanisamy commented on HBASE-23115:


Made all the possible changes.

> Unit change for StoreFileSize and MemStoreSize in table.jsp
> ---
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> table.jsp page have inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp

2019-10-02 Thread Karthik Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943342#comment-16943342
 ] 

Karthik Palanisamy commented on HBASE-23115:


Found the same issue on another page, rsgroup_jsp.  Will post new commit 
shortly. 

> Unit change for StoreFileSize and MemStoreSize in table.jsp
> ---
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> table.jsp page have inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize in table.jsp

2019-10-02 Thread Karthik Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943218#comment-16943218
 ] 

Karthik Palanisamy commented on HBASE-23115:


Sorry for the spamming messages, it looks to me links are not reflecting 
correctly.

link1 : 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]

link2 : 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1656|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]

link3 : 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/resources/hbase-webapps/master/table.jsp#L488]

link4 : 
[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L1668]

 

> Unit change for StoreFileSize and MemStoreSize in table.jsp
> ---
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
>  Issue Type: Bug
>  Components: metrics, UI
>Affects Versions: 3.0.0
>Reporter: Karthik Palanisamy
>Assignee: Karthik Palanisamy
>Priority: Minor
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but 
> table.jsp page have inaccurate unit. The reason is table.jsp (link3) use 
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform 
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on 
> length. The concern here (link4) is computation (ByteVal/1024/1024) will 
> output always lesser than 1 for store contains few bytes or few kbs.  Also, 
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing 
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB, 
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, 
> setStorefileSizeMB,..
>  
> Please find the attachment, a simple example is posted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)