[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[
https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024632#comment-17024632
]
Hudson commented on HBASE-23705:
Results for branch branch-2
[build #2433 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2433/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2431//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2428//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2427//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2433//console].
> Add CellComparator to HFileContext
> --
>
> Key: HBASE-23705
> URL: https://issues.apache.org/jira/browse/HBASE-23705
> Project: HBase
> Issue Type: Sub-task
> Components: io
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> The HFileContext is present when reading and writing files. It is populated
> at read time using HFile trailer content and file metadata. At write time, we
> create it up front.
> Interesting is that though CellComparator is written to the HFile trailer,
> and parse of the Trailer creates an HFileInfo which builds the HFileContext
> at read time, the HFileContext does not expose what CellComparator to use
> decoding and seeking. Around the codebase there are various compensations
> made for this lack with decoders that actually have a decoding context (with
> a reference to the hfilecontext), hard-coding use of the default
> CellComparator. StoreFileInfo will use default if not passed a comparator
> (even though we'd just read the trailer and even though it has reference to
> filecontext) and HFile does similar. What CellComparator to use in a given
> context is confused.
> Let me fix this situation removing ambiguity. It will also fix bugs in parent
> issue where UTs are failing because wrong CellComparator is being used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[ https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024439#comment-17024439 ] Michael Stack commented on HBASE-23705: --- Re-resolve. I put this patch back. It is not responsible for the branch-2 failures either. > Add CellComparator to HFileContext > -- > > Key: HBASE-23705 > URL: https://issues.apache.org/jira/browse/HBASE-23705 > Project: HBase > Issue Type: Sub-task > Components: io >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > The HFileContext is present when reading and writing files. It is populated > at read time using HFile trailer content and file metadata. At write time, we > create it up front. > Interesting is that though CellComparator is written to the HFile trailer, > and parse of the Trailer creates an HFileInfo which builds the HFileContext > at read time, the HFileContext does not expose what CellComparator to use > decoding and seeking. Around the codebase there are various compensations > made for this lack with decoders that actually have a decoding context (with > a reference to the hfilecontext), hard-coding use of the default > CellComparator. StoreFileInfo will use default if not passed a comparator > (even though we'd just read the trailer and even though it has reference to > filecontext) and HFile does similar. What CellComparator to use in a given > context is confused. > Let me fix this situation removing ambiguity. It will also fix bugs in parent > issue where UTs are failing because wrong CellComparator is being used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[
https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024210#comment-17024210
]
Hudson commented on HBASE-23705:
Results for branch branch-2
[build #2432 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2432/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2432//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2432//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2432//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add CellComparator to HFileContext
> --
>
> Key: HBASE-23705
> URL: https://issues.apache.org/jira/browse/HBASE-23705
> Project: HBase
> Issue Type: Sub-task
> Components: io
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> The HFileContext is present when reading and writing files. It is populated
> at read time using HFile trailer content and file metadata. At write time, we
> create it up front.
> Interesting is that though CellComparator is written to the HFile trailer,
> and parse of the Trailer creates an HFileInfo which builds the HFileContext
> at read time, the HFileContext does not expose what CellComparator to use
> decoding and seeking. Around the codebase there are various compensations
> made for this lack with decoders that actually have a decoding context (with
> a reference to the hfilecontext), hard-coding use of the default
> CellComparator. StoreFileInfo will use default if not passed a comparator
> (even though we'd just read the trailer and even though it has reference to
> filecontext) and HFile does similar. What CellComparator to use in a given
> context is confused.
> Let me fix this situation removing ambiguity. It will also fix bugs in parent
> issue where UTs are failing because wrong CellComparator is being used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[ https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17024081#comment-17024081 ] Michael Stack commented on HBASE-23705: --- On build 2025, these two patches went in and ever after, we have the below test failures The 'periodic dependency bump' does not see to be the cause having tried reverting it and having the test failures still happen. Let me try this one: HBASE-23705 Add CellComparator to HFileContext (#1062) (detail) HBASE-23069 periodic dependency bump for Sep 2019 (#1082) (detail) branch-2 Test Result (9 failures / +1) health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestHFileProcedurePrettyPrinter.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStore.testLoad health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStore.testCleanup health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreCompaction.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreMigration.testMigrateWithUnsupportedProcedures health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreMigration.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreWALCleaner.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestWALProcedurePrettyPrinter.test health checks / yetus jdk8 hadoop2 checks / org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState > Add CellComparator to HFileContext > -- > > Key: HBASE-23705 > URL: https://issues.apache.org/jira/browse/HBASE-23705 > Project: HBase > Issue Type: Sub-task > Components: io >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > The HFileContext is present when reading and writing files. It is populated > at read time using HFile trailer content and file metadata. At write time, we > create it up front. > Interesting is that though CellComparator is written to the HFile trailer, > and parse of the Trailer creates an HFileInfo which builds the HFileContext > at read time, the HFileContext does not expose what CellComparator to use > decoding and seeking. Around the codebase there are various compensations > made for this lack with decoders that actually have a decoding context (with > a reference to the hfilecontext), hard-coding use of the default > CellComparator. StoreFileInfo will use default if not passed a comparator > (even though we'd just read the trailer and even though it has reference to > filecontext) and HFile does similar. What CellComparator to use in a given > context is confused. > Let me fix this situation removing ambiguity. It will also fix bugs in parent > issue where UTs are failing because wrong CellComparator is being used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[
https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022609#comment-17022609
]
Hudson commented on HBASE-23705:
Results for branch branch-2
[build #2425 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2425//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add CellComparator to HFileContext
> --
>
> Key: HBASE-23705
> URL: https://issues.apache.org/jira/browse/HBASE-23705
> Project: HBase
> Issue Type: Sub-task
> Components: io
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> The HFileContext is present when reading and writing files. It is populated
> at read time using HFile trailer content and file metadata. At write time, we
> create it up front.
> Interesting is that though CellComparator is written to the HFile trailer,
> and parse of the Trailer creates an HFileInfo which builds the HFileContext
> at read time, the HFileContext does not expose what CellComparator to use
> decoding and seeking. Around the codebase there are various compensations
> made for this lack with decoders that actually have a decoding context (with
> a reference to the hfilecontext), hard-coding use of the default
> CellComparator. StoreFileInfo will use default if not passed a comparator
> (even though we'd just read the trailer and even though it has reference to
> filecontext) and HFile does similar. What CellComparator to use in a given
> context is confused.
> Let me fix this situation removing ambiguity. It will also fix bugs in parent
> issue where UTs are failing because wrong CellComparator is being used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[
https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022118#comment-17022118
]
Hudson commented on HBASE-23705:
Results for branch master
[build #1606 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1606/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1606//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1606//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1606//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add CellComparator to HFileContext
> --
>
> Key: HBASE-23705
> URL: https://issues.apache.org/jira/browse/HBASE-23705
> Project: HBase
> Issue Type: Sub-task
> Components: io
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> The HFileContext is present when reading and writing files. It is populated
> at read time using HFile trailer content and file metadata. At write time, we
> create it up front.
> Interesting is that though CellComparator is written to the HFile trailer,
> and parse of the Trailer creates an HFileInfo which builds the HFileContext
> at read time, the HFileContext does not expose what CellComparator to use
> decoding and seeking. Around the codebase there are various compensations
> made for this lack with decoders that actually have a decoding context (with
> a reference to the hfilecontext), hard-coding use of the default
> CellComparator. StoreFileInfo will use default if not passed a comparator
> (even though we'd just read the trailer and even though it has reference to
> filecontext) and HFile does similar. What CellComparator to use in a given
> context is confused.
> Let me fix this situation removing ambiguity. It will also fix bugs in parent
> issue where UTs are failing because wrong CellComparator is being used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23705) Add CellComparator to HFileContext
[ https://issues.apache.org/jira/browse/HBASE-23705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018624#comment-17018624 ] Michael Stack commented on HBASE-23705: --- This depends on this one. UTs are broken because encoder is using wrong CellComparator. This issue fixes the wrong CellComparator problem. > Add CellComparator to HFileContext > -- > > Key: HBASE-23705 > URL: https://issues.apache.org/jira/browse/HBASE-23705 > Project: HBase > Issue Type: Sub-task > Components: io >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0, 2.3.0 > > > The HFileContext is present when reading and writing files. It is populated > at read time using HFile trailer content and file metadata. At write time, we > create it up front. > Interesting is that though CellComparator is written to the HFile trailer, > and parse of the Trailer creates an HFileInfo which builds the HFileContext > at read time, the HFileContext does not expose what CellComparator to use > decoding and seeking. Around the codebase there are various compensations > made for this lack with decoders that actually have a decoding context (with > a reference to the hfilecontext), hard-coding use of the default > CellComparator. StoreFileInfo will use default if not passed a comparator > (even though we'd just read the trailer and even though it has reference to > filecontext) and HFile does similar. What CellComparator to use in a given > context is confused. > Let me fix this situation removing ambiguity. It will also fix bugs in parent > issue where UTs are failing because wrong CellComparator is being used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
