[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718703#comment-17718703
]
Hudson commented on HBASE-27762:
Results for branch branch-2.5
[build #346 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/346/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/346/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/346/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/346/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/346/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5, 2.4.18
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718445#comment-17718445
]
Hudson commented on HBASE-27762:
Results for branch branch-2
[build #802 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/802/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/802/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/802/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/802/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/802/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5, 2.4.18
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718431#comment-17718431
]
Hudson commented on HBASE-27762:
Results for branch branch-2.4
[build #553 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/553/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/553/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/553/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/553/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/553/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.5, 2.4.18
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717600#comment-17717600
]
Nick Dimiduk commented on HBASE-27762:
--
Updated all back port branch PRs with the addendum from master, or the local
equivalent.
I considered dropping this change from branch-2.5 and branch-2.4 because we'll
never be able to back port a log4j2 dependency upgrade to those branches (short
of CVE remediation), which means it's unlikely that the fix for LOG4J2-3660
will ever be available there. On the other hand, if someone is struggling to
debug procedure execution on one of these branches (as I was), they'll
appreciate at least having the code changes already deployed. I've posted a new
addendum for just branch-2.5 and 2.4 that reverts the pattern layout changes
entirely for those branches -- we don't want the extra character noise in our
test logs forevermore.
If for some reason LOG4J2-3660 does make it back to branch-2.4,5, we can
re-apply the patternlayout change in test as it suits us.
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716405#comment-17716405
]
Hudson commented on HBASE-27762:
Results for branch master
[build #825 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/825/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/825/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/825/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/825/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715745#comment-17715745
]
Nick Dimiduk commented on HBASE-27762:
--
They've got a fix on LOG4J2-3660 and I've verified that it behaves as I
expected. We'll need to upgrade to a more recent Log4J2, once it's released, in
order to get the fix.
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713730#comment-17713730
]
Hudson commented on HBASE-27762:
Results for branch master
[build #820 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/820/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713560#comment-17713560
]
Duo Zhang commented on HBASE-27762:
---
At least let's mention this in the release note?
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713464#comment-17713464
]
Nick Dimiduk commented on HBASE-27762:
--
This doesn't work. The MDC is always considered as {{nonEmpty}} ("non-null", I
guess), even when it contains no elements.
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713449#comment-17713449
]
Nick Dimiduk commented on HBASE-27762:
--
Oh, hang on. Let me try this {{%notEmpty}} pattern.
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713209#comment-17713209
]
Nick Dimiduk commented on HBASE-27762:
--
Yes, the `({})` is from this issue. We can remove the `()` but I didn't see a
way to conditionally include the MDC map only when it's non-empty. This impacts
every log line... we can revert if you prefer.
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713138#comment-17713138
]
Duo Zhang commented on HBASE-27762:
---
{noformat}
2023-04-17T23:01:57,638 INFO [Listener at localhost/38801 ({})]
{noformat}
The '({})' is added by this issue? So is it possible to avoid logging these
useless symbols if there is no pid or event type?
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3, 2.4.17
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27762) Include EventType and ProcedureV2 pid in logging via MDC
[
https://issues.apache.org/jira/browse/HBASE-27762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705346#comment-17705346
]
Nick Dimiduk commented on HBASE-27762:
--
Could be applied on 2.5, except we should probably treat out logging format as
an interface for consideration under backwards compatibility. Let's back port
only the implementation, log the PatternLayout change and allow operators to
opt-in to the new logging.
> Include EventType and ProcedureV2 pid in logging via MDC
>
>
> Key: HBASE-27762
> URL: https://issues.apache.org/jira/browse/HBASE-27762
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.6.0, 3.0.0-alpha-4, 2.5.3
>Reporter: Nick Dimiduk
>Priority: Major
>
> Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution
> is painful. We are pretty good about logging the {{proc_id}} most of the
> time, but we don't catch them all. Now that we're up on log4j2, let's use the
> MDC feature to include some basic information universally.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
