[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends
[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184220#comment-13184220
]
Hadoop QA commented on HBASE-3565:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510132/HBASE-3565.trunk.v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -147 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 78 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationPeer
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/729//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/729//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/729//console
This message is automatically generated.
Add a metric to keep track of slow HLog appends
---
Key: HBASE-3565
URL: https://issues.apache.org/jira/browse/HBASE-3565
Project: HBase
Issue Type: Improvement
Components: metrics, regionserver
Reporter: Benoit Sigoure
Assignee: Mubarak Seyed
Labels: monitoring
Fix For: 0.94.0
Attachments: HBASE-3565.trunk.v1.patch
Whenever an edit takes too long to be written to an HLog, HBase logs a
warning such as this one:
{code}
2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
editcount=126050
{code}
I would like to have a counter incremented each time this happens and this
counter exposed via the metrics stuff in HBase so I can collect it in my
monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends
[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183754#comment-13183754
]
Zhihong Yu commented on HBASE-3565:
---
Patch looks good to me.
Add a metric to keep track of slow HLog appends
---
Key: HBASE-3565
URL: https://issues.apache.org/jira/browse/HBASE-3565
Project: HBase
Issue Type: Improvement
Components: metrics, regionserver
Reporter: Benoit Sigoure
Labels: monitoring
Attachments: HBASE-3565.trunk.v1.patch
Whenever an edit takes too long to be written to an HLog, HBase logs a
warning such as this one:
{code}
2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
editcount=126050
{code}
I would like to have a counter incremented each time this happens and this
counter exposed via the metrics stuff in HBase so I can collect it in my
monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends
[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183904#comment-13183904
]
stack commented on HBASE-3565:
--
Patch looks good to me. I think the tsdb lads are going to come through and
make us undo resetting of metrics; they argue that should be done out in the
monitoring system let it figure intervals to measure across.. hbase should
just keep outputting counts and times. But lets commit this meantime.
Add a metric to keep track of slow HLog appends
---
Key: HBASE-3565
URL: https://issues.apache.org/jira/browse/HBASE-3565
Project: HBase
Issue Type: Improvement
Components: metrics, regionserver
Reporter: Benoit Sigoure
Assignee: Mubarak Seyed
Labels: monitoring
Fix For: 0.94.0
Attachments: HBASE-3565.trunk.v1.patch
Whenever an edit takes too long to be written to an HLog, HBase logs a
warning such as this one:
{code}
2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
editcount=126050
{code}
I would like to have a counter incremented each time this happens and this
counter exposed via the metrics stuff in HBase so I can collect it in my
monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends
[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175163#comment-13175163
]
Mubarak Seyed commented on HBASE-3565:
--
IMO we need 4 metrics
1. slowHLogAppendsCount (AtomicLong, increment by 1 whenever it takes 1 sec
to append HLog, no reset, long-live until RS runs)
2. minHLogAppendTime (when we log slow appends 1 sec)
3. avgHLogAppendTime
4. maxHLogAppendTime
2, 3, and 4 are needs to get reset upon every doUpdate() for every 5 minutes or
so. For every 5 minutes, we will get 1 min/avg/max HLog append time.
Add a metric to keep track of slow HLog appends
---
Key: HBASE-3565
URL: https://issues.apache.org/jira/browse/HBASE-3565
Project: HBase
Issue Type: Improvement
Components: metrics, regionserver
Reporter: Benoit Sigoure
Labels: monitoring
Whenever an edit takes too long to be written to an HLog, HBase logs a
warning such as this one:
{code}
2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
editcount=126050
{code}
I would like to have a counter incremented each time this happens and this
counter exposed via the metrics stuff in HBase so I can collect it in my
monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends
[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175169#comment-13175169
]
Mubarak Seyed commented on HBASE-3565:
--
I guess metric names are confusing. How about
slowHLogAppendCount
slowHLogAppendMinTime
slowHLogAppendAvgTime
slowHLogAppendMaxTime
Add a metric to keep track of slow HLog appends
---
Key: HBASE-3565
URL: https://issues.apache.org/jira/browse/HBASE-3565
Project: HBase
Issue Type: Improvement
Components: metrics, regionserver
Reporter: Benoit Sigoure
Labels: monitoring
Whenever an edit takes too long to be written to an HLog, HBase logs a
warning such as this one:
{code}
2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
editcount=126050
{code}
I would like to have a counter incremented each time this happens and this
counter exposed via the metrics stuff in HBase so I can collect it in my
monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3565) Add a metric to keep track of slow HLog appends
[
https://issues.apache.org/jira/browse/HBASE-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175200#comment-13175200
]
Mubarak Seyed commented on HBASE-3565:
--
slowHLogAppendCount
slowHLogAppendTime
-slowHLogAppendMinTime-
-slowHLogAppendAvgTime-
-slowHLogAppendMaxTime-
Waiting for corporate approval to contribute this patch. Thanks.
Add a metric to keep track of slow HLog appends
---
Key: HBASE-3565
URL: https://issues.apache.org/jira/browse/HBASE-3565
Project: HBase
Issue Type: Improvement
Components: metrics, regionserver
Reporter: Benoit Sigoure
Labels: monitoring
Whenever an edit takes too long to be written to an HLog, HBase logs a
warning such as this one:
{code}
2011-02-23 20:03:14,703 WARN org.apache.hadoop.hbase.regionserver.wal.HLog:
IPC Server handler 21 on 60020 took 15065ms appending an edit to hlog;
editcount=126050
{code}
I would like to have a counter incremented each time this happens and this
counter exposed via the metrics stuff in HBase so I can collect it in my
monitoring system.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
