[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2012-03-22 Thread Lars Hofhansl (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235939#comment-13235939
 ] 

Lars Hofhansl commented on HBASE-4607:
--

Nice. Thanks Mikhail.

> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 
> HBASE-4607_SplitLogWorker_should_correct-20111017231456-47a82ef3.patch
>
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2012-03-22 Thread Mikhail Bautin (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235926#comment-13235926
 ] 

Mikhail Bautin commented on HBASE-4607:
---

Tried to apply the patch, but it shows as already applied. Upon further 
analysis, very similar changes to SplitLogWorker have been integrated as part 
of HBASE-5542:

svn diff -r 1303648:1303920  
https://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java


> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 
> HBASE-4607_SplitLogWorker_should_correct-20111017231456-47a82ef3.patch
>
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2012-03-22 Thread stack (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235890#comment-13235890
 ] 

stack commented on HBASE-4607:
--

Seems fine to me.  +1

> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 
> HBASE-4607_SplitLogWorker_should_correct-20111017231456-47a82ef3.patch
>
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2012-03-22 Thread Lars Hofhansl (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235736#comment-13235736
 ] 

Lars Hofhansl commented on HBASE-4607:
--

+1 on v2 even though most of it are whitespace changes.

> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 
> HBASE-4607_SplitLogWorker_should_correct-20111017231456-47a82ef3.patch
>
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2012-03-21 Thread Lars Hofhansl (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234903#comment-13234903
 ] 

Lars Hofhansl commented on HBASE-4607:
--

Can this be committed?

> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 
> HBASE-4607_SplitLogWorker_should_correct-20111017231456-47a82ef3.patch
>
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2011-10-18 Thread Mikhail Bautin (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129822#comment-13129822
 ] 

Mikhail Bautin commented on HBASE-4607:
---

Unit tests seem to succeed, except for usual spurious failures.

2011-10-17_23_26_13 commit: Checking exitWorker in the loop | tests: 1039, 
fail: 0, err: 0, skip: 16, time: 5872.1
2011-10-18_01_45_52 commit: Checking exitWorker in the loop | tests: 1039, 
fail: 1, err: 1, skip: 16, time: 5797.7, failed: CoprocessorEndpoint, 
MasterObserver
2011-10-18_04_05_43 commit: Checking exitWorker in the loop | tests: 1039, 
fail: 0, err: 0, skip: 16, time: 5681.3
2011-10-18_06_23_25 commit: Checking exitWorker in the loop | tests: 1039, 
fail: 1, err: 0, skip: 16, time: 5958.7, failed: ServerCustomProtocol


> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
> Attachments: 
> HBASE-4607_SplitLogWorker_should_correct-20111017231456-47a82ef3.patch
>
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2011-10-17 Thread Ted Yu (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129534#comment-13129534
 ] 

Ted Yu commented on HBASE-4607:
---

+1 on patch v2, if tests pass. 

> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2011-10-17 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129528#comment-13129528
 ] 

jirapos...@reviews.apache.org commented on HBASE-4607:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2411/
---

(Updated 2011-10-18 06:16:36.326253)


Review request for hbase and Prakash Khemani.


Changes
---

Addressing Ted's comment. Also making taskLoop handle the exitWorker flag more 
uniformly. I will re-run unit tests.


Summary
---

This is an attempt to fix the fact that SplitLogWorker threads are not being 
terminated properly in some unit tests. This probably does not happen in 
production because the master always creates the log-splitting ZK node, but it 
does happen in 89-fb. Thanks to Prakash Khemani for help on this.


This addresses bug hbase-4607.
https://issues.apache.org/jira/browse/hbase-4607


Diffs (updated)
-

  src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java 
a43e0b3 

Diff: https://reviews.apache.org/r/2411/diff


Testing
---

I will run unit tests and post an update when they have passed.


Thanks,

Mikhail



> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2011-10-17 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129340#comment-13129340
 ] 

jirapos...@reviews.apache.org commented on HBASE-4607:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2411/#review2635
---



src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java


If exitWorker is false, we would enter taskLoop at line 167.
Is this desirable ?


- Ted


On 2011-10-17 22:41:49, Mikhail Bautin wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2411/
bq.  ---
bq.  
bq.  (Updated 2011-10-17 22:41:49)
bq.  
bq.  
bq.  Review request for hbase and Prakash Khemani.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is an attempt to fix the fact that SplitLogWorker threads are not 
being terminated properly in some unit tests. This probably does not happen in 
production because the master always creates the log-splitting ZK node, but it 
does happen in 89-fb. Thanks to Prakash Khemani for help on this.
bq.  
bq.  
bq.  This addresses bug hbase-4607.
bq.  https://issues.apache.org/jira/browse/hbase-4607
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java 
a43e0b3 
bq.  
bq.  Diff: https://reviews.apache.org/r/2411/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  I will run unit tests and post an update when they have passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mikhail
bq.  
bq.



> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4607) Split log worker should terminate properly when waiting for znode

2011-10-17 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129297#comment-13129297
 ] 

jirapos...@reviews.apache.org commented on HBASE-4607:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2411/
---

Review request for hbase and Prakash Khemani.


Summary
---

This is an attempt to fix the fact that SplitLogWorker threads are not being 
terminated properly in some unit tests. This probably does not happen in 
production because the master always creates the log-splitting ZK node, but it 
does happen in 89-fb. Thanks to Prakash Khemani for help on this.


This addresses bug hbase-4607.
https://issues.apache.org/jira/browse/hbase-4607


Diffs
-

  src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java 
a43e0b3 

Diff: https://reviews.apache.org/r/2411/diff


Testing
---

I will run unit tests and post an update when they have passed.


Thanks,

Mikhail



> Split log worker should terminate properly when waiting for znode
> -
>
> Key: HBASE-4607
> URL: https://issues.apache.org/jira/browse/HBASE-4607
> Project: HBase
>  Issue Type: Bug
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
>Priority: Minor
>
> This is an attempt to fix the fact that SplitLogWorker threads are not being 
> terminated properly in some unit tests. This probably does not happen in 
> production because the master always creates the log-splitting ZK node, but 
> it does happen in 89-fb. Thanks to Prakash Khemani for help on this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira