[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162659#comment-13162659
]
Hudson commented on HBASE-4945:
---
Integrated in HBase-TRUNK-security #22 (See
[https://builds.apache.org/job/HBase-TRUNK-security/22/])
HBASE-4945 NPE in HRegion.bulkLoadHFiles (Andrew P and Lars H)
larsh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
Fix For: 0.94.0, 0.92.1
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162768#comment-13162768
]
Hudson commented on HBASE-4945:
---
Integrated in HBase-0.92-security #30 (See
[https://builds.apache.org/job/HBase-0.92-security/30/])
HBASE-4945 NPE in HRegion.bulkLoadHFiles (Andrew P and Lars H)
larsh :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
Fix For: 0.94.0, 0.92.1
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162440#comment-13162440
]
Lars Hofhansl commented on HBASE-4945:
--
Test failures are unrelated... Will commit in a bit.
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Priority: Minor
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162507#comment-13162507
]
Hudson commented on HBASE-4945:
---
Integrated in HBase-0.92 #169 (See
[https://builds.apache.org/job/HBase-0.92/169/])
HBASE-4945 NPE in HRegion.bulkLoadHFiles (Andrew P and Lars H)
larsh :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
Fix For: 0.94.0, 0.92.1
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162534#comment-13162534
]
Hudson commented on HBASE-4945:
---
Integrated in HBase-TRUNK #2514 (See
[https://builds.apache.org/job/HBase-TRUNK/2514/])
HBASE-4945 NPE in HRegion.bulkLoadHFiles (Andrew P and Lars H)
larsh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
Fix For: 0.94.0, 0.92.1
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162275#comment-13162275
]
Ted Yu commented on HBASE-4945:
---
Good catch, Lars.
I think the fix should go to 0.92
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Priority: Minor
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162287#comment-13162287
]
Lars Hofhansl commented on HBASE-4945:
--
+1 that's exactly the patch I had in mind.
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Priority: Minor
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4945) NPE in HRegion.bulkLoadHFiles(...)
[
https://issues.apache.org/jira/browse/HBASE-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162305#comment-13162305
]
Hadoop QA commented on HBASE-4945:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506019/HBASE-4945.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -160 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 71 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.client.TestInstantSchemaChange
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/438//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/438//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/438//console
This message is automatically generated.
NPE in HRegion.bulkLoadHFiles(...)
--
Key: HBASE-4945
URL: https://issues.apache.org/jira/browse/HBASE-4945
Project: HBase
Issue Type: Bug
Components: mapreduce
Affects Versions: 0.92.0, 0.94.0
Reporter: Lars Hofhansl
Priority: Minor
Attachments: HBASE-4945.patch
Was playing with completebulkload, and ran into an NPE.
The problem is here (HRegion.bulkLoadHFiles(...)).
{code}
Store store = getStore(familyName);
if (store == null) {
IOException ioe = new DoNotRetryIOException(
No such column family + Bytes.toStringBinary(familyName));
ioes.add(ioe);
failures.add(p);
}
try {
store.assertBulkLoadHFileOk(new Path(path));
} catch (WrongRegionException wre) {
// recoverable (file doesn't fit in region)
failures.add(p);
} catch (IOException ioe) {
// unrecoverable (hdfs problem)
ioes.add(ioe);
}
{code}
This should be
{code}
Store store = getStore(familyName);
if (store == null) {
...
} else {
try {
store.assertBulkLoadHFileOk(new Path(path));
...
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
