[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490405#comment-13490405 ] Hudson commented on HBASE-6518: --- Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/]) HBASE-7016 port HBASE-6518 'Bytes.toBytesBinary() incorrect trailing backslash escape' to 0.94 (Revision 1401127) Result = FAILURE enis : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Fix For: 0.96.0 Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482046#comment-13482046 ] Hudson commented on HBASE-6518: --- Integrated in HBase-0.94 #547 (See [https://builds.apache.org/job/HBase-0.94/547/]) HBASE-7016 port HBASE-6518 'Bytes.toBytesBinary() incorrect trailing backslash escape' to 0.94 (Revision 1401127) Result = SUCCESS enis : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Fix For: 0.96.0 Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13455654#comment-13455654 ] Tudor Scurtu commented on HBASE-6518: - Thank you, too. Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Fix For: 0.96.0 Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453977#comment-13453977 ] Michael Drzal commented on HBASE-6518: -- +1 on the patch Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13454356#comment-13454356 ] Hudson commented on HBASE-6518: --- Integrated in HBase-TRUNK #3324 (See [https://builds.apache.org/job/HBase-TRUNK/3324/]) HBASE-6518 Bytes.toBytesBinary() incorrect trailing backslash escape (Revision 1384103) Result = FAILURE stack : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Fix For: 0.96.0 Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13454507#comment-13454507 ] Hudson commented on HBASE-6518: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #170 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/170/]) HBASE-6518 Bytes.toBytesBinary() incorrect trailing backslash escape (Revision 1384103) Result = FAILURE stack : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Fix For: 0.96.0 Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[
https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429398#comment-13429398
]
stack commented on HBASE-6518:
--
+1 on the patch.
In future, you don't need to catch the exception and then fail... just let it
out... that'll fail the test
{code}
+} catch (StringIndexOutOfBoundsException ex) {
+ fail(Illegal string access: + ex.getMessage());
+}
{code}
Also, we put spaces around operators in our code. See the rest of the code.
Let me run this by the hadoopqa to see if it passes
Bytes.toBytesBinary() incorrect trailing backslash escape
-
Key: HBASE-6518
URL: https://issues.apache.org/jira/browse/HBASE-6518
Project: HBase
Issue Type: Bug
Components: util
Reporter: Tudor Scurtu
Assignee: Tudor Scurtu
Priority: Trivial
Labels: patch
Attachments: HBASE-6518.patch
Bytes.toBytesBinary() converts escaped strings to byte arrays. When
encountering a '\' character, it looks at the next one to see if it is an
'x', without checking if it exists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6518) Bytes.toBytesBinary() incorrect trailing backslash escape
[ https://issues.apache.org/jira/browse/HBASE-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429454#comment-13429454 ] Hadoop QA commented on HBASE-6518: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539320/HBASE-6518.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2523//console This message is automatically generated. Bytes.toBytesBinary() incorrect trailing backslash escape - Key: HBASE-6518 URL: https://issues.apache.org/jira/browse/HBASE-6518 Project: HBase Issue Type: Bug Components: util Reporter: Tudor Scurtu Assignee: Tudor Scurtu Priority: Trivial Labels: patch Attachments: HBASE-6518.patch Bytes.toBytesBinary() converts escaped strings to byte arrays. When encountering a '\' character, it looks at the next one to see if it is an 'x', without checking if it exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
