[jira] [Commented] (HBASE-6865) Snapshot File Cleaners
[
https://issues.apache.org/jira/browse/HBASE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13498526#comment-13498526
]
Hadoop QA commented on HBASE-6865:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553723/hbase-6865-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 13 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3350//console
This message is automatically generated.
Snapshot File Cleaners
--
Key: HBASE-6865
URL: https://issues.apache.org/jira/browse/HBASE-6865
Project: HBase
Issue Type: Sub-task
Reporter: Jesse Yates
Assignee: Jesse Yates
Fix For: hbase-6055
Attachments: hbase-6865-v2.patch
HFile and HLog cleaners are necessary for fully implementing snapshots, but
can be broken out into their own piece really cleanly. The HFile cleaner is
necessary for both timestamp and globally consistent snapshots, but the HLog
cleaner is necessary for globally consistent and offline snapshots.
Putting everything together in one patch isn't too much overload as there is
a lot of overlap between the cleaners.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6865) Snapshot File Cleaners
[ https://issues.apache.org/jira/browse/HBASE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491787#comment-13491787 ] Jonathan Hsieh commented on HBASE-6865: --- review is here. https://reviews.apache.org/r/7627/ Snapshot File Cleaners -- Key: HBASE-6865 URL: https://issues.apache.org/jira/browse/HBASE-6865 Project: HBase Issue Type: Sub-task Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 HFile and HLog cleaners are necessary for fully implementing snapshots, but can be broken out into their own piece really cleanly. The HFile cleaner is necessary for both timestamp and globally consistent snapshots, but the HLog cleaner is necessary for globally consistent and offline snapshots. Putting everything together in one patch isn't too much overload as there is a lot of overlap between the cleaners. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6865) Snapshot File Cleaners
[ https://issues.apache.org/jira/browse/HBASE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491793#comment-13491793 ] Jonathan Hsieh commented on HBASE-6865: --- High order bits. from v2 1) There is a cache for hfile directory listings and a separate cache for hlog file directory listings. 2) There are two main caches likely get plugged into the archive cleaner (but it doesn't seem to happen in this patch). 4) There are some a non standard use of a setter that is in the is a limitation of the cleaner api. There should be a follow on issue to help that be more conventional. Snapshot File Cleaners -- Key: HBASE-6865 URL: https://issues.apache.org/jira/browse/HBASE-6865 Project: HBase Issue Type: Sub-task Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 HFile and HLog cleaners are necessary for fully implementing snapshots, but can be broken out into their own piece really cleanly. The HFile cleaner is necessary for both timestamp and globally consistent snapshots, but the HLog cleaner is necessary for globally consistent and offline snapshots. Putting everything together in one patch isn't too much overload as there is a lot of overlap between the cleaners. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6865) Snapshot File Cleaners
[ https://issues.apache.org/jira/browse/HBASE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491841#comment-13491841 ] Ted Yu commented on HBASE-6865: --- @Jon: Can you clarify point #4 above (w.r.t. where the setter is) ? Snapshot File Cleaners -- Key: HBASE-6865 URL: https://issues.apache.org/jira/browse/HBASE-6865 Project: HBase Issue Type: Sub-task Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 HFile and HLog cleaners are necessary for fully implementing snapshots, but can be broken out into their own piece really cleanly. The HFile cleaner is necessary for both timestamp and globally consistent snapshots, but the HLog cleaner is necessary for globally consistent and offline snapshots. Putting everything together in one patch isn't too much overload as there is a lot of overlap between the cleaners. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6865) Snapshot File Cleaners
[ https://issues.apache.org/jira/browse/HBASE-6865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491864#comment-13491864 ] Jonathan Hsieh commented on HBASE-6865: --- (Oops, there was a point 3 but it got folded into one of the others). [~te...@apache.org] Take a look at this link and some of the comments around it and its analog. https://reviews.apache.org/r/7627/diff/2/?file=183690#file183690line64 Setters conventionally don't io, doesn't start threads, and can be called anytime in the lifecycle of an object. In the code in this patch, the conf being is more like part of a constructor or a thread start method. Specifically, it instantiates a cache object that has a thread. Hm.. I should have asked why it wasn't in the constructor -- I'll add that to the review. Snapshot File Cleaners -- Key: HBASE-6865 URL: https://issues.apache.org/jira/browse/HBASE-6865 Project: HBase Issue Type: Sub-task Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 HFile and HLog cleaners are necessary for fully implementing snapshots, but can be broken out into their own piece really cleanly. The HFile cleaner is necessary for both timestamp and globally consistent snapshots, but the HLog cleaner is necessary for globally consistent and offline snapshots. Putting everything together in one patch isn't too much overload as there is a lot of overlap between the cleaners. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
