[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859808#comment-13859808
]
Hudson commented on HBASE-7226:
---
FAILURE: Integrated in hbase-0.96-hadoop2 #166 (See
[https://builds.apache.org/job/hbase-0.96-hadoop2/166/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553712)
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858221#comment-13858221
]
Feng Honghua commented on HBASE-7226:
-
thanks [~lhofhansl] [~yuzhih...@gmail.com] [~apurtell] [~stack] for prompt
response/review/resolving. :-)
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857415#comment-13857415
]
Hudson commented on HBASE-7226:
---
FAILURE: Integrated in HBase-0.98 #39 (See
[https://builds.apache.org/job/HBase-0.98/39/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553454)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857551#comment-13857551
]
stack commented on HBASE-7226:
--
+1 for 0.96
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857690#comment-13857690
]
Hudson commented on HBASE-7226:
---
SUCCESS: Integrated in HBase-0.94-security #372 (See
[https://builds.apache.org/job/HBase-0.94-security/372/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553714)
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857718#comment-13857718
]
Hudson commented on HBASE-7226:
---
FAILURE: Integrated in HBase-0.94 #1240 (See
[https://builds.apache.org/job/HBase-0.94/1240/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553714)
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857750#comment-13857750
]
Hudson commented on HBASE-7226:
---
SUCCESS: Integrated in hbase-0.96 #245 (See
[https://builds.apache.org/job/hbase-0.96/245/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553712)
*
/hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.96.2, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856819#comment-13856819
]
Hudson commented on HBASE-7226:
---
SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #37 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/37/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553454)
*
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856848#comment-13856848
]
Hudson commented on HBASE-7226:
---
FAILURE: Integrated in HBase-TRUNK #4761 (See
[https://builds.apache.org/job/HBase-TRUNK/4761/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553453)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857193#comment-13857193
]
Hudson commented on HBASE-7226:
---
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #26 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/26/])
HBASE-7226 HRegion.checkAndMutate uses incorrect comparison result for , =,
and = (tedyu: rev 1553453)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.98.0, 0.94.16, 0.99.0
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856550#comment-13856550
]
Feng Honghua commented on HBASE-7226:
-
Can this be resolved and committed? any further issue? [~yuzhih...@gmail.com] /
[~lhofhansl], thanks :-)
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856582#comment-13856582
]
Ted Yu commented on HBASE-7226:
---
Andrew announced soft freeze on 0.98 branch.
His endorsement is needed for 0.98
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856583#comment-13856583
]
Feng Honghua commented on HBASE-7226:
-
I see, thanks [~yuzhih...@gmail.com]
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856637#comment-13856637
]
Lars Hofhansl commented on HBASE-7226:
--
Let's also use some common sense :)
I certainly do not have to approve every bug fix for 0.94; nor do I want to.
Can't speak for them, but [~stack] and [~apurtell] will probably not want to do
that for each bug fix either.
For 0.94 I have been building the release directly from the svn tag (so there
is also no need to do a freeze for release purposes - of course there might be
other reasons, though).
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856643#comment-13856643
]
Andrew Purtell commented on HBASE-7226:
---
I did ask for the next couple of weeks that someone ping me before committing
to 0.98. Just mention me in the JIRA using '[ ~ apurtell ]' (remove the spaces)
and I will come take a look. Normally that won't be necessary.
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856648#comment-13856648
]
Lars Hofhansl commented on HBASE-7226:
--
You fine with this going in [~apurtell]?
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856658#comment-13856658
]
Andrew Purtell commented on HBASE-7226:
---
+1, sorry that was implied but not stated
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855340#comment-13855340
]
Feng Honghua commented on HBASE-7226:
-
provide fix and unit-test to prove it for trunk. but this bug should exist in
all branches(I think), please branch owners check and apply accordingly
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Attachments: HBASE-7226-trunk.patch, HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855344#comment-13855344
]
Lars Hofhansl commented on HBASE-7226:
--
I'll check the test, seems you were right all along. Thanks for persisting :)
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk.patch, HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855349#comment-13855349
]
Ted Yu commented on HBASE-7226:
---
lgtm
nit: long line:
{code}
+ // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2,
succeed (value still = val2)
{code}
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk.patch, HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855365#comment-13855365
]
Feng Honghua commented on HBASE-7226:
-
thanks [~lhofhansl] and [~yuzhih...@gmail.com], attach a new patch per
[~yuzhih...@gmail.com]'s feedback
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855419#comment-13855419
]
Hadoop QA commented on HBASE-7226:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12620124/HBASE-7226-trunk-v2.patch
against trunk revision .
ATTACHMENT ID: 12620124
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8262//console
This message is automatically generated.
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Feng Honghua
Assignee: Feng Honghua
Fix For: 0.94.16
Attachments: HBASE-7226-trunk-v2.patch, HBASE-7226-trunk.patch,
HRegion_HBASE_7226_0.94.2.patch
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535674#comment-13535674
]
Lars Hofhansl commented on HBASE-7226:
--
Yeah, I doubt this too. This would not have gone unnoticed for so long.
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.2
Environment: 0.94.2
Reporter: Feng Honghua
Priority: Minor
Fix For: 0.94.4
Attachments: HRegion_HBASE_7226_0.94.2.patch
Original Estimate: 10m
Remaining Estimate: 10m
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535682#comment-13535682
]
Lars Hofhansl commented on HBASE-7226:
--
Although it does look like the code is indeed incorrect.
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.2
Environment: 0.94.2
Reporter: Feng Honghua
Priority: Minor
Fix For: 0.94.4
Attachments: HRegion_HBASE_7226_0.94.2.patch
Original Estimate: 10m
Remaining Estimate: 10m
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505678#comment-13505678
]
stack commented on HBASE-7226:
--
I'm not sure your patch correct. Could you add a unit test to prove it is?
Thank you Feng.
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.2
Environment: 0.94.2
Reporter: Feng Honghua
Priority: Minor
Fix For: 0.94.2
Attachments: HRegion_HBASE_7226_0.94.2.patch
Original Estimate: 10m
Remaining Estimate: 10m
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505236#comment-13505236
]
Feng Honghua commented on HBASE-7226:
-
the same typo bug exists for trunk as well
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.2
Environment: 0.94.2
Reporter: Feng Honghua
Priority: Minor
Fix For: 0.94.2
Attachments: checkAndMutate.patch
Original Estimate: 10m
Remaining Estimate: 10m
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for , =, and =
[
https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505242#comment-13505242
]
Hadoop QA commented on HBASE-7226:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12555119/HRegion_HBASE_7226_0.94.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3416//console
This message is automatically generated.
HRegion.checkAndMutate uses incorrect comparison result for , =, and =
---
Key: HBASE-7226
URL: https://issues.apache.org/jira/browse/HBASE-7226
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.2
Environment: 0.94.2
Reporter: Feng Honghua
Priority: Minor
Fix For: 0.94.2
Attachments: HRegion_HBASE_7226_0.94.2.patch
Original Estimate: 10m
Remaining Estimate: 10m
in HRegion.checkAndMutate, incorrect comparison results are used for , =,
and =, as below:
switch (compareOp) {
case LESS:
matches = compareResult = 0; // should be '' here
break;
case LESS_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case EQUAL:
matches = compareResult == 0;
break;
case NOT_EQUAL:
matches = compareResult != 0;
break;
case GREATER_OR_EQUAL:
matches = compareResult 0; // should be '=' here
break;
case GREATER:
matches = compareResult = 0; // should be '' here
break;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
