[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528907#comment-13528907 ] Hudson commented on HBASE-7250: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #292 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/292/]) HBASE-7250 create integration test for balancing regions and killing region servers - 2 (Revision 1420003) HBASE-7250 create integration test for balancing regions and killing region servers - 2 (Revision 1420002) Result = FAILURE stack : Files : * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestRebalanceAndKillServersTargeted.java stack : Files : * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch, HBASE-7250-v2.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528579#comment-13528579 ] Sergey Shelukhin commented on HBASE-7250: - bq. Should the numbers provided here be configurable? Some of them, probably... maybe with base class participating. Although they should be changeable together with all other test parameters. Rest - fixed. create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528602#comment-13528602 ] Enis Soztutar commented on HBASE-7250: -- bq. The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master) Is the first test useful on it's own? Other than that, the patch looks good. create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch, HBASE-7250-v2.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528652#comment-13528652 ] Sergey Shelukhin commented on HBASE-7250: - bq. Is the first test useful on it's own? Not sure; it also kills master, but doesn't really test any particular scenario. Do you want to remove it? create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch, HBASE-7250-v2.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528691#comment-13528691 ] stack commented on HBASE-7250: -- +1 on patch. +1 on removing a test that is too general especially since it has not yet been included in a release. Can do in another issue? Let me commit this one. create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch, HBASE-7250-v2.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528737#comment-13528737 ] Hudson commented on HBASE-7250: --- Integrated in HBase-TRUNK #3609 (See [https://builds.apache.org/job/HBase-TRUNK/3609/]) HBASE-7250 create integration test for balancing regions and killing region servers - 2 (Revision 1420003) HBASE-7250 create integration test for balancing regions and killing region servers - 2 (Revision 1420002) Result = FAILURE stack : Files : * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestRebalanceAndKillServersTargeted.java stack : Files : * /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Fix For: 0.96.0 Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch, HBASE-7250-v2.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508996#comment-13508996 ] Sergey Shelukhin commented on HBASE-7250: - renamed the action; wrt SecureRandom - are you sure it's necessary? Nothing particularly security-sensitive about ChaosMonkey. Or is it a general guideline to use it? On minicluster, the test fails, I only ran it on full cluster before... I will see why it fails, looks like clients aren't syncing meta properly. create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HBASE-7250-v0.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[ https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509477#comment-13509477 ] Sergey Shelukhin commented on HBASE-7250: - after fixing some issue that I found the test still fails to put w/no useful logging... I will add logging tomorrow to debug it more. Meanwhile, the patch. create integration test for balancing regions and killing region servers - 2 Key: HBASE-7250 URL: https://issues.apache.org/jira/browse/HBASE-7250 Project: HBase Issue Type: Improvement Components: test Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Priority: Minor Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch The original test is too general; need another one that would be more targeted and would test master logic in particular (e.g. not kill master). I re-discovered HBASE-6060 using it on the first run :) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[
https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509493#comment-13509493
]
Hadoop QA commented on HBASE-7250:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12555890/HBASE-7250-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
101 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 26 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3442//console
This message is automatically generated.
create integration test for balancing regions and killing region servers - 2
Key: HBASE-7250
URL: https://issues.apache.org/jira/browse/HBASE-7250
Project: HBase
Issue Type: Improvement
Components: test
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch
The original test is too general; need another one that would be more
targeted and would test master logic in particular (e.g. not kill master). I
re-discovered HBASE-6060 using it on the first run :)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[
https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509505#comment-13509505
]
stack commented on HBASE-7250:
--
Something wrong in the class comment here?
{code}
hbase.IntegrationTestRebalanceAndKillServers s.runtime
{code}
Should you say anything in class comment about which configs effect data size,
how frequently the kills run, etc? I see the class comment as what a user will
peruse figuring if they want to run the test. Should list the knobs to twiddle
I'd say.
Should the numbers provided here be configurable?
+runIngestTest(DEFAULT_RUN_TIME, 2500, 10, 100, 20);
Patch looks good to me.
create integration test for balancing regions and killing region servers - 2
Key: HBASE-7250
URL: https://issues.apache.org/jira/browse/HBASE-7250
Project: HBase
Issue Type: Improvement
Components: test
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch
The original test is too general; need another one that would be more
targeted and would test master logic in particular (e.g. not kill master). I
re-discovered HBASE-6060 using it on the first run :)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[
https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508409#comment-13508409
]
Hadoop QA commented on HBASE-7250:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/1293/HBASE-7250-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 26 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3431//console
This message is automatically generated.
create integration test for balancing regions and killing region servers - 2
Key: HBASE-7250
URL: https://issues.apache.org/jira/browse/HBASE-7250
Project: HBase
Issue Type: Improvement
Components: test
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7250-v0.patch
The original test is too general; need another one that would be more
targeted and would test master logic in particular (e.g. not kill master). I
re-discovered HBASE-6060 using it on the first run :)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7250) create integration test for balancing regions and killing region servers - 2
[
https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508415#comment-13508415
]
Ted Yu commented on HBASE-7250:
---
@Sergey:
Can you share with us the test result when you run
IntegrationTestRebalanceAndKillServersTargeted locally ?
{code}
+protected Random random = new Random();
{code}
Suggest using 'new SecureRandom()' on the right hand side above.
{code}
+ /** This action is too specific to put in ChaosMonkey; put it here */
+ static class ChaosMonkeyAction extends ChaosMonkey.Action {
{code}
nit: it would be nice if the action class name can be bit more descriptive.
create integration test for balancing regions and killing region servers - 2
Key: HBASE-7250
URL: https://issues.apache.org/jira/browse/HBASE-7250
Project: HBase
Issue Type: Improvement
Components: test
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7250-v0.patch
The original test is too general; need another one that would be more
targeted and would test master logic in particular (e.g. not kill master). I
re-discovered HBASE-6060 using it on the first run :)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
